From 04e84a775237791e7539481c458da319f4761012 Mon Sep 17 00:00:00 2001 From: Major Hayden Date: Sun, 12 Aug 2007 19:11:35 +0000 Subject: [PATCH] Minor divide by zero error in query cache calculations --- mysqltuner.pl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index f97ba1c..63ea2f2 100644 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -284,8 +284,10 @@ sub calculations { # Query cache if ($mysqlvermajor > 3) { $mycalc{'query_cache_efficiency'} = sprintf("%.1f",($mystat{'Qcache_hits'} / ($mystat{'Com_select'} + $mystat{'Qcache_hits'})) * 100); - $mycalc{'pct_query_cache_used'} = sprintf("%.1f",100 - ($mystat{'Qcache_free_memory'} / $myvar{'query_cache_size'}) * 100); - if ($mystat{'Qcache_lowmem_prunes'} == 0) { + if ($myvar{'query_cache_size'}) { + $mycalc{'pct_query_cache_used'} = sprintf("%.1f",100 - ($mystat{'Qcache_free_memory'} / $myvar{'query_cache_size'}) * 100); + } + if ($mystat{'Qcache_lowmem_prunes'} == 0) { $mycalc{'query_cache_prunes_per_day'} = 0; } else { $mycalc{'query_cache_prunes_per_day'} = int($mystat{'Qcache_lowmem_prunes'} / ($mystat{'Uptime'}/86400)); @@ -547,4 +549,4 @@ mysql_stats; # Print the server stats make_recommendations; # Make recommendations based on stats # --------------------------------------------------------------------------- # END 'MAIN' -# --------------------------------------------------------------------------- \ No newline at end of file +# ---------------------------------------------------------------------------