Merge branch 'major:master' into master

.github/workflows/update_cve_and_docs.yml

@@ -5,8 +5,8 @@ name: CVE and Docs update
 # Controls when the workflow will run
 on:
   # Scheudle every sunday at 00:00
-  schedule:
-    - cron: '0 0 * * 0'
+  #schedule:
+  #  - cron: '0 0 * * 0'
 
   # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:

README.md

@@ -226,6 +226,8 @@ __Usage:__ Using template model to customize your reporting file based on [Text:
 
  	perl mysqltuner.pl --silent --reportfile /tmp/result_mysqltuner.txt --template=/tmp/mymodel.tmpl
 
+__Important__: [Text::Template](https://metacpan.org/pod/Text::Template) module is mandatory for --reportfile and/or --template options because this module is needed to generate appropriated output based on a text template.
+
 __Usage:__ Enable debugging information
 
 	perl mysqltuner.pl --debug

mysqltuner.pl

@@ -1,5 +1,5 @@
 #!/usr/bin/env perl
-# mysqltuner.pl - Version 2.1.2
+# mysqltuner.pl - Version 2.1.3
 # High Performance MySQL Tuning Script
 # Copyright (C) 2006-2023 Major Hayden - major@mhtx.net
 # Copyright (C) 2015-2023 Jean-Marie Renouard - jmrenouard@gmail.com
@@ -57,7 +57,7 @@ use Cwd 'abs_path';
 #use Env;
 
 # Set up a few variables for use in the script
-my $tunerversion = "2.1.2";
+my $tunerversion = "2.1.3";
 my ( @adjvars, @generalrec );
 
 # Set defaults
@@ -3275,13 +3275,13 @@ sub mysql_stats {
             push( @adjvars, "skip-name-resolve=0" );
         }
     }
-    elsif ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF' ) {
+    elsif ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF' and $result{'Variables'}{'skip_name_resolve'} ne '0' ) {
         badprint
 "Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance";
         push( @generalrec,
-"Configure your accounts with ip or subnets only, then update your configuration with skip_name_resolve=1"
+"Configure your accounts with ip or subnets only, then update your configuration with skip-name-resolve=OFF"
         );
-        push( @adjvars, "skip_name_resolve=1" );
+        push( @adjvars, "skip-name-resolve=OFF" );
     }
 
     # Query cache
@@ -3965,11 +3965,11 @@ sub mysqsl_pfs {
 
     # Store all sys schema in dumpdir if defined
     if ( defined $opt{dumpdir} and -d "$opt{dumpdir}" ) {
-        for my $pfs_view ( select_array('use sys;show tables;') ) {
-            infoprint "Dumping $pfs_view into $opt{dumpdir}";
+        for my $sys_view ( select_array('use sys;show tables;') ) {
+            infoprint "Dumping $sys_view into $opt{dumpdir}";
             select_csv_file(
-                "$opt{dumpdir}/pfs_$pfs_view.csv",
-                "select * from sys.$pfs_view"
+                "$opt{dumpdir}/sys_$sys_view.csv",
+                "select * from sys.\`$sys_view\`"
             );
         }
       exit 0 if ( $opt{stop} == 1 );
@@ -6982,7 +6982,7 @@ __END__
 
 =head1 NAME
 
- MySQLTuner 2.1.2 - MySQL High Performance Tuning Script
+ MySQLTuner 2.1.3 - MySQL High Performance Tuning Script
 
 =head1 IMPORTANT USAGE GUIDELINES