innodb_buffer_pool_size recommendation can be to high on 32-bit systems #634

Improvement in --feature options checking arch by default and calling make_recommendations at the end in all case

README.md

@@ -229,6 +229,12 @@ Of course, you can add the execute bit (`chmod +x mysqltuner.pl`) so you can exe
 
 __Usage:__ Minimal usage remotely
 
+In previous version, --forcemem shoud be set manually, in order to be able to run an MT analysis
+
+Since 2.1.10, memory and swap are defined to 1Gb by default.
+
+If you want a more accurate value according to your remote server, feel free to setup --forcemem and --forceswap to real RAM value
+
 ```bash
 perl mysqltuner.pl --host targetDNS_IP --user admin_user --pass admin_password
 ```

mysqltuner.pl

@@ -1,5 +1,5 @@
 #!/usr/bin/env perl
-# mysqltuner.pl - Version 2.1.9
+# mysqltuner.pl - Version 2.1.10
 # High Performance MySQL Tuning Script
 # Copyright (C) 2006-2023 Major Hayden - major@mhtx.net
 # Copyright (C) 2015-2023 Jean-Marie Renouard - jmrenouard@gmail.com
@@ -57,7 +57,7 @@ use Cwd 'abs_path';
 #use Env;
 
 # Set up a few variables for use in the script
-my $tunerversion = "2.1.9";
+my $tunerversion = "2.1.10";
 my ( @adjvars, @generalrec );
 
 # Set defaults
@@ -69,8 +69,8 @@ my %opt = (
     "debug"               => 0,
     "nocolor"             => ( !-t STDOUT ),
     "color"               => 0,
-    "forcemem"            => 0,
+    "forcemem"            => 1024,
-    "forceswap"           => 0,
+    "forceswap"           => 1024,
     "host"                => 0,
     "socket"              => 0,
     "port"                => 0,
@@ -111,7 +111,9 @@ my %opt = (
     "defaults-extra-file" => '',
     "protocol"            => '',
     "dumpdir"             => '',
-    "feature"             => ''
+    "feature"             => '',
+    "dbgpattern"          => '',
+    "defaultarch"         => 64
 );
 
 # Gather the options from the command line
@@ -144,7 +146,8 @@ GetOptions(
     'idxstat',               'noidxstat',
     'server-log=s',          'protocol=s',
     'defaults-extra-file=s', 'dumpdir=s',
-    'feature=s'
+    'feature=s',             'dbgpattern=s',
+    'defaultarch=i'
   )
   or pod2usage(
     -exitval  => 1,
@@ -200,6 +203,7 @@ if ( $opt{dumpdir} ne '' ) {
 $basic_password_files = "/usr/share/mysqltuner/basic_passwords.txt"
   unless -f "$basic_password_files";
 
+$opt{dbgpattern}='.*' if ($opt{dbgpattern} eq '' );
 # check if we need to enable verbose mode
 if ( $opt{feature} ne '' ) { $opt{verbose} = 1; }
 if ( $opt{verbose} ) {
@@ -1261,12 +1265,18 @@ sub arr2hash {
     my $href = shift;
     my $harr = shift;
     my $sep  = shift;
+    my $key='';
+    my $val='';
+
     $sep = '\s' unless defined($sep);
     foreach my $line (@$harr) {
         next if ( $line =~ m/^\*\*\*\*\*\*\*/ );
         $line =~ /([a-zA-Z_]*)\s*$sep\s*(.*)/;
-        $$href{$1} = $2;
+        $key = $1;
-        debugprint "V: $1 = $2";
+        $val = $2;
+        $$href{$key} = $val;
+       
+        debugprint " * $key = $val" if $key =~ /$opt{dbgpattern}/i;
     }
 }
 
@@ -1283,7 +1293,7 @@ sub get_all_vars {
     debugprint "VERSION: " . $dummyselect . "";
     $result{'MySQL Client'}{'Version'} = $dummyselect;
 
-    my @mysqlvarlist = select_array("SHOW VARIABLES");
+    my @mysqlvarlist = select_array("SHOW GLOBAL VARIABLES");
     push( @mysqlvarlist, select_array("SHOW GLOBAL VARIABLES") );
     arr2hash( \%myvar, \@mysqlvarlist );
     $result{'Variables'} = \%myvar;
@@ -2422,6 +2432,8 @@ my ($arch);
 sub check_architecture {
     if ( is_remote eq 1 ) {
         infoprint "Skipping architecture check on remote host";
+        infoprint "Using default $opt{defaultarch} bits as target architecture";
+        $arch = $opt{defaultarch};
         return;
     }
     if ( `uname` =~ /SunOS/ && `isainfo -b` =~ /64/ ) {
@@ -2563,6 +2575,7 @@ sub check_storage_engines {
             $result{'Engine'}{$engine}{'Data Size'}    = $dsize;
             $result{'Engine'}{$engine}{'Index Size'}   = $isize;
         }
+        #print Dumper( \%enginestats ) if $opt{debug};
         my $not_innodb = '';
         if ( not defined $result{'Variables'}{'innodb_file_per_table'} ) {
             $not_innodb = "AND NOT ENGINE='InnoDB'";
@@ -2607,7 +2620,7 @@ sub check_storage_engines {
         $fragtables = 0;
         foreach my $tbl (@tblist) {
 
-            #debugprint "Data dump " . Dumper(@$tbl);
+            #debugprint "Data dump " . Dumper(@$tbl) if $opt{debug};
             my ( $engine, $size, $datafree ) = @$tbl;
             next if $engine eq 'NULL' or not defined($engine);
             $size     = 0 if $size eq 'NULL'     or not defined($size);
@@ -5650,7 +5663,7 @@ sub get_wsrep_options {
     @galera_options = remove_cr @galera_options;
     @galera_options = remove_empty @galera_options;
 
-    #debugprint Dumper( \@galera_options );
+    #debugprint Dumper( \@galera_options ) if $opt{debug};
     return @galera_options;
 }
 
@@ -5984,7 +5997,7 @@ having sum(if(c.column_key in ('PRI', 'UNI'), 1, 0)) = 0"
         }
     }
 
-    #debugprint Dumper get_wsrep_options();
+    #debugprint Dumper get_wsrep_options() if $opt{debug};
 }
 
 # Recommendations for InnoDB
@@ -6091,9 +6104,25 @@ sub mysql_innodb {
     }
 
     # InnoDB Buffer Pool Size
+    if ($arch == 32 && $myvar{'innodb_buffer_pool_size'} > 4294967295) {
+      badprint "InnoDb Buffer Pool size limit reached for 32 bits architecture: (". hr_bytes(4294967295)." )";
+      push( @adjvars, "limit innodb_buffer_pool_size under ".hr_bytes(4294967295)." for 32 bits architecture");
+    }
+    if ($arch == 32 && $myvar{'innodb_buffer_pool_size'} < 4294967295) {
+      goodprint "InnoDb Buffer Pool size ( " . hr_bytes($myvar{'innodb_buffer_pool_size'}). " ) under limit for 32 bits architecture: (". hr_bytes(4294967295 ).")";
+    }
+    if ($arch == 64 && $myvar{'innodb_buffer_pool_size'} > 18446744073709551615 ) {
+      badprint "InnoDb Buffer Pool size limit(". hr_bytes(18446744073709551615 ).") reached for 64 bits architecture";
+      push( @adjvars, "limit innodb_buffer_pool_size under ".hr_bytes(18446744073709551615)." for 64 bits architecture");
+    } 
+
+    if ($arch == 64 && $myvar{'innodb_buffer_pool_size'} < 18446744073709551615 ) {
+      goodprint "InnoDb Buffer Pool size ( " . hr_bytes($myvar{'innodb_buffer_pool_size'}). " ) under limit for 64 bits architecture: (". hr_bytes(18446744073709551615 )." )";
+    } 
     if ( $myvar{'innodb_buffer_pool_size'} > $enginestats{'InnoDB'} ) {
         goodprint "InnoDB buffer pool / data size: "
-          . hr_bytes( $myvar{'innodb_buffer_pool_size'} ) . " / "
+          . hr_bytes( $myvar{'
+          '} ) . " / "
           . hr_bytes( $enginestats{'InnoDB'} ) . "";
     } else {
         badprint "InnoDB buffer pool / data size: "
@@ -7041,7 +7070,8 @@ os_setup;                  # Set up some OS variables
 get_all_vars;              # Toss variables/status into hashes
 get_tuning_info;           # Get information about the tuning connection
 calculations;              # Calculate everything we need
-
+check_architecture;        # Suggest 64-bit upgrade
+check_storage_engines;     # Show enabled storage engines
 if ( $opt{'feature'} ne '' ) {
     subheaderprint "See FEATURES.md for more information";
     no strict 'refs';
@@ -7049,14 +7079,13 @@ if ( $opt{'feature'} ne '' ) {
         subheaderprint "Running feature: $opt{'feature'}";
         $feature->();
     }
+    make_recommendations;
     exit(0);
 }
 validate_mysql_version;    # Check current MySQL version
 
-check_architecture;        # Suggest 64-bit upgrade
 system_recommendations;    # Avoid too many services on the same host
 log_file_recommendations;  # check log file content
-check_storage_engines;     # Show enabled storage engines
 
 check_metadata_perf;    # Show parameter impacting performance during analysis
 mysql_databases;        # Show information about databases
@@ -7101,7 +7130,7 @@ __END__
 
 =head1 NAME
 
- MySQLTuner 2.1.9 - MySQL High Performance Tuning Script
+ MySQLTuner 2.1.10 - MySQL High Performance Tuning Script
 
 =head1 IMPORTANT USAGE GUIDELINES