From 1e7fe0d3947279e819f6dcf261e01e1db0ecf7d3 Mon Sep 17 00:00:00 2001 From: Christian Loos Date: Tue, 16 Jun 2015 13:21:58 +0200 Subject: [PATCH] update innodb_buffer_pool_instances output * make the output more consistent with the other InnoDB outputs * calculate a value for 'Variables to adjust' --- mysqltuner.pl | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 4693410..cc4fd30 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -1140,20 +1140,17 @@ sub mysql_stats { } if (defined($myvar{'innodb_buffer_pool_instances'})) { if ($myvar{'innodb_buffer_pool_instances'} > 64) { - badprint "InnoDB buffer pool instances must be lower than 64.\n"; - push(@adjvars,"innodb_buffer_pool_instances must be lower than 64."); + badprint "InnoDB buffer pool instances: ".$myvar{'innodb_buffer_pool_instances'}."\n"; + push(@adjvars,"innodb_buffer_pool_instances (<= 64)"); } else { - goodprint "InnoDB buffer pool instances is lower than 64.\n"; - } - infoprint "Buffer Pool Inst: $myvar{'innodb_buffer_pool_instances'}\n"; - if ($myvar{'innodb_buffer_pool_size'} > 1024*1024*1024 - and ( - ($myvar{'innodb_buffer_pool_size'}/$myvar{'innodb_buffer_pool_instances'}) < 1024*1024*924 - or ($myvar{'innodb_buffer_pool_size'}/$myvar{'innodb_buffer_pool_instances'}) > 1024*1024*1124 ) ) { - badprint "InnoDB buffer pool is greater than 1Go and each InnoDB buffer pool instance must manage 900Mo to 1.1Go buffer pool size"; - push(@adjvars,"innodb_buffer_pool_instances must be calculated with innodb_buffer_pool_size / 1Go "); - } else { - goodprint "InnoDB buffer pool instances is configurated for managing around 1Go Buffer pool size."; + if ($myvar{'innodb_buffer_pool_size'} > 1024*1024*1024 + and $myvar{'innodb_buffer_pool_instances'} != int($myvar{'innodb_buffer_pool_size'}/(1024*1024*1024)) + ) { + badprint "InnoDB buffer pool instances: ".$myvar{'innodb_buffer_pool_instances'}."\n"; + push(@adjvars,"innodb_buffer_pool_instances(=".int($myvar{'innodb_buffer_pool_size'}/(1024*1024*1024)).")"); + } else { + goodprint "InnoDB buffer pool instances: ".$myvar{'innodb_buffer_pool_instances'}."\n"; + } } } }