hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The same varibale two times? #604

Browse source
This commit is contained in:
Jean-Marie Renouard 2023-06-22 16:55:58 +02:00
parent 7d57863115
commit 22379c8a6f
1 changed files with 117 additions and 102 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

219
mysqltuner.pl
View file

@ -3779,6 +3779,32 @@ sub mysql_stats {
# Recommendations for MyISAM # Recommendations for MyISAM
sub mysql_myisam { sub mysql_myisam {
subheaderprint "MyISAM Metrics"; subheaderprint "MyISAM Metrics";
my $nb_myisam_tables = select_one(
"SELECT COUNT(*) FROM information_schema.TABLES WHERE ENGINE='MyISAM'");
infoprint("General MyIsam metrics:");
infoprint " +-- Total MyISAM Tables : $nb_myisam_tables";
infoprint " +-- Total MyISAM indexes : "
. hr_bytes( $mycalc{'total_myisam_indexes'} ) if defined($mycalc{'total_myisam_indexes'});
infoprint " +-- KB Size :" . hr_bytes($myvar{'key_buffer_size'});
infoprint " +-- KB Used Size :" .hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'} );
infoprint " +-- KB used :" . $mycalc{'pct_key_buffer_used'} . "%";
infoprint " +-- Read KB hit rate: $mycalc{'pct_keys_from_mem'}% ("
. hr_num( $mystat{'Key_read_requests'} )
. " cached / "
. hr_num( $mystat{'Key_reads'} )
. " reads)";
infoprint " +-- Write KB hit rate: $mycalc{'pct_wkeys_from_mem'}% ("
. hr_num( $mystat{'Key_write_requests'} )
. " cached / "
. hr_num( $mystat{'Key_writes'} )
. " writes)";
if ( $nb_myisam_tables == 0 ) {
infoprint "No MyISAM table(s) detected ....";
return;
}
if ( mysql_version_ge(8) and mysql_version_le(10) ) { if ( mysql_version_ge(8) and mysql_version_le(10) ) {
infoprint "MyISAM Metrics are disabled since MySQL 8.0."; infoprint "MyISAM Metrics are disabled since MySQL 8.0.";
if ( $myvar{'key_buffer_size'} > 0 ) { if ( $myvar{'key_buffer_size'} > 0 ) {
@ -3788,130 +3814,119 @@ sub mysql_myisam {
} }
return; return;
} }
my $nb_myisam_tables = select_one(
"SELECT COUNT(*) FROM information_schema.TABLES WHERE ENGINE='MyISAM'"); if ( !defined( $mycalc{'total_myisam_indexes'} ) ) {
if ( $nb_myisam_tables == 0 ) { badprint "Unable to calculate MyISAM index size on MySQL server < 5.0.0";
infoprint "No MyISAM table(s) detected ...."; push( @generalrec,
"Unable to calculate MyISAM index size on MySQL server < 5.0.0" );
return; return;
} }
if ( $mycalc{'pct_key_buffer_used'} == 0 ) {
# Key buffer usage
if ( $mycalc{'pct_key_buffer_used'} > 0 ) {
if ( $mycalc{'pct_key_buffer_used'} < 90 ) {
badprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% ("
. hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'}
)
. " used / "
. hr_bytes( $myvar{'key_buffer_size'} )
. " cache)";
push(
@adjvars,
"key_buffer_size (\~ "
. hr_num(
$myvar{'key_buffer_size'} * $mycalc{'pct_key_buffer_used'}
/ 100
)
. ")"
);
}
else {
goodprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% ("
. hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'}
)
. " used / "
. hr_bytes( $myvar{'key_buffer_size'} )
. " cache)";
}
}
else {
# No queries have run that would use keys # No queries have run that would use keys
debugprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% (" infoprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% ("
. hr_bytes( $myvar{'key_buffer_size'} - . hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'} ) $mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'} )
. " used / " . " used / "
. hr_bytes( $myvar{'key_buffer_size'} ) . hr_bytes( $myvar{'key_buffer_size'} )
. " cache)"; . " cache)";
infoprint "No SQL statement based on MyISAM table(s) detected ....";
return
} }
# Key buffer # Key buffer usage
if ( !defined( $mycalc{'total_myisam_indexes'} ) ) { if ( $mycalc{'pct_key_buffer_used'} < 90 ) {
push( @generalrec, badprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% ("
"Unable to calculate MyISAM index size on MySQL server < 5.0.0" ); . hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'}
)
. " used / "
. hr_bytes( $myvar{'key_buffer_size'} )
. " cache)";
push(
@adjvars,
"key_buffer_size (\~ "
. hr_num(
$myvar{'key_buffer_size'} * $mycalc{'pct_key_buffer_used'}
/ 100
)
. ")"
);
} else {
goodprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% ("
. hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'}
)
. " used / "
. hr_bytes( $myvar{'key_buffer_size'} )
. " cache)";
}
# Key buffer size / total MyISAM indexes
if ( $myvar{'key_buffer_size'} < $mycalc{'total_myisam_indexes'}
&& $mycalc{'pct_keys_from_mem'} < 95 )
{
badprint "Key buffer size / total MyISAM indexes: "
. hr_bytes( $myvar{'key_buffer_size'} ) . "/"
. hr_bytes( $mycalc{'total_myisam_indexes'} ) . "";
push( @adjvars,
"key_buffer_size (> "
. hr_bytes( $mycalc{'total_myisam_indexes'} )
. ")" );
} }
else { else {
if ( $myvar{'key_buffer_size'} < $mycalc{'total_myisam_indexes'} goodprint "Key buffer size / total MyISAM indexes: "
&& $mycalc{'pct_keys_from_mem'} < 95 ) . hr_bytes( $myvar{'key_buffer_size'} ) . "/"
{ . hr_bytes( $mycalc{'total_myisam_indexes'} ) . "";
badprint "Key buffer size / total MyISAM indexes: " }
. hr_bytes( $myvar{'key_buffer_size'} ) . "/" if ( $mystat{'Key_read_requests'} > 0 ) {
. hr_bytes( $mycalc{'total_myisam_indexes'} ) . ""; if ( $mycalc{'pct_keys_from_mem'} < 95 ) {
push( @adjvars, badprint
"key_buffer_size (> " "Read Key buffer hit rate: $mycalc{'pct_keys_from_mem'}% ("
. hr_bytes( $mycalc{'total_myisam_indexes'} ) . hr_num( $mystat{'Key_read_requests'} )
. ")" ); . " cached / "
. hr_num( $mystat{'Key_reads'} )
. " reads)";
} }
else { else {
goodprint "Key buffer size / total MyISAM indexes: " goodprint
. hr_bytes( $myvar{'key_buffer_size'} ) . "/" "Read Key buffer hit rate: $mycalc{'pct_keys_from_mem'}% ("
. hr_bytes( $mycalc{'total_myisam_indexes'} ) . ""; . hr_num( $mystat{'Key_read_requests'} )
. " cached / "
. hr_num( $mystat{'Key_reads'} )
. " reads)";
} }
if ( $mystat{'Key_read_requests'} > 0 ) { }
if ( $mycalc{'pct_keys_from_mem'} < 95 ) {
badprint
"Read Key buffer hit rate: $mycalc{'pct_keys_from_mem'}% ("
. hr_num( $mystat{'Key_read_requests'} )
. " cached / "
. hr_num( $mystat{'Key_reads'} )
. " reads)";
}
else {
goodprint
"Read Key buffer hit rate: $mycalc{'pct_keys_from_mem'}% ("
. hr_num( $mystat{'Key_read_requests'} )
. " cached / "
. hr_num( $mystat{'Key_reads'} )
. " reads)";
}
}
else {
# No queries have run that would use keys # No queries have run that would use keys
debugprint "Key buffer size / total MyISAM indexes: " debugprint "Key buffer size / total MyISAM indexes: "
. hr_bytes( $myvar{'key_buffer_size'} ) . "/" . hr_bytes( $myvar{'key_buffer_size'} ) . "/"
. hr_bytes( $mycalc{'total_myisam_indexes'} ) . ""; . hr_bytes( $mycalc{'total_myisam_indexes'} ) . "";
} if ( $mystat{'Key_write_requests'} > 0 ) {
if ( $mystat{'Key_write_requests'} > 0 ) { if ( $mycalc{'pct_wkeys_from_mem'} < 95 ) {
if ( $mycalc{'pct_wkeys_from_mem'} < 95 ) { badprint
badprint
"Write Key buffer hit rate: $mycalc{'pct_wkeys_from_mem'}% ("
. hr_num( $mystat{'Key_write_requests'} )
. " cached / "
. hr_num( $mystat{'Key_writes'} )
. " writes)";
}
else {
goodprint
"Write Key buffer hit rate: $mycalc{'pct_wkeys_from_mem'}% ("
. hr_num( $mystat{'Key_write_requests'} )
. " cached / "
. hr_num( $mystat{'Key_writes'} )
. " writes)";
}
}
else {
# No queries have run that would use keys
debugprint
"Write Key buffer hit rate: $mycalc{'pct_wkeys_from_mem'}% (" "Write Key buffer hit rate: $mycalc{'pct_wkeys_from_mem'}% ("
. hr_num( $mystat{'Key_write_requests'} ) . hr_num( $mystat{'Key_write_requests'} )
. " cached / " . " cached / "
. hr_num( $mystat{'Key_writes'} ) . hr_num( $mystat{'Key_writes'} )
. " writes)"; . " writes)";
} }
else {
goodprint
"Write Key buffer hit rate: $mycalc{'pct_wkeys_from_mem'}% ("
. hr_num( $mystat{'Key_write_requests'} )
. " cached / "
. hr_num( $mystat{'Key_writes'} )
. " writes)";
}
} else {
# No queries have run that would use keys
debugprint
"Write Key buffer hit rate: $mycalc{'pct_wkeys_from_mem'}% ("
. hr_num( $mystat{'Key_write_requests'} )
. " cached / "
. hr_num( $mystat{'Key_writes'} )
. " writes)";
} }
} }