hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

query cache hit rate was not calculated when badprint "Query cache may be disabled by default due to mutex contention"

Browse source
This commit is contained in:
jfcoz 2016-12-08 09:45:38 +01:00
parent 7082cbc678
commit 2dfb2a2cc9
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
mysqltuner.pl
View file

@ -2744,16 +2744,9 @@ sub mysql_stats {
push( @generalrec, push( @generalrec,
"Upgrade MySQL to version 4+ to utilize query caching" ); "Upgrade MySQL to version 4+ to utilize query caching" );
} }
elsif ( mysql_version_ge( 5, 5 ) and !mysql_version_ge( 10, 1 ) ) { elsif ( mysql_version_ge( 5, 5 ) and !mysql_version_ge( 10, 1 ) and $myvar{'query_cache_type'} eq "OFF" ) {
if ( $myvar{'query_cache_type'} ne "OFF" ) { goodprint
badprint "Query cache is disabled by default due to mutex contention on multiprocessor machines.";
"Query cache may be disabled by default due to mutex contention.";
push( @adjvars, "query_cache_type (=0)" );
}
else {
goodprint
"Query cache is disabled by default due to mutex contention on multiprocessor machines.";
}
} }
elsif ( $myvar{'query_cache_size'} < 1 ) { elsif ( $myvar{'query_cache_size'} < 1 ) {
badprint "Query cache is disabled"; badprint "Query cache is disabled";
@ -2768,6 +2761,9 @@ sub mysql_stats {
"Query cache cannot be analyzed - no SELECT statements executed"; "Query cache cannot be analyzed - no SELECT statements executed";
} }
else { else {
badprint
"Query cache may be disabled by default due to mutex contention.";
push( @adjvars, "query_cache_type (=0)" );
if ( $mycalc{'query_cache_efficiency'} < 20 ) { if ( $mycalc{'query_cache_efficiency'} < 20 ) {
badprint badprint
"Query cache efficiency: $mycalc{'query_cache_efficiency'}% (" "Query cache efficiency: $mycalc{'query_cache_efficiency'}% ("