From 34dcfd05c94c71271c0f91ea177a78b3a9e353fb Mon Sep 17 00:00:00 2001 From: Jean-Marie Renouard Date: Wed, 7 Feb 2024 00:07:41 +0100 Subject: [PATCH] Adding secure check when missing value --- mysqltuner.pl | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 2006e20..8019092 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -6372,13 +6372,15 @@ sub mysql_innodb { # ,2) as "PCT ALLOC/BUFFER POOL" #from sys.x$innodb_buffer_stats_by_table; - if ( $mycalc{innodb_buffer_alloc_pct} < 80 ) { - badprint "Ratio Buffer Pool allocated / Buffer Pool Size: " - . $mycalc{'innodb_buffer_alloc_pct'} . '%'; - } - else { - goodprint "Ratio Buffer Pool allocated / Buffer Pool Size: " - . $mycalc{'innodb_buffer_alloc_pct'} . '%'; + if (defined $mycalc{innodb_buffer_alloc_pct}) { + if ( $mycalc{innodb_buffer_alloc_pct} < 80 ) { + badprint "Ratio Buffer Pool allocated / Buffer Pool Size: " + . $mycalc{'innodb_buffer_alloc_pct'} . '%'; + } + else { + goodprint "Ratio Buffer Pool allocated / Buffer Pool Size: " + . $mycalc{'innodb_buffer_alloc_pct'} . '%'; + } } if ( $mycalc{'innodb_log_size_pct'} < 20 or $mycalc{'innodb_log_size_pct'} > 30 )