hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: last updates for skip_name_resolve roolback including 0 value testing

Browse source
This commit is contained in:
Jean-Marie Renouard 2023-06-05 22:40:49 +02:00
parent f27541682d
commit 38041d3ecd
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
mysqltuner.pl
View file

@ -1,5 +1,5 @@
#!/usr/bin/env perl #!/usr/bin/env perl
# mysqltuner.pl - Version 2.1.2 # mysqltuner.pl - Version 2.1.3
# High Performance MySQL Tuning Script # High Performance MySQL Tuning Script
# Copyright (C) 2006-2023 Major Hayden - major@mhtx.net # Copyright (C) 2006-2023 Major Hayden - major@mhtx.net
# Copyright (C) 2015-2023 Jean-Marie Renouard - jmrenouard@gmail.com # Copyright (C) 2015-2023 Jean-Marie Renouard - jmrenouard@gmail.com
@ -57,7 +57,7 @@ use Cwd 'abs_path';
#use Env; #use Env;
# Set up a few variables for use in the script # Set up a few variables for use in the script
my $tunerversion = "2.1.2"; my $tunerversion = "2.1.3";
my ( @adjvars, @generalrec ); my ( @adjvars, @generalrec );
# Set defaults # Set defaults
@ -3275,13 +3275,13 @@ sub mysql_stats {
push( @adjvars, "skip-name-resolve=0" ); push( @adjvars, "skip-name-resolve=0" );
} }
} }
elsif ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF' ) { elsif ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF' and $result{'Variables'}{'skip_name_resolve'} ne '0' ) {
badprint badprint
"Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance"; "Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance";
push( @generalrec, push( @generalrec,
"Configure your accounts with ip or subnets only, then update your configuration with skip_name_resolve=1" "Configure your accounts with ip or subnets only, then update your configuration with skip-name-resolve=OFF"
); );
push( @adjvars, "skip_name_resolve=1" ); push( @adjvars, "skip-name-resolve=OFF" );
} }
# Query cache # Query cache
@ -3965,11 +3965,11 @@ sub mysqsl_pfs {
# Store all sys schema in dumpdir if defined # Store all sys schema in dumpdir if defined
if ( defined $opt{dumpdir} and -d "$opt{dumpdir}" ) { if ( defined $opt{dumpdir} and -d "$opt{dumpdir}" ) {
for my $pfs_view ( select_array('use sys;show tables;') ) { for my $sys_view ( select_array('use sys;show tables;') ) {
infoprint "Dumping $pfs_view into $opt{dumpdir}"; infoprint "Dumping $sys_view into $opt{dumpdir}";
select_csv_file( select_csv_file(
"$opt{dumpdir}/pfs_$pfs_view.csv", "$opt{dumpdir}/sys_$sys_view.csv",
"select * from sys.$pfs_view" "select * from sys.\`$sys_view\`"
); );
} }
exit 0 if ( $opt{stop} == 1 ); exit 0 if ( $opt{stop} == 1 );
@ -6982,7 +6982,7 @@ __END__
=head1 NAME =head1 NAME
MySQLTuner 2.1.2 - MySQL High Performance Tuning Script MySQLTuner 2.1.3 - MySQL High Performance Tuning Script
=head1 IMPORTANT USAGE GUIDELINES =head1 IMPORTANT USAGE GUIDELINES