hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update Vulnerabilities list

Browse source 
Indenting mysqltuner
Update Usage information
This commit is contained in:
Jean-Marie Renouard 2022-12-29 05:13:02 +01:00
parent 57b4f69680
commit 390977624e
2 changed files with 102 additions and 290 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

75
mysqltuner.pl
View file

@ -917,17 +917,21 @@ sub mysql_setup {
return 1; return 1;
} }
} }
elsif ( $opt{'defaults-extra-file'} ne '' and -r "$opt{'defaults-extra-file'}" ) { elsif ( $opt{'defaults-extra-file'} ne ''
and -r "$opt{'defaults-extra-file'}" )
{
# defaults-extra-file # defaults-extra-file
debugprint "defaults extra file detected: $opt{'defaults-extra-file'}"; debugprint "defaults extra file detected: $opt{'defaults-extra-file'}";
my $mysqlclidefaults = `$mysqlcmd --print-defaults`; my $mysqlclidefaults = `$mysqlcmd --print-defaults`;
debugprint "MySQL Client Extra Default File: $opt{'defaults-extra-file'}"; debugprint
"MySQL Client Extra Default File: $opt{'defaults-extra-file'}";
$mysqllogin = "--defaults-extra-file=" . $opt{'defaults-extra-file'}; $mysqllogin = "--defaults-extra-file=" . $opt{'defaults-extra-file'};
my $loginstatus = `$mysqladmincmd $mysqllogin ping 2>&1`; my $loginstatus = `$mysqladmincmd $mysqllogin ping 2>&1`;
if ( $loginstatus =~ /mysqld is alive/ ) { if ( $loginstatus =~ /mysqld is alive/ ) {
goodprint "Logged in using credentials from extra defaults file account."; goodprint
"Logged in using credentials from extra defaults file account.";
return 1; return 1;
} }
} }
@ -1190,7 +1194,7 @@ sub get_all_vars {
$dummyselect = select_one "SELECT VERSION()"; $dummyselect = select_one "SELECT VERSION()";
if ( not defined($dummyselect) or $dummyselect eq "" ) { if ( not defined($dummyselect) or $dummyselect eq "" ) {
badprint badprint
"You probably do not have enough privileges to run MySQLTuner ..."; "You probably do not have enough privileges to run MySQLTuner ...";
exit(256); exit(256);
} }
$dummyselect =~ s/(.*?)\-.*/$1/; $dummyselect =~ s/(.*?)\-.*/$1/;
@ -2254,7 +2258,8 @@ sub validate_mysql_version {
. $myvar{'version'} . $myvar{'version'}
. " is EOL software. Upgrade soon!"; . " is EOL software. Upgrade soon!";
push( @generalrec, push( @generalrec,
"You are using an unsupported version for production environments" ); "You are using an unsupported version for production environments"
);
push( @generalrec, push( @generalrec,
"Upgrade as soon as possible to a supported version !" ); "Upgrade as soon as possible to a supported version !" );
@ -2554,7 +2559,7 @@ sub check_storage_engines {
{ {
badprint "MyISAM is enabled but isn't being used"; badprint "MyISAM is enabled but isn't being used";
push( @generalrec, push( @generalrec,
"Add skip-isam to MySQL configuration to disable MyISAM (MySQL > 4.1.0)" "Add skip-isam to MySQL configuration to disable MyISAM (MySQL > 4.1.0)"
); );
} }
@ -2562,7 +2567,7 @@ sub check_storage_engines {
if ( $fragtables > 0 ) { if ( $fragtables > 0 ) {
badprint "Total fragmented tables: $fragtables"; badprint "Total fragmented tables: $fragtables";
push @generalrec, push @generalrec,
'Run ALTER TABLE ... FORCE or OPTIMIZE TABLE to defragment tables for better performance'; 'Run ALTER TABLE ... FORCE or OPTIMIZE TABLE to defragment tables for better performance';
my $total_free = 0; my $total_free = 0;
foreach my $table_line ( @{ $result{'Tables'}{'Fragmented tables'} } ) { foreach my $table_line ( @{ $result{'Tables'}{'Fragmented tables'} } ) {
my ( $table_schema, $table_name, $engine, $data_free ) = my ( $table_schema, $table_name, $engine, $data_free ) =
@ -2571,8 +2576,10 @@ sub check_storage_engines {
$total_free += $data_free; $total_free += $data_free;
my $generalrec; my $generalrec;
if ( $engine eq 'InnoDB' ) { if ( $engine eq 'InnoDB' ) {
$generalrec = " ALTER TABLE `$table_schema`.`$table_name` FORCE;"; $generalrec =
} else { " ALTER TABLE `$table_schema`.`$table_name` FORCE;";
}
else {
$generalrec = " OPTIMIZE TABLE `$table_schema`.`$table_name`;"; $generalrec = " OPTIMIZE TABLE `$table_schema`.`$table_name`;";
} }
$generalrec .= " -- can free $data_free MiB"; $generalrec .= " -- can free $data_free MiB";
@ -2636,8 +2643,7 @@ my %mycalc;
sub calculations { sub calculations {
if ( $mystat{'Questions'} < 1 ) { if ( $mystat{'Questions'} < 1 ) {
badprint badprint "Your server has not answered any queries: cannot continue...";
"Your server has not answered any queries: cannot continue...";
exit 2; exit 2;
} }
@ -3066,7 +3072,8 @@ sub mysql_stats {
. " global + " . " global + "
. hr_bytes( $mycalc{'per_thread_buffers'} ) . hr_bytes( $mycalc{'per_thread_buffers'} )
. " per thread ($myvar{'max_connections'} max threads)"; . " per thread ($myvar{'max_connections'} max threads)";
infoprint "Performance_schema Max memory usage: " . hr_bytes_rnd( get_pf_memory() ); infoprint "Performance_schema Max memory usage: "
. hr_bytes_rnd( get_pf_memory() );
$result{'Performance_schema'}{'memory'} = get_pf_memory(); $result{'Performance_schema'}{'memory'} = get_pf_memory();
$result{'Performance_schema'}{'pretty_memory'} = $result{'Performance_schema'}{'pretty_memory'} =
hr_bytes_rnd( get_pf_memory() ); hr_bytes_rnd( get_pf_memory() );
@ -3680,8 +3687,8 @@ sub mysql_myisam {
if ( $mycalc{'pct_key_buffer_used'} < 90 ) { if ( $mycalc{'pct_key_buffer_used'} < 90 ) {
badprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% (" badprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% ("
. hr_bytes( $myvar{'key_buffer_size'} - . hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'}
$myvar{'key_cache_block_size'} ) )
. " used / " . " used / "
. hr_bytes( $myvar{'key_buffer_size'} ) . hr_bytes( $myvar{'key_buffer_size'} )
. " cache)"; . " cache)";
@ -3699,8 +3706,8 @@ sub mysql_myisam {
else { else {
goodprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% (" goodprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% ("
. hr_bytes( $myvar{'key_buffer_size'} - . hr_bytes( $myvar{'key_buffer_size'} -
$mystat{'Key_blocks_unused'} * $mystat{'Key_blocks_unused'} * $myvar{'key_cache_block_size'}
$myvar{'key_cache_block_size'} ) )
. " used / " . " used / "
. hr_bytes( $myvar{'key_buffer_size'} ) . hr_bytes( $myvar{'key_buffer_size'} )
. " cache)"; . " cache)";
@ -3908,16 +3915,17 @@ sub mysqsl_pfs {
if ( $myvar{'performance_schema'} eq 'ON' ) { if ( $myvar{'performance_schema'} eq 'ON' ) {
infoprint "Performance_schema is activated."; infoprint "Performance_schema is activated.";
debugprint "Performance schema is " . $myvar{'performance_schema'}; debugprint "Performance schema is " . $myvar{'performance_schema'};
infoprint "Memory used by Performance_schema: " . hr_bytes( get_pf_memory() ); infoprint "Memory used by Performance_schema: "
. hr_bytes( get_pf_memory() );
} }
unless ( grep /^sys$/, select_array("SHOW DATABASES") ) { unless ( grep /^sys$/, select_array("SHOW DATABASES") ) {
infoprint "Sys schema is not installed."; infoprint "Sys schema is not installed.";
push( @generalrec, push( @generalrec,
"Consider installing Sys schema from https://github.com/mysql/mysql-sys for MySQL" "Consider installing Sys schema from https://github.com/mysql/mysql-sys for MySQL"
) unless ( mysql_version_le( 5, 6 ) ); ) unless ( mysql_version_le( 5, 6 ) );
push( @generalrec, push( @generalrec,
"Consider installing Sys schema from https://github.com/FromDual/mariadb-sys for MariaDB" "Consider installing Sys schema from https://github.com/FromDual/mariadb-sys for MariaDB"
) unless ( mysql_version_ge( 10, 0 ) ); ) unless ( mysql_version_ge( 10, 0 ) );
return; return;
@ -5620,19 +5628,19 @@ having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0"
or get_wsrep_option('wsrep_slave_threads') < ( (cpu_cores) * 2 ) ) or get_wsrep_option('wsrep_slave_threads') < ( (cpu_cores) * 2 ) )
{ {
badprint badprint
"wsrep_slave_threads is not equal to 2, 3 or 4 times the number of CPU(s)"; "wsrep_slave_threads is not equal to 2, 3 or 4 times the number of CPU(s)";
push @adjvars, "wsrep_slave_threads = " . ( (cpu_cores) * 4 ); push @adjvars, "wsrep_slave_threads = " . ( (cpu_cores) * 4 );
} }
else { else {
goodprint goodprint
"wsrep_slave_threads is equal to 2, 3 or 4 times the number of CPU(s)"; "wsrep_slave_threads is equal to 2, 3 or 4 times the number of CPU(s)";
} }
if ( get_wsrep_option('wsrep_slave_threads') > 1 ) { if ( get_wsrep_option('wsrep_slave_threads') > 1 ) {
infoprint infoprint
"wsrep parallel slave can cause frequent inconsistency crash."; "wsrep parallel slave can cause frequent inconsistency crash.";
push @adjvars, push @adjvars,
"Set wsrep_slave_threads to 1 in case of HA_ERR_FOUND_DUPP_KEY crash on slave"; "Set wsrep_slave_threads to 1 in case of HA_ERR_FOUND_DUPP_KEY crash on slave";
# check options for parallel slave # check options for parallel slave
if ( get_wsrep_option('wsrep_slave_FK_checks') eq "OFF" ) { if ( get_wsrep_option('wsrep_slave_FK_checks') eq "OFF" ) {
@ -5675,7 +5683,7 @@ having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0"
} }
else { else {
goodprint goodprint
"Flow control fraction seems to be OK (wsrep_flow_control_paused <= 0.02)"; "Flow control fraction seems to be OK (wsrep_flow_control_paused <= 0.02)";
} }
if ( scalar(@primaryKeysNbTables) > 0 ) { if ( scalar(@primaryKeysNbTables) > 0 ) {
@ -5737,14 +5745,14 @@ having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0"
} }
else { else {
badprint badprint
"There are $nbNodesSize nodes in wsrep_cluster_size. Prefer 3 or 5 nodes architecture."; "There are $nbNodesSize nodes in wsrep_cluster_size. Prefer 3 or 5 nodes architecture.";
push @generalrec, "Prefer 3 or 5 nodes architecture."; push @generalrec, "Prefer 3 or 5 nodes architecture.";
} }
# wsrep_cluster_address doesn't include garbd nodes # wsrep_cluster_address doesn't include garbd nodes
if ( $nbNodes > $nbNodesSize ) { if ( $nbNodes > $nbNodesSize ) {
badprint badprint
"All cluster nodes are not detected. wsrep_cluster_size less than node count in wsrep_cluster_address"; "All cluster nodes are not detected. wsrep_cluster_size less than node count in wsrep_cluster_address";
} }
else { else {
goodprint "All cluster nodes detected."; goodprint "All cluster nodes detected.";
@ -5782,14 +5790,15 @@ having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0"
} }
else { else {
badprint "Galera Notify command is not defined."; badprint "Galera Notify command is not defined.";
push( @adjvars, "set up parameter wsrep_notify_cmd to be notified" ); push( @adjvars,
"set up parameter wsrep_notify_cmd to be notified" );
} }
if ( trim( $myvar{'wsrep_sst_method'} ) !~ "^xtrabackup.*" if ( trim( $myvar{'wsrep_sst_method'} ) !~ "^xtrabackup.*"
and trim( $myvar{'wsrep_sst_method'} ) !~ "^mariabackup" ) and trim( $myvar{'wsrep_sst_method'} ) !~ "^mariabackup" )
{ {
badprint "Galera SST method is not xtrabackup based."; badprint "Galera SST method is not xtrabackup based.";
push( @adjvars, push( @adjvars,
"set up parameter wsrep_sst_method to xtrabackup based parameter" "set up parameter wsrep_sst_method to xtrabackup based parameter"
); );
} }
else { else {
@ -5891,10 +5900,10 @@ sub mysql_innodb {
$defengine = $myvar{'default_storage_engine'} $defengine = $myvar{'default_storage_engine'}
if defined( $myvar{'default_storage_engine'} ); if defined( $myvar{'default_storage_engine'} );
badprint badprint
"InnoDB Storage engine is disabled. $defengine is the default storage engine" "InnoDB Storage engine is disabled. $defengine is the default storage engine"
if $defengine eq 'InnoDB'; if $defengine eq 'InnoDB';
infoprint infoprint
"InnoDB Storage engine is disabled. $defengine is the default storage engine" "InnoDB Storage engine is disabled. $defengine is the default storage engine"
if $defengine ne 'InnoDB'; if $defengine ne 'InnoDB';
} }
return; return;
@ -6557,7 +6566,7 @@ sub mysql_indexes {
subheaderprint "Indexes Metrics"; subheaderprint "Indexes Metrics";
unless ( mysql_version_ge( 5, 5 ) ) { unless ( mysql_version_ge( 5, 5 ) ) {
infoprint infoprint
"Skip Index metrics from information schema are missing in this version"; "Skip Index metrics from information schema are missing in this version";
return; return;
} }
@ -6684,7 +6693,7 @@ sub mysql_views() {
subheaderprint "Views Metrics"; subheaderprint "Views Metrics";
unless ( mysql_version_ge( 5, 5 ) ) { unless ( mysql_version_ge( 5, 5 ) ) {
infoprint infoprint
"Skip Index metrics from information schema are missing in this version"; "Skip Index metrics from information schema are missing in this version";
return; return;
} }
} }
@ -6693,7 +6702,7 @@ sub mysql_routines() {
subheaderprint "Routines Metrics"; subheaderprint "Routines Metrics";
unless ( mysql_version_ge( 5, 5 ) ) { unless ( mysql_version_ge( 5, 5 ) ) {
infoprint infoprint
"Skip Index metrics from information schema are missing in this version"; "Skip Index metrics from information schema are missing in this version";
return; return;
} }
} }
@ -6702,7 +6711,7 @@ sub mysql_triggers() {
subheaderprint "Triggers Metrics"; subheaderprint "Triggers Metrics";
unless ( mysql_version_ge( 5, 5 ) ) { unless ( mysql_version_ge( 5, 5 ) ) {
infoprint infoprint
"Skip Index metrics from information schema are missing in this version"; "Skip Index metrics from information schema are missing in this version";
return; return;
} }
} }

203
vulnerabilities.csv
View file

File diff suppressed because one or more lines are too long