hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Read log file by line

Browse source 
Changes the log file reading from loading the entire file into
memory to reading line by line.
This commit is contained in:
Thomas Meyer 2017-10-05 17:05:20 -07:00
parent e316b9ac21
commit 45c48832c4
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
mysqltuner.pl
View file

@ -1202,14 +1202,16 @@ sub log_file_recommandations {
. " is > 32Mb, you should analyze why or implement a rotation log strategy such as logrotate!"; . " is > 32Mb, you should analyze why or implement a rotation log strategy such as logrotate!";
} }
my @log_content = get_file_contents( $myvar{'log_error'} );
my $numLi = 0; my $numLi = 0;
my $nbWarnLog = 0; my $nbWarnLog = 0;
my $nbErrLog = 0; my $nbErrLog = 0;
my @lastShutdowns; my @lastShutdowns;
my @lastStarts; my @lastStarts;
foreach my $logLi (@log_content) {
open( my $fh, '<', $myvar{'log_error'} ) or die "Can't open $myvar{'log_error'} for read: $!";
while ( my $logLi = <$fh> ) {
chomp $logLi;
$numLi++; $numLi++;
debugprint "$numLi: $logLi" if $logLi =~ /warning|error/i; debugprint "$numLi: $logLi" if $logLi =~ /warning|error/i;
$nbErrLog++ if $logLi =~ /error/i; $nbErrLog++ if $logLi =~ /error/i;
@ -1218,6 +1220,8 @@ sub log_file_recommandations {
if $logLi =~ /Shutdown complete/ and $logLi !~ /Innodb/i; if $logLi =~ /Shutdown complete/ and $logLi !~ /Innodb/i;
push @lastStarts, $logLi if $logLi =~ /ready for connections/; push @lastStarts, $logLi if $logLi =~ /ready for connections/;
} }
close $fh;
if ( $nbWarnLog > 0 ) { if ( $nbWarnLog > 0 ) {
badprint "$myvar{'log_error'} contains $nbWarnLog warning(s)."; badprint "$myvar{'log_error'} contains $nbWarnLog warning(s).";
push @generalrec, push @generalrec,