hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #335 from pes-soft/innodb-logsize-suggestion

Browse source 
Fixes for ratio between InnoDB log files and buffer pool size described in #322
This commit is contained in:
Jean-Marie Renouard 2017-07-24 15:05:25 +02:00 committed by GitHub
commit 59b55a92ec
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
mysqltuner.pl
View file

@ -5349,9 +5349,7 @@ sub mysql_innodb {
} }
if ( defined $myvar{'innodb_log_file_size'} ) { if ( defined $myvar{'innodb_log_file_size'} ) {
infoprint " +-- InnoDB Log File Size: " infoprint " +-- InnoDB Log File Size: "
. hr_bytes( $myvar{'innodb_log_file_size'} ) . "(" . hr_bytes( $myvar{'innodb_log_file_size'} );
. $mycalc{'innodb_log_size_pct'}
. " % of buffer pool)";
} }
if ( defined $myvar{'innodb_log_files_in_group'} ) { if ( defined $myvar{'innodb_log_files_in_group'} ) {
infoprint " +-- InnoDB Log File In Group: " infoprint " +-- InnoDB Log File In Group: "
@ -5360,7 +5358,9 @@ sub mysql_innodb {
if ( defined $myvar{'innodb_log_files_in_group'} ) { if ( defined $myvar{'innodb_log_files_in_group'} ) {
infoprint " +-- InnoDB Total Log File Size: " infoprint " +-- InnoDB Total Log File Size: "
. hr_bytes( $myvar{'innodb_log_files_in_group'} * . hr_bytes( $myvar{'innodb_log_files_in_group'} *
$myvar{'innodb_log_file_size'} ); $myvar{'innodb_log_file_size'} ) . "("
. $mycalc{'innodb_log_size_pct'}
. " % of buffer pool)";
} }
if ( defined $myvar{'innodb_log_buffer_size'} ) { if ( defined $myvar{'innodb_log_buffer_size'} ) {
infoprint " +-- InnoDB Log Buffer: " infoprint " +-- InnoDB Log Buffer: "
@ -5413,18 +5413,17 @@ sub mysql_innodb {
. $myvar{'innodb_log_files_in_group'} . "/" . $myvar{'innodb_log_files_in_group'} . "/"
. hr_bytes( $myvar{'innodb_buffer_pool_size'} ) . hr_bytes( $myvar{'innodb_buffer_pool_size'} )
. " should be equal 25%"; . " should be equal 25%";
push( push( @adjvars,
@adjvars, "innodb_log_file_size should be (="
"innodb_log_file_size * innodb_log_files_in_group should be equal to 1/4 of buffer pool size (="
. hr_bytes_rnd( . hr_bytes_rnd(
$myvar{'innodb_buffer_pool_size'} * $myvar{'innodb_buffer_pool_size'} /
$myvar{'innodb_log_files_in_group'} / 4 $myvar{'innodb_log_files_in_group'} / 4
) )
. ") if possible." . ") if possible, so InnoDB total log files size equals to 25% of buffer pool size."
); );
} }
else { else {
goodprint "InnoDB log file size / InnoDB Buffer pool size: " goodprint "Ratio InnoDB log file size / InnoDB Buffer pool size: "
. hr_bytes( $myvar{'innodb_log_file_size'} ) . " * " . hr_bytes( $myvar{'innodb_log_file_size'} ) . " * "
. $myvar{'innodb_log_files_in_group'} . "/" . $myvar{'innodb_log_files_in_group'} . "/"
. hr_bytes( $myvar{'innodb_buffer_pool_size'} ) . hr_bytes( $myvar{'innodb_buffer_pool_size'} )