From 5be96339a187e0c9ce2fb7114316fe07e370716f Mon Sep 17 00:00:00 2001
From: root <jmrenouard@gmail.com>
Date: Mon, 28 Nov 2016 17:48:22 +0100
Subject: [PATCH] Incorrect innodb log file size calculation #271

---
 mysqltuner.pl | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/mysqltuner.pl b/mysqltuner.pl
index 5642c6f..5505e4e 100755
--- a/mysqltuner.pl
+++ b/mysqltuner.pl
@@ -2382,7 +2382,7 @@ sub calculations {
     # InnoDB
     if ( $myvar{'have_innodb'} eq "YES" ) {
         $mycalc{'innodb_log_size_pct'} =
-          ( $myvar{'innodb_log_file_size'} * 100 /
+          ( $myvar{'innodb_log_file_size'} *$myvar{'innodb_log_files_in_group'} * 100 /
               $myvar{'innodb_buffer_pool_size'} );
     }
 
@@ -5122,6 +5122,14 @@ sub mysql_innodb {
               . $mycalc{'innodb_log_size_pct'}
               . " % of buffer pool)";
         }
+        if ( defined $myvar{'innodb_log_files_in_group'} ) {
+            infoprint " +-- InnoDB Log File In Group: "
+              . $myvar{'innodb_log_files_in_group'};
+        }
+        if ( defined $myvar{'innodb_log_files_in_group'} ) {
+            infoprint " +-- InnoDB Total Log File Size: "
+              . hr_bytes( $myvar{'innodb_log_files_in_group'}*$myvar{'innodb_log_file_size'});
+        }
         if ( defined $myvar{'innodb_log_buffer_size'} ) {
             infoprint " +-- InnoDB Log Buffer: "
               . hr_bytes( $myvar{'innodb_log_buffer_size'} );
@@ -5169,7 +5177,7 @@ sub mysql_innodb {
     {
         badprint "Ratio InnoDB log file size / InnoDB Buffer pool size ("
           . $mycalc{'innodb_log_size_pct'} . " %): "
-          . hr_bytes( $myvar{'innodb_log_file_size'} ) . "/"
+          . hr_bytes( $myvar{'innodb_log_file_size'} )." * ".$myvar{'innodb_log_files_in_group'}. "/"
           . hr_bytes( $myvar{'innodb_buffer_pool_size'} )
           . " should be equal 25%";
         push( @adjvars,
@@ -5179,7 +5187,7 @@ sub mysql_innodb {
     }
     else {
         goodprint "InnoDB log file size / InnoDB Buffer pool size: "
-          . hr_bytes( $myvar{'innodb_log_file_size'} ) . "/"
+          . hr_bytes( $myvar{'innodb_log_file_size'} ) ." * ".$myvar{'innodb_log_files_in_group'}. "/"
           . hr_bytes( $myvar{'innodb_buffer_pool_size'} )
           . " should be equal 25%";
     }