hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use of uninitialized value $engine in concatenation (.) or string #350

Browse source
This commit is contained in:
Jean-Marie Renouard 2019-10-03 21:52:30 +02:00
parent 143b80b3a6
commit 6aa887d5a5
1 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
mysqltuner.pl
View file

@ -1,5 +1,5 @@
#!/usr/bin/env perl #!/usr/bin/env perl
# mysqltuner.pl - Version 1.7.18 # mysqltuner.pl - Version 1.7.19
# High Performance MySQL Tuning Script # High Performance MySQL Tuning Script
# Copyright (C) 2006-2018 Major Hayden - major@mhtx.net # Copyright (C) 2006-2018 Major Hayden - major@mhtx.net
# #
@ -56,7 +56,7 @@ $Data::Dumper::Pair = " : ";
#use Env; #use Env;
# Set up a few variables for use in the script # Set up a few variables for use in the script
my $tunerversion = "1.7.18"; my $tunerversion = "1.7.19";
my ( @adjvars, @generalrec ); my ( @adjvars, @generalrec );
# Set defaults # Set defaults
@ -2198,11 +2198,12 @@ sub check_storage_engines {
( $engine, $size, $count, $dsize, $isize ) = ( $engine, $size, $count, $dsize, $isize ) =
$line =~ /([a-zA-Z_]+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)/; $line =~ /([a-zA-Z_]+)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d+)/;
debugprint "Engine Found: $engine"; debugprint "Engine Found: $engine";
next unless ( defined($engine) ); trim $engine;
$size = 0 unless defined($size); next unless ( defined($engine) or trim($engine) eq '' );
$isize = 0 unless defined($isize); $size = 0 unless ( defined($size) or trim($engine) eq '' );
$dsize = 0 unless defined($dsize); $isize = 0 unless ( defined($isize) or trim($engine) eq '' );
$count = 0 unless defined($count); $dsize = 0 unless ( defined($dsize) or trim($engine) eq '' );
$count = 0 unless ( defined($count) or trim($engine) eq '' );
$enginestats{$engine} = $size; $enginestats{$engine} = $size;
$enginecount{$engine} = $count; $enginecount{$engine} = $count;
$result{'Engine'}{$engine}{'Table Number'} = $count; $result{'Engine'}{$engine}{'Table Number'} = $count;
@ -2255,9 +2256,9 @@ sub check_storage_engines {
foreach my $tbl (@tblist) { foreach my $tbl (@tblist) {
debugprint "Data dump " . Dumper(@$tbl); debugprint "Data dump " . Dumper(@$tbl);
my ( $engine, $size, $datafree ) = @$tbl; my ( $engine, $size, $datafree ) = @$tbl;
next if $engine eq 'NULL'; next if $engine eq 'NULL' or not defined($engine);
$size = 0 if $size eq 'NULL'; $size = 0 if $size eq 'NULL' or not defined($size);
$datafree = 0 if $datafree eq 'NULL'; $datafree = 0 if $datafree eq 'NULL' or not defined($datafree);
if ( defined $enginestats{$engine} ) { if ( defined $enginestats{$engine} ) {
$enginestats{$engine} += $size; $enginestats{$engine} += $size;
$enginecount{$engine} += 1; $enginecount{$engine} += 1;
@ -6399,7 +6400,7 @@ __END__
=head1 NAME =head1 NAME
MySQLTuner 1.7.18 - MySQL High Performance Tuning Script MySQLTuner 1.7.19 - MySQL High Performance Tuning Script
=head1 IMPORTANT USAGE GUIDELINES =head1 IMPORTANT USAGE GUIDELINES