hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Wrong recommendation "thread_pool_size between 16 and 36 for InnoDB usage" for Percona Server (#551)

Browse source
This commit is contained in:
Jean-Marie Renouard 2021-10-15 16:28:19 +02:00
parent 1333ea9395
commit 6b6d85ef28
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
mysqltuner.pl
View file

@ -1,5 +1,5 @@
#!/usr/bin/env perl #!/usr/bin/env perl
# mysqltuner.pl - Version 1.8.3 # mysqltuner.pl - Version 1.8.4
# High Performance MySQL Tuning Script # High Performance MySQL Tuning Script
# Copyright (C) 2006-2021 Major Hayden - major@mhtx.net # Copyright (C) 2006-2021 Major Hayden - major@mhtx.net
# #
@ -56,7 +56,7 @@ use Cwd 'abs_path';
#use Env; #use Env;
# Set up a few variables for use in the script # Set up a few variables for use in the script
my $tunerversion = "1.8.3"; my $tunerversion = "1.8.4";
my ( @adjvars, @generalrec ); my ( @adjvars, @generalrec );
# Set defaults # Set defaults
@ -303,6 +303,7 @@ sub cpu_cores {
if ( $^O eq 'linux' ) { if ( $^O eq 'linux' ) {
my $cntCPU = my $cntCPU =
`awk -F: '/^core id/ && !P[\$2] { CORES++; P[\$2]=1 }; /^physical id/ && !N[\$2] { CPUs++; N[\$2]=1 }; END { print CPUs*CORES }' /proc/cpuinfo`; `awk -F: '/^core id/ && !P[\$2] { CORES++; P[\$2]=1 }; /^physical id/ && !N[\$2] { CPUs++; N[\$2]=1 }; END { print CPUs*CORES }' /proc/cpuinfo`;
chmop $cntCPU;
return ( $cntCPU == 0 ? `nproc` : $cntCPU ); return ( $cntCPU == 0 ? `nproc` : $cntCPU );
} }
@ -3635,19 +3636,19 @@ sub mariadb_threadpool {
infoprint "ThreadPool stat is enabled."; infoprint "ThreadPool stat is enabled.";
infoprint "Thread Pool Size: " . $myvar{'thread_pool_size'} . " thread(s)."; infoprint "Thread Pool Size: " . $myvar{'thread_pool_size'} . " thread(s).";
if ( $myvar{'version'} =~ /percona/i ) { if ( $myvar{'version'} =~ /percona/i or $myvar{'version_comment'} =~ /percona/i ) {
my $np = cpu_cores; my $np = cpu_cores;
if ( $myvar{'thread_pool_size'} >= $np if ( $myvar{'thread_pool_size'} >= $np
and $myvar{'thread_pool_size'} < ( $np * 1.5 ) ) and $myvar{'thread_pool_size'} < ( $np * 1.5 ) )
{ {
goodprint goodprint
"thread_pool_size for Percona betwwen 1 and 1.5 times nimber of CPUs (" "thread_pool_size for Percona betwwen 1 and 1.5 times number of CPUs ("
. $np . " and " . $np . " and "
. ( $np * 1.5 ) . ")"; . ( $np * 1.5 ) . ")";
} }
else { else {
badprint badprint
"thread_pool_size for Percona betwwen 1 and 1.5 times nimber of CPUs (" "thread_pool_size for Percona betwwen 1 and 1.5 times number of CPUs ("
. $np . " and " . $np . " and "
. ( $np * 1.5 ) . ")"; . ( $np * 1.5 ) . ")";
push( @adjvars, push( @adjvars,
@ -6601,7 +6602,7 @@ __END__
=head1 NAME =head1 NAME
MySQLTuner 1.8.3 - MySQL High Performance Tuning Script MySQLTuner 1.8.4 - MySQL High Performance Tuning Script
=head1 IMPORTANT USAGE GUIDELINES =head1 IMPORTANT USAGE GUIDELINES