From 6c939906dd454e78027c4c01ff67bd085d86f510 Mon Sep 17 00:00:00 2001 From: Mohammad Date: Sat, 20 Feb 2016 18:01:30 +0200 Subject: [PATCH] #87 password single quote to double quote --- mysqltuner.pl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index da747ee..fe3eb4b 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -507,7 +507,7 @@ sub mysql_setup { # Did we already get a username and password passed on the command line? if ( $opt{user} ne 0 and $opt{pass} ne 0 ) { - $mysqllogin = "-u $opt{user} -p'$opt{pass}'" . $remotestring; + $mysqllogin = "-u $opt{user} -p\"$opt{pass}\"" . $remotestring; my $loginstatus = `$mysqladmincmd ping $mysqllogin 2>&1`; if ( $loginstatus =~ /mysqld is alive/ ) { goodprint @@ -649,16 +649,17 @@ sub mysql_setup { $mysqllogin = "-u $name"; if ( length($password) > 0 ) { - $mysqllogin .= " -p'$password'"; + $mysqllogin .= " -p\"$password\""; } $mysqllogin .= $remotestring; my $loginstatus = `$mysqladmincmd ping $mysqllogin 2>&1`; + debugprint "Login status command: $mysqladmincmd ping $mysqllogin 2>&1"; if ( $loginstatus =~ /mysqld is alive/ ) { print STDERR ""; if ( !length($password) ) { # Did this go well because of a .my.cnf file or is there no password set? - my $userpath = `ls -d ~`; + my $userpath = `printenv HOME`; chomp($userpath); unless ( -e "$userpath/.my.cnf" ) { badprint @@ -668,7 +669,7 @@ sub mysql_setup { return 1; } else { - badprint " Attempted to use login credentials, but they were invalid."; + badprint "Attempted to use login credentials, but they were invalid."; exit 1; } exit 1;