hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

#146: Correct write effiency calculation based on log writes

Browse source
This commit is contained in:
root 2016-02-24 20:20:48 +01:00
parent 09383daee8
commit 6dae07a921
1 changed files with 27 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
mysqltuner.pl
View file

@ -377,6 +377,7 @@ sub os_setup {
# Checks for updates to MySQLTuner # Checks for updates to MySQLTuner
sub validate_tuner_version { sub validate_tuner_version {
if ($opt{checkversion} eq 0) { if ($opt{checkversion} eq 0) {
print "\n";
infoprint "Skipped version check for MySQLTuner script"; infoprint "Skipped version check for MySQLTuner script";
return; return;
} }
@ -1651,6 +1652,8 @@ sub calculations {
( $myvar{'innodb_log_file_size'} * 100 / ( $myvar{'innodb_log_file_size'} * 100 /
$myvar{'innodb_buffer_pool_size'} ); $myvar{'innodb_buffer_pool_size'} );
} }
# InnoDB Buffer pool read cache effiency
( (
$mystat{'Innodb_buffer_pool_read_requests'}, $mystat{'Innodb_buffer_pool_read_requests'},
$mystat{'Innodb_buffer_pool_reads'} $mystat{'Innodb_buffer_pool_reads'}
@ -1669,24 +1672,28 @@ sub calculations {
. $mystat{'Innodb_buffer_pool_reads'} . ""; . $mystat{'Innodb_buffer_pool_reads'} . "";
debugprint "Innodb_buffer_pool_read_requests: " debugprint "Innodb_buffer_pool_read_requests: "
. $mystat{'Innodb_buffer_pool_read_requests'} . ""; . $mystat{'Innodb_buffer_pool_read_requests'} . "";
# InnoDB log write cache effiency
( (
$mystat{'Innodb_buffer_pool_write_requests'}, $mystat{'Innodb_log_write_requests'},
$mystat{'Innodb_buffer_pool_writes'} $mystat{'Innodb_log_writes'}
) )
= ( 1, 1 ) = ( 1, 1 )
unless defined $mystat{'Innodb_buffer_pool_writes'}; unless defined $mystat{'Innodb_log_writes'};
$mycalc{'pct_write_efficiency'} = percentage( $mycalc{'pct_write_efficiency'} = percentage(
( (
$mystat{'Innodb_buffer_pool_write_requests'} - $mystat{'Innodb_log_write_requests'} -
$mystat{'Innodb_buffer_pool_writes'} $mystat{'Innodb_log_writes'}
), ),
$mystat{'Innodb_buffer_pool_write_requests'} $mystat{'Innodb_log_write_requests'}
) if defined $mystat{'Innodb_buffer_pool_write_requests'}; ) if defined $mystat{'Innodb_log_write_requests'};
debugprint "pct_write_efficiency: " . $mycalc{'pct_read_efficiency'} . ""; debugprint "pct_write_efficiency: " . $mycalc{'pct_write_efficiency'} . "";
debugprint "Innodb_buffer_pool_writes: " debugprint "Innodb_log_writes: "
. $mystat{'Innodb_buffer_pool_writes'} . ""; . $mystat{'Innodb_log_writes'} . "";
debugprint "Innodb_buffer_pool_write_requests: " debugprint "Innodb_log_write_requests: "
. $mystat{'Innodb_buffer_pool_write_requests'} . ""; . $mystat{'Innodb_log_write_requests'} . "";
$mycalc{'pct_innodb_buffer_used'} = percentage( $mycalc{'pct_innodb_buffer_used'} = percentage(
( (
$mystat{'Innodb_buffer_pool_pages_total'} - $mystat{'Innodb_buffer_pool_pages_total'} -
@ -2600,21 +2607,21 @@ sub mysql_innodb {
if ( defined $mycalc{'pct_write_efficiency'} if ( defined $mycalc{'pct_write_efficiency'}
&& $mycalc{'pct_write_efficiency'} < 90 ) && $mycalc{'pct_write_efficiency'} < 90 )
{ {
badprint "InnoDB Write buffer efficiency: " badprint "InnoDB Write Log efficiency: "
. $mycalc{'pct_write_efficiency'} . "% (" . $mycalc{'pct_write_efficiency'} . "% ("
. ( $mystat{'Innodb_buffer_pool_write_requests'} - . ( $mystat{'Innodb_log_write_requests'} -
$mystat{'Innodb_buffer_pool_writes'} ) $mystat{'Innodb_log_writes'} )
. " hits/ " . " hits/ "
. $mystat{'Innodb_buffer_pool_write_requests'} . $mystat{'Innodb_log_write_requests'}
. " total)"; . " total)";
} }
else { else {
goodprint "InnoDB Write buffer efficiency: " goodprint "InnoDB Write log efficiency: "
. $mycalc{'pct_write_efficiency'} . "% (" . $mycalc{'pct_write_efficiency'} . "% ("
. ( $mystat{'Innodb_buffer_pool_write_requests'} - . ( $mystat{'Innodb_log_write_requests'} -
$mystat{'Innodb_buffer_pool_writes'} ) $mystat{'Innodb_log_writes'} )
. " hits/ " . " hits/ "
. $mystat{'Innodb_buffer_pool_write_requests'} . $mystat{'Innodb_log_write_requests'}
. " total)"; . " total)";
} }