hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Missing password is not recognized #412

Browse source
This commit is contained in:
Jean-Marie Renouard 2019-10-03 23:15:31 +02:00
parent 851cd817de
commit 6f6130b12b
2 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
build/runMT.sh
View file

@ -22,4 +22,5 @@ do
ls -ls /var/lib | grep -E 'mysql$' ls -ls /var/lib | grep -E 'mysql$'
#set +x #set +x
perl mysqltuner.pl $* --host 127.0.0.1 --port $container_port perl mysqltuner.pl $* --host 127.0.0.1 --port $container_port
exit $?
done < "$input" done < "$input"

25
mysqltuner.pl
View file

@ -875,7 +875,6 @@ sub mysql_setup {
} }
} }
else { else {
# It's not Plesk or Debian, we should try a login # It's not Plesk or Debian, we should try a login
debugprint "$mysqladmincmd $remotestring ping 2>&1"; debugprint "$mysqladmincmd $remotestring ping 2>&1";
my $loginstatus = `$mysqladmincmd $remotestring ping 2>&1`; my $loginstatus = `$mysqladmincmd $remotestring ping 2>&1`;
@ -1798,6 +1797,8 @@ sub security_recommendations {
"Remove Anonymous User accounts - there are " "Remove Anonymous User accounts - there are "
. scalar(@mysqlstatlist) . scalar(@mysqlstatlist)
. " anonymous accounts." ); . " anonymous accounts." );
push( @generalrec,
"DELETE FROM ymsql.user WHERE user ='';" );
} }
else { else {
goodprint "There are no anonymous accounts for any database users"; goodprint "There are no anonymous accounts for any database users";
@ -1821,10 +1822,8 @@ sub security_recommendations {
foreach my $line ( sort @mysqlstatlist ) { foreach my $line ( sort @mysqlstatlist ) {
chomp($line); chomp($line);
badprint "User '" . $line . "' has no password set."; badprint "User '" . $line . "' has no password set.";
push (@generalrec, "Set up a Secure Password for $line user: SET PASSWORD FOR '".(split /@/, $line)[0]."'\@'SpecificDNSorIp' = PASSWORD('secure_password');")
} }
push( @generalrec,
"Set up a Password for user with the following SQL statement ( SET PASSWORD FOR 'user'\@'SpecificDNSorIp' = PASSWORD('secure_password'); )"
);
} }
else { else {
goodprint "All database users have passwords assigned"; goodprint "All database users have passwords assigned";
@ -1848,10 +1847,8 @@ sub security_recommendations {
foreach my $line ( sort @mysqlstatlist ) { foreach my $line ( sort @mysqlstatlist ) {
chomp($line); chomp($line);
badprint "User '" . $line . "' has user name as password."; badprint "User '" . $line . "' has user name as password.";
push (@generalrec, "Set up a Secure Password for $line user: SET PASSWORD FOR '".(split /@/, $line)[0]."'\@'SpecificDNSorIp' = PASSWORD('secure_password');");
} }
push( @generalrec,
"Set up a Secure Password for user\@host ( SET PASSWORD FOR 'user'\@'SpecificDNSorIp' = PASSWORD('secure_password'); )"
);
} }
@mysqlstatlist = select_array @mysqlstatlist = select_array
@ -1859,11 +1856,13 @@ sub security_recommendations {
if (@mysqlstatlist) { if (@mysqlstatlist) {
foreach my $line ( sort @mysqlstatlist ) { foreach my $line ( sort @mysqlstatlist ) {
chomp($line); chomp($line);
badprint "User '" . $line my $luser = (split /@/, $line)[0];
. "' does not specify hostname restrictions."; badprint "User '" . $line. "' does not specify hostname restrictions.";
push( @generalrec,
"Restrict Host for '$luser'\@% to $luser\@SpecificDNSorIp" );
push( @generalrec,
"UPDATE mysql.user SET host ='SpecificDNSorIp' WHERE user='" . $luser. "' AND host ='%'; FLUSH PRIVILEGES;" );
} }
push( @generalrec,
"Restrict Host for user\@% to user\@SpecificDNSorIp" );
} }
unless ( -f $basic_password_files ) { unless ( -f $basic_password_files ) {
@ -1905,6 +1904,8 @@ sub security_recommendations {
chomp($line); chomp($line);
badprint "User '" . $line badprint "User '" . $line
. "' is using weak password: $pass in a lower, upper or capitalize derivative version."; . "' is using weak password: $pass in a lower, upper or capitalize derivative version.";
push (@generalrec, "Set up a Secure Password for $line user: SET PASSWORD FOR '" . (split /@/, $line)[0] . "'\@'".(split /@/, $line)[1]."' = PASSWORD('secure_password');");
$nbins++; $nbins++;
} }
} }
@ -1913,7 +1914,7 @@ sub security_recommendations {
} }
} }
if ( $nbins > 0 ) { if ( $nbins > 0 ) {
push( @generalrec, $nbins . " user(s) used basic or weak password." ); push( @generalrec, $nbins . " user(s) used basic or weak password from basic dictionary." );
} }
} }