hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix 'Bareword file handle opened'

Browse source
This commit is contained in:
Christian Loos 2016-08-30 13:27:13 +02:00
parent f3e3b39023
commit 90e8251523
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
mysqltuner.pl
View file

@ -1036,9 +1036,9 @@ sub remove_empty {
sub get_file_contents { sub get_file_contents {
my $file = shift; my $file = shift;
open( FH, "< $file" ) or die "Can't open $file for read: $!"; open(my $fh, "<", $file) or die "Can't open $file for read: $!";
my @lines = <FH>; my @lines = <$fh>;
close FH or die "Cannot close $file: $!"; close $fh or die "Cannot close $file: $!";
remove_cr \@lines; remove_cr \@lines;
return @lines; return @lines;
} }
@ -1056,8 +1056,8 @@ sub cve_recommendations {
#prettyprint "Look for related CVE for $myvar{'version'} or lower in $opt{cvefile}"; #prettyprint "Look for related CVE for $myvar{'version'} or lower in $opt{cvefile}";
my $cvefound = 0; my $cvefound = 0;
open( FH, "<$opt{cvefile}" ) or die "Can't open $opt{cvefile} for read: $!"; open(my $fh, "<", $opt{cvefile}) or die "Can't open $opt{cvefile} for read: $!";
while ( my $cveline = <FH> ) { while ( my $cveline = <$fh> ) {
my @cve = split( ';', $cveline ); my @cve = split( ';', $cveline );
debugprint "Comparing $mysqlvermajor\.$mysqlverminor\.$mysqlvermicro with $cve[1]\.$cve[2]\.$cve[3] : ".(mysql_version_le( $cve[1], $cve[2], $cve[3] )?'<=':'>'); debugprint "Comparing $mysqlvermajor\.$mysqlverminor\.$mysqlvermicro with $cve[1]\.$cve[2]\.$cve[3] : ".(mysql_version_le( $cve[1], $cve[2], $cve[3] )?'<=':'>');
@ -1069,7 +1069,7 @@ sub cve_recommendations {
$cvefound++; $cvefound++;
} }
} }
close FH or die "Cannot close $opt{cvefile}: $!"; close $fh or die "Cannot close $opt{cvefile}: $!";
$result{'CVE'}{'nb'}=$cvefound; $result{'CVE'}{'nb'}=$cvefound;
if ( $cvefound == 0 ) { if ( $cvefound == 0 ) {
goodprint "NO SECURITY CVE FOUND FOR YOUR VERSION"; goodprint "NO SECURITY CVE FOUND FOR YOUR VERSION";