From 93a8c0849e123ff882bebe9cb4979533b8cee64a Mon Sep 17 00:00:00 2001 From: MichaIng Date: Mon, 24 Jan 2022 02:23:54 +0100 Subject: [PATCH] Hide recommendation when no key buffer is used Currently, when a key_buffer_size=0 is applied, MySQLTuner sets pct_key_buffer_used=0 but still shows it as "[!!]" (bad), recommending to adjust key_buffer_size to "~ 0". The idea surely was show it neither as good or bad in this case, but as debugprint, which is currently never used since pct_key_buffer_used is always defined. This commit changes the condition to check whether pct_key_buffer_used is larger then zero, to decide whether to show good/bad (with recommendation) or a debug info without recommendation. Signed-off-by: MichaIng --- mysqltuner.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 33b3043..b72e077 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -3556,7 +3556,7 @@ sub mysql_myisam { } # Key buffer usage - if ( defined( $mycalc{'pct_key_buffer_used'} ) ) { + if ( $mycalc{'pct_key_buffer_used'} > 0 ) { if ( $mycalc{'pct_key_buffer_used'} < 90 ) { badprint "Key buffer used: $mycalc{'pct_key_buffer_used'}% (" . hr_bytes( $myvar{'key_buffer_size'} -