From adb33d3c375875e1d50a37db675b9586fd15b9bf Mon Sep 17 00:00:00 2001 From: "Oscar A. Figueroa" Date: Tue, 7 Mar 2017 12:48:43 +0100 Subject: [PATCH 1/2] Resolved issue #304 --- mysqltuner.pl | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 0efbfa4..11d8e51 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -5041,28 +5041,28 @@ group by c.table_schema,c.table_name having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0" ); - if (get_wsrep_option('wsrep_slave_threads') > `nproc`*4 or get_wsrep_option('wsrep_slave_threads') < `nproc`*3) { - badprint "wsrep_slave_threads is not equal to 3 or 4 times number of CPU(s)"; - push @adjvars, "wsrep_slave_threads= Nb of Core CPU * 4"; + if ($myvar{'wsrep_slave_threads'} > `nproc` * 4 or $myvar{'wsrep_slave_threads'} < `nproc` * 2) { + badprint "wsrep_slave_threads is not equal to 2 or 4 times number of CPU(s)"; + push @adjvars, "wsrep_slave_threads= Nb of Core CPU * 2"; } else { - goodprint "wsrep_slave_threads is equal to 3 or 4 times number of CPU(s)"; + goodprint "wsrep_slave_threads is equal to 2 or 4 times number of CPU(s)"; } - if (get_wsrep_option('gcs.limit') != get_wsrep_option('wsrep_slave_threads') *5 ) { - badprint "gcs.limit should be equal to 5 * wsrep_slave_threads"; - push @adjvars, "gcs.limit= wsrep_slave_threads * 5"; + if (get_wsrep_option('gcs.fc_limit') != $myvar{'wsrep_slave_threads'} * 5 ) { + badprint "gcs.fc_limit should be equal to 5 * wsrep_slave_threads"; + push @adjvars, "gcs.fc_limit= wsrep_slave_threads * 5"; } else { - goodprint "gcs.limit is equal to 5 * wsrep_slave_threads"; + goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads"; } if (get_wsrep_option('gcs.fc_factor') == 0.8 ) { badprint "gcs.fc_factor should be equal to 0.8"; push @adjvars, "gcs.fc_factor=0.8"; } else { - goodprint "gcs.limit is equal to 5 * wsrep_slave_threads"; + goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads"; } - if (get_wsrep_option('wsrep_flow_control_paused') > 0.02) { + if ($mystat{'wsrep_flow_control_paused'} > 0.02) { badprint "Fraction of time node pause flow control > 0.02"; } else { From 24b901363c788a8ba08102f588b91fee897a74a7 Mon Sep 17 00:00:00 2001 From: "Oscar A. Figueroa" Date: Wed, 8 Mar 2017 11:50:02 +0100 Subject: [PATCH 2/2] Bugfix resolve #308 : gcs.fc_factor parameter evaluation and the message report, which referencing wsrep_slave_threads instead. --- mysqltuner.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 11d8e51..dd50384 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -5055,12 +5055,12 @@ having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0" else { goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads"; } - if (get_wsrep_option('gcs.fc_factor') == 0.8 ) { + if (get_wsrep_option('gcs.fc_factor') != 0.8 ) { badprint "gcs.fc_factor should be equal to 0.8"; push @adjvars, "gcs.fc_factor=0.8"; } else { - goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads"; + goodprint "gcs.fc_factor is equal to 0.8"; } if ($mystat{'wsrep_flow_control_paused'} > 0.02) { badprint "Fraction of time node pause flow control > 0.02";