hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ticket #383 Minor accessing undefined variable bug to fix eventually

Browse source
This commit is contained in:
Jean-Marie RENOUARD 2018-06-29 12:16:30 +02:00
parent eb7300446c
commit 9cf4dd4453
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/updateStaff.sh
View file

@ -9,7 +9,7 @@ perltidy -b mysqltuner.pl
echo "* Update CVE list" echo "* Update CVE list"
perl updateCVElist.pl perl updateCVElist.pl
git add ../vulnerabilities.csv ../mysqltuner.pl ./USAGE.md git add ../vulnerabilities.csv ../mysqltuner.pl ../USAGE.md
git commit -m 'Update Vulnerabilities list git commit -m 'Update Vulnerabilities list
Indenting mysqltuner Indenting mysqltuner
Update Usage information' Update Usage information'

10
mysqltuner.pl
View file

@ -1778,7 +1778,8 @@ sub security_recommendations {
if (@mysqlstatlist) { if (@mysqlstatlist) {
foreach my $line ( sort @mysqlstatlist ) { foreach my $line ( sort @mysqlstatlist ) {
chomp($line); chomp($line);
badprint "User '" . $line . "' does not specify hostname restrictions."; badprint "User '" . $line
. "' does not specify hostname restrictions.";
} }
push( @generalrec, push( @generalrec,
"Restrict Host for user\@% to user\@SpecificDNSorIp" ); "Restrict Host for user\@% to user\@SpecificDNSorIp" );
@ -1847,7 +1848,7 @@ sub get_replication_status {
. " server(s)."; . " server(s).";
} }
infoprint "Binlog format: " . $myvar{'binlog_format'}; infoprint "Binlog format: " . $myvar{'binlog_format'};
infoprint "XA support enabled: " . $myvar{'innodb_support_xa'}; infoprint "XA support enabled: " . defined($myvar{'innodb_support_xa'})?$myvar{'innodb_support_xa'}:'UNKONOWN';
infoprint "Semi synchronous replication Master: " infoprint "Semi synchronous replication Master: "
. ( . (
defined( $myvar{'rpl_semi_sync_master_enabled'} ) defined( $myvar{'rpl_semi_sync_master_enabled'} )
@ -2664,7 +2665,7 @@ sub mysql_stats {
$qps = sprintf( "%.3f", $mystat{'Questions'} / $mystat{'Uptime'} ); $qps = sprintf( "%.3f", $mystat{'Questions'} / $mystat{'Uptime'} );
} }
push( @generalrec, push( @generalrec,
"MySQL was started within the last 24 hours - recommendations may be inaccurate" "MySQL was started within the last 24 hours - recommendations may be inaccurate"
) if ( $mystat{'Uptime'} < 86400 ); ) if ( $mystat{'Uptime'} < 86400 );
infoprint "Up for: " infoprint "Up for: "
. pretty_uptime( $mystat{'Uptime'} ) . " (" . pretty_uptime( $mystat{'Uptime'} ) . " ("
@ -3412,7 +3413,8 @@ sub mysqsl_pfs {
infoprint "Performance schema is disabled."; infoprint "Performance schema is disabled.";
if ( mysql_version_ge( 5, 6 ) ) { if ( mysql_version_ge( 5, 6 ) ) {
push( @generalrec, push( @generalrec,
"Performance schema should be activated for better diagnostics" ); "Performance schema should be activated for better diagnostics"
);
push( @adjvars, "performance_schema = ON enable PFS" ); push( @adjvars, "performance_schema = ON enable PFS" );
} }
} }