From a07f7a16e3d92efa5b3601bf9f0780599e81c4f4 Mon Sep 17 00:00:00 2001 From: Blake Swopes Date: Mon, 3 Mar 2014 14:18:12 -0800 Subject: [PATCH] Shifting InnoDB log waits block up into the have_innodb block. This should prevent any attempt to access an undefined Innodb_log_waits value. resolves #42 --- mysqltuner.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 4599a7f..63b8a96 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -961,12 +961,12 @@ sub mysql_stats { badprint "InnoDB buffer pool / data size: ".hr_bytes($myvar{'innodb_buffer_pool_size'})."/".hr_bytes($enginestats{'InnoDB'})."\n"; push(@adjvars,"innodb_buffer_pool_size (>= ".hr_bytes_rnd($enginestats{'InnoDB'}).")"); } - } - if (defined $mystat{'Innodb_log_waits'} && $mystat{'Innodb_log_waits'} > 0) { - badprint "InnoDB log waits: ".$mystat{'Innodb_log_waits'}; - push(@adjvars,"innodb_log_buffer_size (>= ".hr_bytes_rnd($myvar{'innodb_log_buffer_size'}).")"); - } else { - goodprint "InnoDB log waits: ".$mystat{'Innodb_log_waits'}; + if (defined $mystat{'Innodb_log_waits'} && $mystat{'Innodb_log_waits'} > 0) { + badprint "InnoDB log waits: ".$mystat{'Innodb_log_waits'}; + push(@adjvars,"innodb_log_buffer_size (>= ".hr_bytes_rnd($myvar{'innodb_log_buffer_size'}).")"); + } else { + goodprint "InnoDB log waits: ".$mystat{'Innodb_log_waits'}; + } } }