From a146c81b7c37aebaa5c2084c843bf65e8465b5bf Mon Sep 17 00:00:00 2001 From: Jean-Marie Renouard Date: Sat, 16 Oct 2021 17:07:14 +0200 Subject: [PATCH] Wrong recommendation "thread_pool_size between 16 and 36 for InnoDB usage" for Percona Server #551" --- mysqltuner.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 7b4c72a..48e395a 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -1,5 +1,5 @@ #!/usr/bin/env perl -# mysqltuner.pl - Version 1.8.4 +# mysqltuner.pl - Version 1.8.5 # High Performance MySQL Tuning Script # Copyright (C) 2006-2021 Major Hayden - major@mhtx.net # @@ -56,7 +56,7 @@ use Cwd 'abs_path'; #use Env; # Set up a few variables for use in the script -my $tunerversion = "1.8.4"; +my $tunerversion = "1.8.5"; my ( @adjvars, @generalrec ); # Set defaults @@ -303,7 +303,7 @@ sub cpu_cores { if ( $^O eq 'linux' ) { my $cntCPU = `awk -F: '/^core id/ && !P[\$2] { CORES++; P[\$2]=1 }; /^physical id/ && !N[\$2] { CPUs++; N[\$2]=1 }; END { print CPUs*CORES }' /proc/cpuinfo`; - chmop $cntCPU; + chomp $cntCPU; return ( $cntCPU == 0 ? `nproc` : $cntCPU ); } @@ -3642,13 +3642,13 @@ sub mariadb_threadpool { and $myvar{'thread_pool_size'} < ( $np * 1.5 ) ) { goodprint -"thread_pool_size for Percona betwwen 1 and 1.5 times number of CPUs (" +"thread_pool_size for Percona between 1 and 1.5 times number of CPUs (" . $np . " and " . ( $np * 1.5 ) . ")"; } else { badprint -"thread_pool_size for Percona betwwen 1 and 1.5 times number of CPUs (" +"thread_pool_size for Percona between 1 and 1.5 times number of CPUs (" . $np . " and " . ( $np * 1.5 ) . ")"; push( @adjvars, @@ -6602,7 +6602,7 @@ __END__ =head1 NAME - MySQLTuner 1.8.4 - MySQL High Performance Tuning Script + MySQLTuner 1.8.5 - MySQL High Performance Tuning Script =head1 IMPORTANT USAGE GUIDELINES