From a421f73e2677b70fdb9c5f7b5a489a717373ef9a Mon Sep 17 00:00:00 2001
From: Jean-Marie Renouard <jmrenouard@gmail.com>
Date: Thu, 3 Oct 2019 21:04:12 +0200
Subject: [PATCH] Add note about join_buffer_size #434

---
 build/createMassDockerImages.sh |  7 ++++---
 build/createTestEnvs.sh         | 25 ++++++++++++++-----------
 build/fetchSampleDatabases.sh   |  5 +----
 mysqltuner.pl                   |  4 +++-
 4 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/build/createMassDockerImages.sh b/build/createMassDockerImages.sh
index a100dab..543d860 100644
--- a/build/createMassDockerImages.sh
+++ b/build/createMassDockerImages.sh
@@ -3,7 +3,7 @@
 input="./build/configimg.conf"
 default_password="secret"
 
-eco "[client]
+echo "[client]
 user=root
 password=$default_password" > $HOME/.my.cnf
 
@@ -25,7 +25,7 @@ chmod 600 $HOME/.my.cnf
 5309;mariadb101;/var/lib/mariadb101;mariadb:10.1
 5310;mariadb100;/var/lib/mariadb100;mariadb:10.0
 5311;mariadb55;/var/lib/mariadb55;mariadb:5.5
-" > $input
+" > "$input"
 
 #
 
@@ -46,7 +46,8 @@ do
         [ $? -eq 0 ] || continue
     fi
     echo "* PULLING DOCKER IMAGE: $image_name"
-    docker pull $image_name
+    docker images | grep -E " $image_name$"
+    [ $? -ne 0 ] && docker pull $image_name
 
     echo "* REMOVING CONTAINER : $image_name"
     docker ps -a | grep -qE "$container_name^"
diff --git a/build/createTestEnvs.sh b/build/createTestEnvs.sh
index 7cc3f2e..e9addee 100644
--- a/build/createTestEnvs.sh
+++ b/build/createTestEnvs.sh
@@ -1,20 +1,23 @@
 #!/bin/sh
 
 source build/bashrc
-sudo dnf install -y yum-utils device-mapper-persistent-data lvm2
-sudo dnf -y install dnf-plugins-core
-sudo dnf config-manager \
---add-repo \
-https://download.docker.com/linux/fedora/docker-ce.repo
 
-sudo dnf -y install docker-ce docker-ce-cli containerd.io
-dnf list docker-ce  --showduplicates | sort -r
+systemctl status docker &>/dev/null
+if [ $? -ne 0 ];then
+    sudo dnf install -y yum-utils device-mapper-persistent-data lvm2
+    sudo dnf -y install dnf-plugins-core
+    sudo dnf config-manager \
+    --add-repo \
+    https://download.docker.com/linux/fedora/docker-ce.repo
 
-sudo systemctl start docker
-sudo systemctl enable docker
-sudo usermod -aG docker vagrant
-sudo systemctl daemon-reload
+    sudo dnf -y install docker-ce docker-ce-cli containerd.io
+    dnf list docker-ce --showduplicates | sort -r
 
+    sudo systemctl start docker
+    sudo systemctl enable docker
+    sudo usermod -aG docker vagrant
+    sudo systemctl daemon-reload
+fi
 
 sh build/createMassDockerImages.sh
 
diff --git a/build/fetchSampleDatabases.sh b/build/fetchSampleDatabases.sh
index 7116965..b580a1d 100644
--- a/build/fetchSampleDatabases.sh
+++ b/build/fetchSampleDatabases.sh
@@ -23,10 +23,7 @@ case "$1" in
         mkdir -p ./contents
         [ -f "contents/$(basename $(getVal "DB_$2_URL"))" ] || wget -O contents/$(basename $(getVal "DB_$2_URL")) $(getVal "DB_$2_URL")
         if [ $? -eq 0 ];then
-             (
-                cd contents
-                unzip $(basename $(getVal "DB_$2_URL")))
-             )
+             (cd contents; unzip $( basename $(getVal "DB_$2_URL")) )
         fi
         ;;
     "clean")
diff --git a/mysqltuner.pl b/mysqltuner.pl
index 30ac304..48ba9d9 100755
--- a/mysqltuner.pl
+++ b/mysqltuner.pl
@@ -3079,7 +3079,9 @@ sub mysql_stats {
               . hr_bytes( $myvar{'join_buffer_size'} )
               . ", or always use indexes with JOINs)" );
         push( @generalrec,
-            "Adjust your join queries to always utilize indexes" );
+            "We will suggest raising the 'join_buffer_size' until JOINs not using indexes are found.
+             See https://dev.mysql.com/doc/internals/en/join-buffer-size.html
+             (specially the conclusions at the bottom of the page).");
     }
     else {
         goodprint "No joins without indexes";