hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge branch 'major:master' into master

Browse source
This commit is contained in:
Jean-Marie Renouard 2023-04-12 20:54:58 +02:00 committed by GitHub
commit af67fe8100
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
mysqltuner.pl
View file

@ -245,8 +245,6 @@ $opt{nocolor} = 0 if ( $opt{color} == 1 );
# Setting up the colors for the print styles # Setting up the colors for the print styles
my $me = `whoami`; my $me = `whoami`;
$me =~ s/\n//g; $me =~ s/\n//g;
# Setting up the colors for the print styles
my $good = ( $opt{nocolor} == 0 ) ? "[\e[0;32mOK\e[0m]" : "[OK]"; my $good = ( $opt{nocolor} == 0 ) ? "[\e[0;32mOK\e[0m]" : "[OK]";
my $bad = ( $opt{nocolor} == 0 ) ? "[\e[0;31m!!\e[0m]" : "[!!]"; my $bad = ( $opt{nocolor} == 0 ) ? "[\e[0;31m!!\e[0m]" : "[!!]";
my $info = ( $opt{nocolor} == 0 ) ? "[\e[0;34m--\e[0m]" : "[--]"; my $info = ( $opt{nocolor} == 0 ) ? "[\e[0;34m--\e[0m]" : "[--]";
@ -1420,13 +1418,13 @@ sub log_file_recommendations {
if ( $size > 0 ) { if ( $size > 0 ) {
goodprint "Log file $myvar{'log_error'} is not empty"; goodprint "Log file $myvar{'log_error'} is not empty";
if ( $size < 32 * 1024 * 1024 ) { if ( $size < 32 * 1024 * 1024 ) {
goodprint "Log file $myvar{'log_error'} is smaller than 32 Mb"; goodprint "Log file $myvar{'log_error'} is smaller than 32 MB";
} }
else { else {
badprint "Log file $myvar{'log_error'} is bigger than 32 Mb"; badprint "Log file $myvar{'log_error'} is bigger than 32 MB";
push @generalrec, push @generalrec,
$myvar{'log_error'} $myvar{'log_error'}
. " is > 32Mb, you should analyze why or implement a rotation log strategy such as logrotate!"; . " is > 32MB, you should analyze why or implement a rotation log strategy such as logrotate!";
} }
} }
else { else {
@ -1850,14 +1848,14 @@ sub get_system_info {
infoprint "External IP : " . $ext_ip; infoprint "External IP : " . $ext_ip;
$result{'Network'}{'External Ip'} = $ext_ip; $result{'Network'}{'External Ip'} = $ext_ip;
badprint badprint
"External IP : Can't check because of Internet connectivity" "External IP : Can't check, no Internet connectivity"
unless defined($httpcli); unless defined($httpcli);
infoprint "Name Servers : " infoprint "Name Servers : "
. infocmd_one "grep 'nameserver' /etc/resolv.conf \| awk '{print \$2}'"; . infocmd_one "grep 'nameserver' /etc/resolv.conf \| awk '{print \$2}'";
infoprint "Logged In users : "; infoprint "Logged In users : ";
infocmd_tab "who"; infocmd_tab "who";
$result{'OS'}{'Logged users'} = `who`; $result{'OS'}{'Logged users'} = `who`;
infoprint "Ram Usages in Mb : "; infoprint "Ram Usages in MB : ";
infocmd_tab "free -m | grep -v +"; infocmd_tab "free -m | grep -v +";
$result{'OS'}{'Free Memory RAM'} = `free -m | grep -v +`; $result{'OS'}{'Free Memory RAM'} = `free -m | grep -v +`;
infoprint "Load Average : "; infoprint "Load Average : ";
@ -1917,7 +1915,7 @@ sub system_recommendations {
. $opt{'maxportallowed'} . $opt{'maxportallowed'}
. "allowed."; . "allowed.";
push( @generalrec, push( @generalrec,
"Consider dedicating a server for your database installation with less services running on !" "Consider dedicating a server for your database installation with fewer services running on it!"
); );
} }
else { else {
@ -1931,7 +1929,7 @@ sub system_recommendations {
if ( is_open_port($banport) ) { if ( is_open_port($banport) ) {
badprint "Banned port: $banport is opened.."; badprint "Banned port: $banport is opened..";
push( @generalrec, push( @generalrec,
"Port $banport is opened. Consider stopping program handling this port." "Port $banport is opened. Consider stopping the program over this port."
); );
} }
else { else {
@ -1949,7 +1947,7 @@ sub security_recommendations {
subheaderprint "Security Recommendations"; subheaderprint "Security Recommendations";
if ( mysql_version_eq(8) ) { if ( mysql_version_eq(8) ) {
infoprint "Skipped due to unsupported feature for MySQL 8"; infoprint "Skipped due to unsupported feature for MySQL 8.0+";
return; return;
} }
@ -2011,7 +2009,7 @@ sub security_recommendations {
#exit 0; #exit 0;
if (@mysqlstatlist) { if (@mysqlstatlist) {
push( @generalrec, push( @generalrec,
"Remove Anonymous User accounts - there are " "Remove Anonymous User accounts: there are "
. scalar(@mysqlstatlist) . scalar(@mysqlstatlist)
. " anonymous accounts." ); . " anonymous accounts." );
foreach my $line ( sort @mysqlstatlist ) { foreach my $line ( sort @mysqlstatlist ) {
@ -2254,6 +2252,8 @@ sub validate_mysql_version {
$mysqlverminor ||= 0; $mysqlverminor ||= 0;
$mysqlvermicro ||= 0; $mysqlvermicro ||= 0;
prettyprint " ";
if ( mysql_version_eq(8) if ( mysql_version_eq(8)
or mysql_version_eq( 5, 7 ) or mysql_version_eq( 5, 7 )
or mysql_version_eq( 10, 3 ) or mysql_version_eq( 10, 3 )
@ -2547,7 +2547,7 @@ sub check_storage_engines {
&& defined $myvar{'have_innodb'} && defined $myvar{'have_innodb'}
&& $myvar{'have_innodb'} eq "YES" ) && $myvar{'have_innodb'} eq "YES" )
{ {
badprint "InnoDB is enabled but isn't being used"; badprint "InnoDB is enabled, but isn't being used";
push( @generalrec, push( @generalrec,
"Add skip-innodb to MySQL configuration to disable InnoDB" ); "Add skip-innodb to MySQL configuration to disable InnoDB" );
} }
@ -2555,7 +2555,7 @@ sub check_storage_engines {
&& defined $myvar{'have_bdb'} && defined $myvar{'have_bdb'}
&& $myvar{'have_bdb'} eq "YES" ) && $myvar{'have_bdb'} eq "YES" )
{ {
badprint "BDB is enabled but isn't being used"; badprint "BDB is enabled, but isn't being used";
push( @generalrec, push( @generalrec,
"Add skip-bdb to MySQL configuration to disable BDB" ); "Add skip-bdb to MySQL configuration to disable BDB" );
} }
@ -2563,7 +2563,7 @@ sub check_storage_engines {
&& defined $myvar{'have_isam'} && defined $myvar{'have_isam'}
&& $myvar{'have_isam'} eq "YES" ) && $myvar{'have_isam'} eq "YES" )
{ {
badprint "MyISAM is enabled but isn't being used"; badprint "MyISAM is enabled, but isn't being used";
push( @generalrec, push( @generalrec,
"Add skip-isam to MySQL configuration to disable MyISAM (MySQL > 4.1.0)" "Add skip-isam to MySQL configuration to disable MyISAM (MySQL > 4.1.0)"
); );