hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386

Browse source
This commit is contained in:
Jean-Marie Renouard 2018-09-26 09:10:09 +00:00
parent dab1e7e960
commit c8fb973bf8
1 changed files with 2 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
mysqltuner.pl
View file

@ -3070,18 +3070,6 @@ sub mysql_stats {
} }
# Thread cache # Thread cache
# if ( $myvar{'thread_cache_size'} eq 0 ) {
# badprint "Thread cache is disabled";
# push( @generalrec, "Set thread_cache_size to 4 as a starting value" );
# push( @adjvars, "thread_cache_size (start at 4)" );
# }
# else {
# if ( defined( $myvar{'thread_handling'} )
# and $myvar{'thread_handling'} eq 'pools-of-threads' )
# {
# infoprint "Thread cache hit rate: not used with pool-of-threads";
# }
if ( defined( $myvar{'thread_handling'} ) if ( defined( $myvar{'thread_handling'} )
and $myvar{'thread_handling'} eq 'pool-of-threads' ) and $myvar{'thread_handling'} eq 'pool-of-threads' )
{ {
@ -3089,8 +3077,8 @@ sub mysql_stats {
# When thread pool is enabled, the value of the thread_cache_size variable # When thread pool is enabled, the value of the thread_cache_size variable
# is ignored. The Threads_cached status variable contains 0 in this case. # is ignored. The Threads_cached status variable contains 0 in this case.
infoprint "Thread cache not used with thread_handling=pool-of-threads"; infoprint "Thread cache not used with thread_handling=pool-of-threads";
} }
else { else {
if ( $myvar{'thread_cache_size'} eq 0 ) { if ( $myvar{'thread_cache_size'} eq 0 ) {
badprint "Thread cache is disabled"; badprint "Thread cache is disabled";
push( @generalrec, "Set thread_cache_size to 4 as a starting value" ); push( @generalrec, "Set thread_cache_size to 4 as a starting value" );