From cb4784e8c730365f7d1b6bc6c07176e17eb61419 Mon Sep 17 00:00:00 2001 From: Jean-Marie Renouard Date: Tue, 30 May 2023 09:11:06 +0200 Subject: [PATCH] =?UTF-8?q?Revert=20pr=C3=A9view=20on=20skip=20name=20reso?= =?UTF-8?q?lve=20Name=20resolve=20should=20be=20OFF=20by=20default=20excep?= =?UTF-8?q?t=20for=20CPANEL=20&=20FLEX?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- mysqltuner.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 83fa800..38f1973 100644 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -3275,13 +3275,13 @@ sub mysql_stats { push( @adjvars, "skip-name-resolve=0" ); } } - elsif ( $result{'Variables'}{'skip_name_resolve'} eq 'OFF' ) { + elsif ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF' ) { badprint "Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance"; push( @generalrec, -"Configure your accounts with ip or subnets only, then update your configuration with skip-name-resolve=1" +"Configure your accounts with ip or subnets only, then update your configuration with skip-name-resolve=OFF" ); - push( @adjvars, "skip-name-resolve=1" ); + push( @adjvars, "skip-name-resolve=OFF" ); } # Query cache @@ -3965,11 +3965,11 @@ sub mysqsl_pfs { # Store all sys schema in dumpdir if defined if ( defined $opt{dumpdir} and -d "$opt{dumpdir}" ) { - for my $pfs_view ( select_array('use sys;show tables;') ) { - infoprint "Dumping $pfs_view into $opt{dumpdir}"; + for my $sys_view ( select_array('use sys;show tables;') ) { + infoprint "Dumping $sys_view into $opt{dumpdir}"; select_csv_file( - "$opt{dumpdir}/pfs_$pfs_view.csv", - "select * from sys.$pfs_view" + "$opt{dumpdir}/sys_$sys_view.csv", + "select * from sys.\`$sys_view\`" ); } exit 0 if ( $opt{stop} == 1 );