hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix for Recommendation to turn on performance_schema #579

Browse source
This commit is contained in:
Jean-Marie Renouard 2022-03-10 22:01:36 +01:00
parent e7f444c969
commit cc4fa414d2
1 changed files with 8 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
mysqltuner.pl
View file

@ -1,5 +1,5 @@
#!/usr/bin/env perl #!/usr/bin/env perl
# mysqltuner.pl - Version 1.9.4 # mysqltuner.pl - Version 1.9.5
# High Performance MySQL Tuning Script # High Performance MySQL Tuning Script
# Copyright (C) 2006-2022 Major Hayden - major@mhtx.net # Copyright (C) 2006-2022 Major Hayden - major@mhtx.net
# Copyright (C) 2006-2022 Jean-Marie Renouard - jmrenouard@gmail.com # Copyright (C) 2006-2022 Jean-Marie Renouard - jmrenouard@gmail.com
@ -57,7 +57,7 @@ use Cwd 'abs_path';
#use Env; #use Env;
# Set up a few variables for use in the script # Set up a few variables for use in the script
my $tunerversion = "1.9.4"; my $tunerversion = "1.9.5";
my ( @adjvars, @generalrec ); my ( @adjvars, @generalrec );
# Set defaults # Set defaults
@ -3812,39 +3812,17 @@ sub mysqsl_pfs {
# Performance Schema # Performance Schema
$myvar{'performance_schema'} = 'OFF' $myvar{'performance_schema'} = 'OFF'
unless defined( $myvar{'performance_schema'} ); unless defined( $myvar{'performance_schema'} );
if ( $myvar{'performance_schema'} eq 'OFF' ) { if ($myvar{'performance_schema'} eq 'OFF') {
}
else {
}
# IF PFS is eanbled
if ( $myvar{'performance_schema'} eq 'OFF' ) {
infoprint "Performance schema is disabled.";
badprint "Performance_schema should be activated."; badprint "Performance_schema should be activated.";
push( @adjvars, "performance_schema=ON" ); push( @adjvars, "performance_schema=ON" );
push( @generalrec, push( @generalrec,
"Performance schema should be activated for better diagnostics" ); "Performance schema should be activated for better diagnostics"
);
} }
if ( $myvar{'performance_schema'} eq 'ON' ) { if ( $myvar{'performance_schema'} eq 'ON' ) {
infoprint "Performance_schema is activated."; infoprint "Performance_schema is activated.";
debugprint "Performance schema is " . $myvar{'performance_schema'}; debugprint "Performance schema is " . $myvar{'performance_schema'};
infoprint "Memory used by P_S: " . hr_bytes( get_pf_memory() ); infoprint "Memory used by P_S: " . hr_bytes( get_pf_memory() );
if ( mysql_version_le( 5, 5 ) ) {
push( @generalrec,
"Performance schema shouldn't be activated for MySQL and MariaDB 5.5 and lower version"
);
push( @adjvars, "performance_schema = OFF disable PFS" );
}
if ( mysql_version_eq( 10, 0 ) ) {
push( @generalrec,
"Performance schema shouldn't be activated for MariaDB 10.0 for performance issue"
);
push( @adjvars, "performance_schema = OFF" );
return;
}
} }
unless ( grep /^sys$/, select_array("SHOW DATABASES") ) { unless ( grep /^sys$/, select_array("SHOW DATABASES") ) {
@ -3858,9 +3836,7 @@ sub mysqsl_pfs {
return; return;
} }
else { infoprint "Sys schema is installed.";
infoprint "Sys schema is installed.";
}
return if ( $opt{pfstat} == 0 or $myvar{'performance_schema'} ne 'ON' ); return if ( $opt{pfstat} == 0 or $myvar{'performance_schema'} ne 'ON' );
infoprint "Sys schema Version: " infoprint "Sys schema Version: "
@ -6873,7 +6849,7 @@ __END__
=head1 NAME =head1 NAME
MySQLTuner 1.9.4 - MySQL High Performance Tuning Script MySQLTuner 1.9.5 - MySQL High Performance Tuning Script
=head1 IMPORTANT USAGE GUIDELINES =head1 IMPORTANT USAGE GUIDELINES