From efc984f945d25e56bf73fa76504be3d2fd56f789 Mon Sep 17 00:00:00 2001 From: Major Hayden Date: Mon, 13 Aug 2007 22:01:28 +0000 Subject: [PATCH] Fixed a dumb logic error with the concurrent_insert check --- mysqltuner.pl | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 63ea2f2..642a679 100644 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -505,12 +505,10 @@ sub mysql_stats { # Performance options if ($mysqlvermajor == 3 || ($mysqlvermajor == 4 && $mysqlverminor == 0)) { push(@generalrec,"Upgrade to MySQL 4.1+ to use concurrent MyISAM inserts"); - } elsif ($myvar{'concurrent_insert'} eq "OFF" || $myvar{'concurrent_insert'} < 1) { - if ($mysqlvermajor == 4) { - push(@generalrec,"Enable concurrent_insert by setting it to 'ON'"); - } else { - push(@generalrec,"Enable concurrent_insert by setting it to 1"); - } + } elsif ($myvar{'concurrent_insert'} eq "OFF") { + push(@generalrec,"Enable concurrent_insert by setting it to 'ON'"); + } elsif ($myvar{'concurrent_insert'} eq 0) { + push(@generalrec,"Enable concurrent_insert by setting it to 1"); } }