From f6f66a49ef012c5f570d9d512b1cea6913b87f7a Mon Sep 17 00:00:00 2001 From: root Date: Fri, 29 Apr 2016 14:25:16 +0200 Subject: [PATCH] #196 comment thread_cache_size recommandations --- mysqltuner.pl | 48 +++++++++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 71cb4ac..e56d6f8 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -2665,31 +2665,29 @@ sub mysql_stats { } # Thread cache - if ( $myvar{'thread_cache_size'} eq 0 ) { - badprint "Thread cache is disabled"; - push( @generalrec, "Set thread_cache_size to 4 as a starting value" ); - push( @adjvars, "thread_cache_size (start at 4)" ); - } - else { - if ( $mycalc{'thread_cache_hit_rate'} <= 50 ) { - badprint - "Thread cache hit rate: $mycalc{'thread_cache_hit_rate'}% (" - . hr_num( $mystat{'Threads_created'} ) - . " created / " - . hr_num( $mystat{'Connections'} ) - . " connections)"; - push( @adjvars, - "thread_cache_size (> $myvar{'thread_cache_size'})" ); - } - else { - goodprint - "Thread cache hit rate: $mycalc{'thread_cache_hit_rate'}% (" - . hr_num( $mystat{'Threads_created'} ) - . " created / " - . hr_num( $mystat{'Connections'} ) - . " connections)"; - } - } + #if ( $myvar{'thread_cache_size'} eq 0 ) { + # badprint "Thread cache is disabled"; + # push( @generalrec, "Set thread_cache_size to 4 as a starting value" ); + # push( @adjvars, "thread_cache_size (start at 4)" ); + #} else { + # if ( $mycalc{'thread_cache_hit_rate'} <= 50 ) { + # badprint + # "Thread cache hit rate: $mycalc{'thread_cache_hit_rate'}% (" + # . hr_num( $mystat{'Threads_created'} ) + # . " created / " + # . hr_num( $mystat{'Connections'} ) + # . " connections)"; + # push( @adjvars, + # "thread_cache_size (> $myvar{'thread_cache_size'})" ); + # } else { + # goodprint + # "Thread cache hit rate: $mycalc{'thread_cache_hit_rate'}% (" + # . hr_num( $mystat{'Threads_created'} ) + # . " created / " + # . hr_num( $mystat{'Connections'} ) + # . " connections)"; + # } + #} # Table cache my $table_cache_var = "";