From 5c307d18130389928310a155a4c23fce8bbc5c9a Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Mon, 1 Feb 2021 11:31:40 +1100 Subject: [PATCH] correct messages on no InnoDB enginestats are only populated if tables exist of that type. Look at default_storage_engine if defined to communicate the default storage engine. closes #469 --- mysqltuner.pl | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 06d8fb3..9523590 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -5557,21 +5557,28 @@ sub mysql_innodb { # InnoDB unless ( defined $myvar{'have_innodb'} - && $myvar{'have_innodb'} eq "YES" - && defined $enginestats{'InnoDB'} ) + && $myvar{'have_innodb'} eq "YES") { - if ( $opt{skipsize} eq 1 ) { - infoprint "Skipped due to --skipsize option"; - return; - } infoprint "InnoDB is disabled."; if ( mysql_version_ge( 5, 5 ) ) { + my $defengine = 'InnoDB'; + $defengine = $myvar{'default_storage_engine'} if defined($myvar{'default_storage_engine'}); badprint -"InnoDB Storage engine is disabled. InnoDB is the default storage engine"; +"InnoDB Storage engine is disabled. $defengine is the default storage engine" if $defengine eq 'InnoDB'; + infoprint +"InnoDB Storage engine is disabled. $defengine is the default storage engine" if $defengine ne 'InnoDB'; } return; } infoprint "InnoDB is enabled."; + if (! defined $enginestats{'InnoDB'} ) { + if ( $opt{skipsize} eq 1 ) { + infoprint "Skipped due to --skipsize option"; + return; + } + badprint "No tables are Innodb"; + $enginestats{'InnoDB'} = 0; + } if ( $opt{buffers} ne 0 ) { infoprint "InnoDB Buffers";