hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #306 from ofigueroa/bugfix_unitialized_value

Browse source 
Resolved issue #304
This commit is contained in:
Jean-Marie Renouard 2017-03-08 07:18:16 +01:00 committed by GitHub
commit f988a23e78
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
mysqltuner.pl
View file

@ -5041,28 +5041,28 @@ group by c.table_schema,c.table_name
having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0" having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0"
); );
if (get_wsrep_option('wsrep_slave_threads') > `nproc`*4 or get_wsrep_option('wsrep_slave_threads') < `nproc`*3) { if ($myvar{'wsrep_slave_threads'} > `nproc` * 4 or $myvar{'wsrep_slave_threads'} < `nproc` * 2) {
badprint "wsrep_slave_threads is not equal to 3 or 4 times number of CPU(s)"; badprint "wsrep_slave_threads is not equal to 2 or 4 times number of CPU(s)";
push @adjvars, "wsrep_slave_threads= Nb of Core CPU * 4"; push @adjvars, "wsrep_slave_threads= Nb of Core CPU * 2";
} else { } else {
goodprint "wsrep_slave_threads is equal to 3 or 4 times number of CPU(s)"; goodprint "wsrep_slave_threads is equal to 2 or 4 times number of CPU(s)";
} }
if (get_wsrep_option('gcs.limit') != get_wsrep_option('wsrep_slave_threads') *5 ) { if (get_wsrep_option('gcs.fc_limit') != $myvar{'wsrep_slave_threads'} * 5 ) {
badprint "gcs.limit should be equal to 5 * wsrep_slave_threads"; badprint "gcs.fc_limit should be equal to 5 * wsrep_slave_threads";
push @adjvars, "gcs.limit= wsrep_slave_threads * 5"; push @adjvars, "gcs.fc_limit= wsrep_slave_threads * 5";
} }
else { else {
goodprint "gcs.limit is equal to 5 * wsrep_slave_threads"; goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads";
} }
if (get_wsrep_option('gcs.fc_factor') == 0.8 ) { if (get_wsrep_option('gcs.fc_factor') == 0.8 ) {
badprint "gcs.fc_factor should be equal to 0.8"; badprint "gcs.fc_factor should be equal to 0.8";
push @adjvars, "gcs.fc_factor=0.8"; push @adjvars, "gcs.fc_factor=0.8";
} }
else { else {
goodprint "gcs.limit is equal to 5 * wsrep_slave_threads"; goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads";
} }
if (get_wsrep_option('wsrep_flow_control_paused') > 0.02) { if ($mystat{'wsrep_flow_control_paused'} > 0.02) {
badprint "Fraction of time node pause flow control > 0.02"; badprint "Fraction of time node pause flow control > 0.02";
} }
else { else {