From 5dd0dec27865372b68396d9398321fd24fc3e005 Mon Sep 17 00:00:00 2001 From: Jean-Marie Renouard Date: Wed, 26 Apr 2023 21:59:52 +0200 Subject: [PATCH 1/4] removing stop at the wrong place --- mysqltuner.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 85be3d2..83fa800 100644 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -3972,8 +3972,8 @@ sub mysqsl_pfs { "select * from sys.$pfs_view" ); } + exit 0 if ( $opt{stop} == 1 ); } - exit 0 if ( $opt{stop} == 1 ); # Top user per connection subheaderprint "Performance schema: Top 5 user per connection"; @@ -6512,7 +6512,6 @@ sub mysql_tables { } exit 0 if ( $opt{stop} == 1 ); } - exit 0 if ( $opt{stop} == 1 ); foreach ( select_user_dbs() ) { my $dbname = $_; next unless defined $_; From ed0de692a803e9d6fdedd646b93d2635f9809dc1 Mon Sep 17 00:00:00 2001 From: Renaud Fortier Date: Mon, 22 May 2023 13:51:56 -0400 Subject: [PATCH 2/4] It should be ne instead of eq --- mysqltuner.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 85be3d2..b730dc8 100644 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -3275,7 +3275,7 @@ sub mysql_stats { push( @adjvars, "skip-name-resolve=0" ); } } - elsif ( $result{'Variables'}{'skip_name_resolve'} eq 'OFF' ) { + elsif ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF' ) { badprint "Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance"; push( @generalrec, From bb10bce371aff8f96bd06e256782105499cd3be5 Mon Sep 17 00:00:00 2001 From: Renaud Fortier Date: Mon, 22 May 2023 13:53:47 -0400 Subject: [PATCH 3/4] Confusion between the name of the variable skip_name_resolve and the recommendations --- mysqltuner.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 85be3d2..c611377 100644 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -3279,9 +3279,9 @@ sub mysql_stats { badprint "Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance"; push( @generalrec, -"Configure your accounts with ip or subnets only, then update your configuration with skip-name-resolve=1" +"Configure your accounts with ip or subnets only, then update your configuration with skip_name_resolve=1" ); - push( @adjvars, "skip-name-resolve=1" ); + push( @adjvars, "skip_name_resolve=1" ); } # Query cache From dabc9d981917fbd410979d97e90ea4cec8dd4295 Mon Sep 17 00:00:00 2001 From: Jean-Marie Renouard Date: Tue, 23 May 2023 05:30:57 +0000 Subject: [PATCH 4/4] Increment version number --- mysqltuner.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 83fa800..218d01a 100644 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -1,5 +1,5 @@ #!/usr/bin/env perl -# mysqltuner.pl - Version 2.1.1 +# mysqltuner.pl - Version 2.1.2 # High Performance MySQL Tuning Script # Copyright (C) 2006-2023 Major Hayden - major@mhtx.net # Copyright (C) 2015-2023 Jean-Marie Renouard - jmrenouard@gmail.com @@ -57,7 +57,7 @@ use Cwd 'abs_path'; #use Env; # Set up a few variables for use in the script -my $tunerversion = "2.1.1"; +my $tunerversion = "2.1.2"; my ( @adjvars, @generalrec ); # Set defaults @@ -6982,7 +6982,7 @@ __END__ =head1 NAME - MySQLTuner 2.1.1 - MySQL High Performance Tuning Script + MySQLTuner 2.1.2 - MySQL High Performance Tuning Script =head1 IMPORTANT USAGE GUIDELINES