hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1608 commits 2 branches 20 tags 34 MiB
Commit graph

825 commits

Author SHA1 Message Date
Daniel Black
79a4403c9c MySQL-5.7/8.0+ auth_socket is safe 
MySQL has auth_socket as its plugin compared to unix_socket on MariaDB
so accept that as a valid reason for having no authentication.

MySQL [(none)]> show create user dan@localhost;
+-----------------------------------------------------------------------------------------------------------------+
| CREATE USER for dan@localhost                                                                                   |
+-----------------------------------------------------------------------------------------------------------------+
| CREATE USER 'dan'@'localhost' IDENTIFIED WITH 'auth_socket' REQUIRE NONE PASSWORD EXPIRE DEFAULT ACCOUNT UNLOCK |
+-----------------------------------------------------------------------------------------------------------------+
1 row in set (0.000 sec)

MySQL [(none)]> select user,host,plugin from mysql.user;
+---------------+-----------+-----------------------+
| user          | host      | plugin                |
+---------------+-----------+-----------------------+
| root          | localhost | mysql_native_password |
| mysql.session | localhost | mysql_native_password |
| mysql.sys     | localhost | mysql_native_password |
| dan           | localhost | auth_socket           |
| expiretest    | %         | mysql_native_password |
| expiretest    | localhost | mysql_native_password |
+---------------+-----------+-----------------------+
6 rows in set (0.001 sec)

MySQL [(none)]> select version();
+-----------+
| version() |
+-----------+
| 5.7.31    |
+-----------+
 2020-12-08 14:18:03 +11:00
Daniel Black
0eef9260a8 mariadb-10.4+ empty passwords 
MariaDB-10.4 migrated their authentication to a global_priv table in JSON
format. Also locked user accounts where added. By default the mariadb.sys
is a locked user without a password and there as the owner of the mysql.user
view. As its hazardous for a user to modify this we exclude locked accounts
but still search for mysql_native_password plugin without authentication.

We use versioned comments to process all other versions. The 5.5+ MySQL
version comment is also read by MariaDB (ref: https://mariadb.com/kb/en/comment-syntax/
enabling the processing of plugins on other version that have plugins.

While this branch doesn't yet apply to MySQL-8.0 yet, we add support
for the locked user accounts in MySQL-8.0+ in a versioned comment
(not read by MariaDB).
 2020-12-08 14:00:39 +11:00
Jean-Marie Renouard
de4b145e96 Remove innodb_buffer_pool_instances recommendations for MariaDB #512 
Remove innodb_buffer_pool_instances recommendations for MariaDB #512
 2020-11-16 20:22:24 +01:00
Jean-Marie Renouard
b5718d0e2f Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2020-11-05 17:29:32 +01:00
Jean-Marie Renouard
cff819d46f Change version number 2020-11-05 17:29:26 +01:00
Jorge Vallecillo
d2a8f0b60a Remove references to the domain mysqltuner.com. #501 2020-09-03 10:17:58 -06:00
Jean-Marie Renouard
b6f8f9f9a3 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2020-05-04 11:02:49 +02:00
Jean-Marie Renouard
00ce968c6a Removing windows end of lines 2020-05-04 11:01:34 +02:00
Jean-Marie Renouard
6038bd7749 Update mysqltuner.pl 
Back to MYsqltuner 1.7.19
 2020-05-03 23:12:19 +02:00
Jean-Marie Renouard
9236ec0f80 Update mysqltuner.pl 
Fix error
 2020-05-03 23:07:42 +02:00
Jean-Marie RENOUARD
1e8b32a253 merged 2020-05-02 16:01:37 +02:00
root
12ae60c6f2 local commit 2020-05-02 15:56:26 +02:00
Kovalkov Dmitrii
e7609d7a91 And for debug line ignore these lines 2020-01-23 16:37:45 +03:00
Kovalkov Dmitrii
dc4aa248c8 Ignore 
200122 12:09:15 mysqld_safe Logging to '/var/log/mysql/error.log'.
when we count errors in log
 2020-01-23 11:24:56 +03:00
Jean-Marie Renouard
7965211fa0
Merge pull request #466 from Ruzgfpegk/bugfix/mariadb-sys-update 
Suggest using mariadb-sys from FromDual in script
 2020-01-09 22:16:39 +01:00
Ruzgfpegk
8ffd81475a
Updates link to MyISAM table_cache scalability doc 
Fixes #465 .
 2020-01-09 15:53:56 +09:00
Ruzgfpegk
3555142ead
Suggest using mariadb-sys from FromDual in script 
Follows #443 and #444.
 2020-01-09 15:04:04 +09:00
jfcoz
c5765f0213 Include max_allowed_packet in thread memory size 
Fix https://github.com/major/MySQLTuner-perl/issues/378
Fix https://github.com/major/MySQLTuner-perl/issues/456
 2019-12-12 13:31:23 +01:00
Jean-Marie Renouard
345bf1ae24 Issue Typo in commit 6f6130b (ymsql => mysql) (#459) 2019-10-17 17:39:45 +02:00
G²
155da8c074 SCALAR ref while strict refs 2019-10-04 12:10:16 +02:00
Jean-Marie Renouard
6f6130b12b Missing password is not recognized #412 2019-10-03 23:15:31 +02:00
Jean-Marie Renouard
851cd817de Update version command #428 2019-10-03 22:33:22 +02:00
Jean-Marie Renouard
66f2ee40be About innodb_log_file_size changing recommendation #408 2019-10-03 22:10:18 +02:00
Jean-Marie Renouard
792b46b03c About innodb_log_file_size changing recommendation #408 2019-10-03 22:06:51 +02:00
Jean-Marie Renouard
6aa887d5a5 Use of uninitialized value $engine in concatenation (.) or string #350 2019-10-03 21:52:30 +02:00
Jean-Marie Renouard
143b80b3a6 Add recommendation on table_definition_cache #433 2019-10-03 21:29:03 +02:00
Jean-Marie Renouard
a421f73e26 Add note about join_buffer_size #434 2019-10-03 21:04:12 +02:00
Jean-Marie Renouard
d1f39e9a00 Script is failing on MySQL 5.6.10(AWS Aurora) #435 2019-10-02 01:13:34 +02:00
Jean-Marie Renouard
f18a3ef33f Update mysqltuner.pl 
FAIL Execute SQL / return code: 256 #442
disable column type to ENUM suggestion #356
 2019-10-02 00:44:54 +02:00
Jean-Marie Renouard
a9bed2ffa0 Percona Server 8.0 - better support 
Lot of bug fixes for percona.
 2019-10-02 00:07:46 +02:00
Jean-Marie Renouard
b8f191d180 Update error log file analysis 2019-09-26 00:41:10 +02:00
Jean-Marie Renouard
7332f8d5c4 Wrong report of InnoDB Storage engine status #450 
Good message is
-------- InnoDB Metrics ----------------------------------------------------------------------------
[--] Skipped due to --skipsize option
 2019-09-25 23:50:15 +02:00
Jean-Marie Renouard
ebc6619e4f Bug fix #453 2019-09-25 23:29:22 +02:00
Jean-Marie Renouard
60df6043b1 Update Vulnerabilities list 
Indenting mysqltuner
Update Usage information
 2019-09-25 20:05:45 +00:00
Billy Noah
066acb0940
Update mysqltuner.pl 
Check to make sure mysql.user has a column called 'password'.  Adjust security_recommendations queries accordingly.

This should address issues:
https://github.com/major/MySQLTuner-perl/issues/427
https://github.com/major/MySQLTuner-perl/issues/441
https://github.com/major/MySQLTuner-perl/issues/442
 2019-09-10 16:06:58 -04:00
Eduardo Broto
ece5671292 Escape identifiers in table column metrics 
Otherwise some queries may fail if reserved words were used as field, table or
database names.
 2019-07-10 17:25:23 +02:00
Myrdhin
b10c90ccf8 Fix typo on myvar 2019-05-15 11:01:46 +02:00
Myrdhin
49a1b603da Fix error when innodb_stats_on_metadata not defined 2019-05-15 10:52:51 +02:00
Jean-Marie Renouard
4a01df4a04
Merge pull request #431 from atombrella/should_be 
Corrected grammar for innodb_buffer_pool_size recommendation.
 2019-03-22 10:20:32 +01:00
Mads Jensen
320e1fda8e Changed http to https. Fixed broken link to original script. 2019-03-22 07:32:47 +01:00
Mads Jensen
0fae7c5a91 Corrected grammar for innodb_buffer_pool_size recommendation. 2019-03-22 07:23:08 +01:00
Jean-Marie Renouard
fce4eda2aa Illegal division by zero #423 2019-03-06 13:28:28 +00:00
Jean-Marie Renouard
4c14ba9718 Missing password is not recognized #412 2019-03-06 13:10:17 +00:00
Tim Hughes
69d4e2fbea A bit of work on the html report template 2018-11-30 13:06:49 +00:00
Jean-Marie Renouard
d7c906c9c4 Uncaught exception from user code (#414) 2018-11-26 15:25:54 +00:00
Jean-Marie Renouard
177c9f6695 ignore galera check when wsrep_on = 0 #353 2018-11-26 13:41:36 +00:00
Jean-Marie Renouard
87eb96a485 Sys schema on MariaDB #362 2018-11-26 13:31:59 +00:00
Jean-Marie Renouard
1b9e4e75ba Last modification related to options 2018-11-26 12:57:11 +00:00
tcraxs
c0b2f67a2f
fix defect link to mysql documentation - #408 
Fix defect link to the mysql documentation. Choose to set the link to version 8 as in Issue major#408 mention.
Links to: https://dev.mysql.com/doc/refman/8.0/en/innodb-redo-log.html
 2018-11-14 16:54:05 +01:00
Jean-Marie Renouard
c8fb973bf8 MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386 2018-09-26 09:10:09 +00:00
Jean-Marie Renouard
dab1e7e960 MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386 2018-09-26 07:31:19 +00:00
Jean-Marie Renouard
b8224beb85 bug fix in calcualation of wsrep_slave_threads value #305 2018-09-26 07:25:58 +00:00
Jean-Marie Renouard
c8bb7050ab wsrep_slave_threads info and test modification 2018-09-25 17:19:19 +02:00
Jean-Marie Renouard
6081df99a9 Wrong warning about table_open_cache #364 2018-09-25 17:05:43 +02:00
Jean-Marie Renouard
580a707ef7 wsrep_slave_threads #305 2018-09-25 16:58:36 +02:00
Jean-Marie Renouard
469a205ac0 Uptime info" 2018-09-23 19:48:09 +00:00
Jean-Marie Renouard
be4c965ea9 adding better json outputfile option 2018-09-23 18:19:06 +00:00
Jean-Marie Renouard
79d91e5b07 Template staff 2018-09-23 09:50:33 +00:00
Jean-Marie Renouard
b8ef183bcf Hope to add MySQL 8 support! #377 
MySQL 8: disabling Query cache recommandations
MySQL 8: check password disabled due to new authentication storage model - Help wanted
 2018-09-23 07:45:25 +00:00
Jean-Marie Renouard
5d4e891ea1 ignore galera check when wsrep_on = 0 #353 2018-09-20 14:34:07 +00:00
Jean-Marie Renouard
08cb34587b Fixing important performance issue during collecting metrics 2018-09-20 13:11:34 +00:00
Jean-Marie Renouard
e76f3a25b1 New option tbstat 2018-09-20 12:51:07 +00:00
Jean-Marie RENOUARD
4951c920c5 Incorrectly assumes 32bit architecture on s390x systems #390 2018-08-07 15:52:14 +02:00
Jean-Marie RENOUARD
dc86f73d1b wsrep_slave_threads #305 2018-08-07 09:00:21 +02:00
Jean-Marie RENOUARD
2bd7e7bf71 wsrep_slave_threads #305 2018-08-06 14:53:12 +02:00
Jean-Marie RENOUARD
7429b7c15c Minor accessing undefined variable bug to fix eventually #383 2018-08-06 12:38:06 +02:00
Jean-Marie RENOUARD
e7980611a1 # 393 Peak and max memory usage estimated incorrectly 2018-08-06 11:53:02 +02:00
Maxximou5
ad74a7dc6d Spelling and grammar 
- Fixed: Minor spelling, grammar, and accidental return
 2018-07-28 16:50:06 -07:00
Kovalkov Dmitrii
d02feeedc8
Minor fix undefined value 2018-07-26 23:00:04 +03:00
Kovalkov Dmitrii
010656345d
Switch human readable for Data (not need round) 2018-07-05 17:48:45 +03:00
Jean-Marie RENOUARD
a43032b863 #377 adding 0 as query cache efficiency for MySQL 8 2018-06-29 14:06:42 +02:00
Jean-Marie RENOUARD
9cf4dd4453 Ticket #383 Minor accessing undefined variable bug to fix eventually 2018-06-29 12:16:30 +02:00
Martin Kiesel
9a1d331ebb
End sentence with a period 
Fixed example output:

```
[!!] User 'a@localhost' has user name as password.
[!!] User 'b@%' does not specify hostname restrictions.
```
 2018-06-05 14:12:54 +02:00
Artem S. Tashkinov
593928c646
Some fixes 2018-05-27 14:03:29 +00:00
Drew Schatt
e46309a09f Spelling fixes. 
Physical
theoretically
MariaDB
 2018-05-21 16:10:22 -07:00
Jean-Marie RENOUARD
1b68fd55a3 Update staff 2018-04-26 14:15:59 +02:00
Jean-Marie RENOUARD
61cdd6c0d0 Trim sub with emtpy string display error #376 2018-04-04 15:20:27 +02:00
Jean-Marie RENOUARD
b9721ef91b MySQL enterprise: Column recommandations #375 2018-04-04 15:17:57 +02:00
Jean-Marie RENOUARD
9cf48b52e0 Clean up staff 2018-03-30 15:44:40 +02:00
Jean-Marie Renouard
7ae81143b9 Removing error from Use of uninitialized value $engine in concatenation (.) or string #350 2018-03-27 12:33:31 +00:00
Jean-Marie RENOUARD
3551d0d28e Avoid use of uninitialized value 2018-03-20 08:53:15 +01:00
Jean-Marie RENOUARD
de1bd2015e update staff 2018-03-19 17:17:11 +01:00
Jean-Marie RENOUARD
031f741296 Some information about replication 2018-03-19 17:08:12 +01:00
Jean-Marie RENOUARD
ff2a47e461 Issue #373 Fix for password column on MySQL 5.7 2018-03-19 16:34:41 +01:00
Jean-Marie RENOUARD
f0394b67cc Issue #373 Fix for password column on MySQL 5.7 2018-03-19 16:33:04 +01:00
Jean-Marie RENOUARD
bca1ad849d Change year reference 2018-02-23 16:42:24 +01:00
Jean-Marie RENOUARD
760adf20b5 Latest version has a regression with colored outout #371 2018-02-23 12:34:32 +01:00
Jean-Marie RENOUARD
94f8dad080 Wrong sort order in MySQLTuner report #363 2018-02-22 18:42:32 +01:00
Jean-Marie RENOUARD
35c4200813 Issue #364 2018-02-22 16:58:59 +01:00
Jean-Marie RENOUARD
0e8fcbf52d Issue #369 2018-02-22 16:11:42 +01:00
Jean-Marie RENOUARD
8fda1dc284 Issue #371 2018-02-22 15:35:31 +01:00
Jean-Marie RENOUARD
6d95d8642c Update code, doc and vulnerabilities 2018-02-22 15:29:33 +01:00
Jean-Marie RENOUARD
86b0a1949f Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2018-02-22 15:24:32 +01:00
Jean-Marie RENOUARD
50f3a0d965 Small quotes issue 2018-02-22 15:24:20 +01:00
Jean-Marie Renouard
75f4bc623a
Merge pull request #370 from jsoref/spelling 
Spelling
 2018-02-22 15:22:30 +01:00
Jean-Marie Renouard
5b2918296f
Merge pull request #367 from martinellimarco/master 
Proposed fix for #268
 2018-02-22 15:21:01 +01:00
Jean-Marie RENOUARD
13c885a529 Issue #372 2018-02-22 15:18:39 +01:00
Josh Soref
3b76498260 spelling: release 2018-02-18 04:59:50 +00:00
Josh Soref
878de6b7e1 spelling: recommendations 2018-02-18 04:59:38 +00:00
Josh Soref
d714eb9a57 spelling: efficiency 2018-02-18 04:44:13 +00:00
Josh Soref
89027cebe1 spelling: deactivated 2018-02-18 04:43:14 +00:00
Josh Soref
940c25c355 spelling: authentication 2018-02-18 04:41:14 +00:00
Marco Martinelli
06f20b1fbb Proposed fix for #268 2018-02-14 22:40:14 +01:00
Marco Martinelli
9f7a599195 Proposed fix for #268 2018-01-18 07:39:52 +01:00
Jean-Marie RENOUARD
073a6244a5 Update git ignorewq 2018-01-10 15:14:19 +01:00
Jean-Marie Renouard
f530ee787d
Update mysqltuner.pl 2017-12-20 09:33:54 +01:00
Mark Hyde
53cdb0e0b9 Ignore password check for auth_pam_compat plugin 
- Users authenticating via auth_pam_compat will use pam for
authentication rather than the mysql password field, so the latter is
expected to be empty.
 2017-11-28 13:11:39 +00:00
Wesley Schaft
60660c7d54 Changed gcs.limit to gcs.fc_limit, as there's no gcs.limit parameter. 2017-11-16 09:13:40 +01:00
Thomas Meyer
45c48832c4 Read log file by line 
Changes the log file reading from loading the entire file into
memory to reading line by line.
 2017-10-05 17:05:20 -07:00
Thomas Meyer
c45ac0925d Determine real log_error path. 
Determines real log_error path if mysql variable not set or file
is relative and does not exist in current working directory.
Otherwise return back original value.
 2017-09-24 05:45:13 -07:00
Daniel Kolvik
2b7828237d Add support to pass ssl public key to mysql connection. Makes it possible to run against servers only accepting connection over SSL. 2017-09-15 10:53:57 +02:00
Peter 'Pessoft' Kolínek
b5d1650f59 add general recommendation for innodb log file changes 
add information to INTERNALS.md about innodb log file to buffer pool ratio
fix buffer pool typos in comments
fix code formatting a bit
 2017-09-09 13:22:30 +02:00
Jean-Marie RENOUARD
17fddf2079 Issue #341 debian credentials not overridable from commandline 2017-08-25 11:12:10 +02:00
Jean-Marie RENOUARD
3c3fdcd936 Performance Schema Issue #328 2017-07-31 14:27:15 +02:00
Jean-Marie RENOUARD
d5c4ae85f8 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2017-07-24 15:12:49 +02:00
Jean-Marie RENOUARD
d82ea42215 Issue Performance Schema Issue #328 2017-07-24 15:12:36 +02:00
Peter 'Pessoft' Kolínek
8d4c50cc2c Fixes calculation and display of ratio between InnoDB log files size and InnoDB buffer pool size 2017-07-11 21:41:09 +02:00
kostya v
52fb453f27 Read the value of wsrep_slave_threads from the right place. 2017-07-10 16:57:15 +03:00
Jean-Marie RENOUARD
77bcb72702 Update vulnerabilities list 2017-07-05 11:51:33 +02:00
Jean-Marie Renouard
b16dfb6254 Merge pull request #330 from vladisalv/master 
fixing documentation
 2017-06-19 11:37:07 +02:00
Andrew Daugherity
9b2fcd85f0 fix micro version comparison 
Both the minor *and* the major versions need to match before checking
the micro version.
 2017-06-16 16:25:44 -05:00
Vladislav Toigildin
84c1bbafae refactoring: pod documentation 2017-06-15 21:57:07 +03:00
Vladislav Toigildin
1aec239039 output help message using pod2usage instead duplicating pod documentation in usage() function 2017-06-15 21:52:14 +03:00
Vladislav Toigildin
cb0acfe319 fix: add newlines before pod command paragraph + newline before __END__ 2017-06-15 20:53:20 +03:00
Askar Timirgazin
821de219db Fix for messages about defragmented tables 
Schema name must be divided from table name, now both of them joined, so you can't copy-paste recomendations to mysql console.
Was:  OPTIMIZE TABLE `test_db.test_table`; -- can free xx MB
Must: OPTIMIZE TABLE `test_db`.`test_table`; -- can free xx MB
 2017-05-23 17:26:20 +03:00
Jean-Marie RENOUARD
8d178444d5 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2017-05-19 09:36:43 +02:00
Jean-Marie RENOUARD
5fce4fc0ee Adding a note for XtraDB 2017-05-19 09:36:33 +02:00
root
29fb53694e Support column analysis with produre analyse 2017-05-19 02:06:36 +02:00
Jean-Marie RENOUARD
21860fe395 Incorrect suggestion for ratio InnoDB log file size / InnoDB buffer pool size #322 2017-05-17 17:38:17 +02:00
Jean-Marie RENOUARD
f180eae082 Missing argument requirement for cvefile in mysqltuner help #321 
Schedule for releases on github #320
 2017-05-17 16:50:44 +02:00
Tim Stoop
dbe7ac8818 Fix typos in Index metrics 2017-04-24 22:53:08 +02:00
Jean-Marie Renouard
dda90d669c Default host should be 127.0.0.1 #312 2017-04-21 00:33:20 +02:00
root
dc7ffb01dc bug fix on swappinness to 10 for Galera 2017-04-21 00:19:55 +02:00
root
21af94158d Add quotes #311 
Use https instead of http #317
typo, space missing before is #315
 2017-04-21 00:13:45 +02:00
謝致邦 (XIE Zhibang)
f4a108c2f6 Disable query cache. 2017-04-19 21:25:45 +08:00
謝致邦 (XIE Zhibang)
2f3832b6f7 The query cache should be disabled in MariaDB 10.1 2017-04-19 20:01:02 +08:00
RENOUARD Jean Marie Ext IMT/OINIS
5cc86c82b5 bad calculation for pct_wkeys_from_mem #303 2017-03-14 18:26:44 +01:00
RENOUARD Jean Marie Ext IMT/OINIS
2e45139751 Merge 2017-03-14 18:23:23 +01:00
RENOUARD Jean Marie Ext IMT/OINIS
596918c3c3 Version 1.7.1 2017-03-14 18:21:19 +01:00
Christoph Hansen
b7e1a99240 Check whether hyperthreading is enabled or not. 
Since calculating the recommended value for "wsrep_slave_threads" using the number of physical cores is best practice for Intel CPUs where hyperthreading is activated.
 2017-03-13 17:22:05 +01:00
root
e44c29bf23 MErge beetween all staff related to Galera Cluster 2017-03-08 19:18:47 +01:00
Jean-Marie Renouard
9651818d77 Merge branch 'master' into master 2017-03-08 18:55:01 +01:00
Oscar A. Figueroa
24b901363c Bugfix resolve #308 : gcs.fc_factor parameter evaluation and the message report, which referencing wsrep_slave_threads instead. 2017-03-08 11:50:02 +01:00
jfcoz
f61cbce4f8 add checks for wsrep_slave_FK_check and innodb_autoinc_lock_mode when wsrep_slave_threads > 1 2017-03-07 17:53:36 +01:00
Oscar A. Figueroa
adb33d3c37 Resolved issue #304 2017-03-07 12:48:43 +01:00
root
f04b32c854 Use of uninitialized value #304 
tidify script
 2017-03-06 15:17:43 +01:00
root
48be29a288 issue #300 Performance schema shouldn t be installed on 5.5 version. 2017-02-14 09:40:52 +01:00
root
59238301bf Adding new indicators for Galera Cluster' 2017-02-13 18:08:28 +01:00
Greg Kennedy
02f13fcb52 Do not test skip_name_resolve if skip_networking is ON 
MySQL name resolution only applies to TCP/IP connections ( see lines 504 and 599 of mysql-server/sql/sql_connect.cc ).  Thus there is no reason to test, or suggest, setting skip_name_resolve if skip_networking exists and is turned on.
 2017-02-08 11:10:48 -06:00
Jean-Marie RENOUARD
871d984d1a Add advice for performance schema 2017-02-07 06:56:17 +01:00
Jean-Marie RENOUARD
490da41bcd Adding #289 adding warning info 
#271 adding message prescision for in advces message
 2017-02-06 22:34:08 +01:00
Bruno Perel
97d1ea347f Fix typo 2017-01-27 15:57:57 +01:00
root
67e78592da #285 Argument "xxxM" isn t numeric in numeric ge (>=) 2017-01-23 17:32:47 +01:00
root
def15c2f8f Adding recommandations for Galera 2017-01-13 12:23:05 +01:00
git001
e454b30c61 Fix Argument "NULL" isn't numeric 
Argument "NULL" isn't numeric in numeric ge (>=) at ./mysqltuner.pl line 305 (#1)
    (W numeric) The indicated string was fed as an argument to an operator
    that expected a numeric value instead.  If you're fortunate the message
    will identify which operator was so unfortunate.
 2016-12-28 10:52:33 +01:00
Sergei A Mamonov
bb6b7ca623 Disable zero prototypes in few functions 2016-12-27 13:16:17 +03:00
i5513
be1f4b48c4 Allow to connect via socket with not default port 
Seems like it is necessary to specify the port when you have 2 instances runing and you want to connect via socket.
 2016-12-20 10:35:41 +01:00
Sergei A Mamonov
1b04540a4c fix check innodb_file_per_table with skip-innodb 2016-12-12 14:19:49 +03:00
root
7f02c8655c Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-12-08 11:29:59 +01:00
root
22709a4517 #265 wrong table name 2016-12-08 11:29:50 +01:00
jfcoz
2dfb2a2cc9 query cache hit rate was not calculated when badprint "Query cache may be disabled by default due to mutex contention" 2016-12-08 09:45:38 +01:00
Sergei A Mamonov
4bc3a50c2d fix code style in log_file_recommandations 2016-12-07 16:31:51 +03:00
Sergei A Mamonov
d3ea7ea342 fix error on show last start/shutdowns 2016-12-07 16:23:53 +03:00
root
2861883432 Perl Error #280 2016-12-05 09:31:03 +01:00
root
4d20ffea0c Doesn't work for remote server on AWS #279 2016-12-05 09:27:54 +01:00
root
7a0565d9e5 Detect Error and warning in error log #252 
Detect last MySQL / MariaDB last shutdown and startup #253
 2016-12-02 16:21:58 +01:00
root
7acf66f73c Bug on log file calculation 2016-12-02 15:27:38 +01:00
root
f7699b4515 #278 Escaping password items 2016-12-02 15:24:52 +01:00
git001
caa785ec59 Fix Argument "NULL" isn't numeric 
Argument "NULL" isn't numeric in numeric ge (>=) at mysqltuner.pl line 288 (#1)
    (W numeric) The indicated string was fed as an argument to an operator
    that expected a numeric value instead.  If you're fortunate the message
    will identify which operator was so unfortunate.
[--]  +-- ROWS : 0
Argument "NULL" isn't numeric in numeric eq (==) at mysqltuner.pl line 343 (#1)
    (W numeric) The indicated string was fed as an argument to an operator
    that expected a numeric value instead.  If you're fortunate the message
    will identify which operator was so unfortunate.
[--]  +-- ENGIN : 0 (NULL)
Argument "NULL" isn't numeric in numeric lt (<) at mysqltuner.pl line 3847 (#1)
 2016-11-28 20:39:47 +01:00
root
ce7eefb3da Bug fix on Galera Gcache mem calculation 2016-11-28 17:51:46 +01:00
root
5be96339a1 Incorrect innodb log file size calculation #271 2016-11-28 17:48:22 +01:00
root
eac905b632 MariaDB GTID mode #272 2016-11-28 17:39:41 +01:00
Artur Penttinen
5a6742ee85 Hiding username and password from commandline 
It is possible to spy username and password if command run
with --user/-pass options (ps -C mysqltuner.pl -F).
To hiding these added options --userenv/--passenv for
transfer MySQL username and password via environment
variables.
 2016-11-16 11:05:33 +02:00
Michael R Mawhinney Jr
947856901a Minor spelling correction 2016-11-09 22:29:34 -05:00
root
e6b57a84d3 New indicators from performance schema 2016-11-03 10:36:59 +01:00
root
5872fcc1ee #265 TOP 15 queries with temp table to disk 
#260 Memory used > 100% ?
#258
 2016-11-02 21:16:54 +01:00
root
6b9920902b Last modifications 2016-11-02 20:02:41 +01:00
Jean-Marie Renouard
51ea5925d1 Merge pull request #263 from henriquemoody/patch-1 
Use single quotes around password
 2016-10-27 21:17:13 +02:00
Henrique Moody
5a3873ece4 Use single quotes around password 
Password may contain characters, like `$` and `!`, that may be interpreted by
the shell. Prevent it to happen by using single quotes.
 2016-10-27 15:28:41 +02:00
Karl Chen
05c1e6eb75 Non importance changes 2016-10-24 17:25:07 +08:00
Karl Chen
f68b731498 Non importance changes 2016-10-24 17:21:56 +08:00
Karl Chen
4f1a6ec38b Non importance changes 2016-10-24 07:36:05 +08:00
Karl Chen
f4e46cdbc0 Non importance changes 2016-10-24 07:34:19 +08:00
Karl Chen
915be0fbe4 Non importance changes 2016-10-24 00:38:32 +08:00
Karl Chen
301e5f2291 Non importance changes 2016-10-24 00:32:48 +08:00
Karl Chen
7b3f2ce9a9 Something wrong to print 2016-10-23 13:42:01 +08:00
root
6a70adebd3 Full support performance schema 
Update vulnerability list
Updade INTERNALS doc.
 2016-10-18 14:55:13 +02:00
root
bbc04d848f #258 new rule for innodb log file size (25% of Buffer pool size) 2016-10-18 14:25:02 +02:00
root
cff9e62933 Adding new indicators from sys schema 2016-10-17 17:04:10 +02:00
root
c10c7e81ec Redundant indexes" 2016-10-10 19:03:40 +02:00
root
e684a45120 * TOP 15 most read tables 
* TOP 15 most modified tables
* TOP 15 high select latency tables
* TOP 15 high insert latency tables
* TOP 15 high update latency tables
* TOP 15 high delete latency tables
 2016-10-10 18:39:56 +02:00
root
101c13baed Typo fix 2016-10-10 18:18:26 +02:00
root
f826adecf2 * TOP 15 most read indexes 
* TOP 15 most modified indexes
* TOP 15 higth select latency index
* TOP 15 higth insert latency index
* TOP 15 higth update latency index
* TOP 15 higth delete latency index
 2016-10-10 18:14:52 +02:00
root
ad9228d029 * Event per wait total latency 
* Event per wait read latency
* Event per wait write latency
 2016-10-10 16:54:45 +02:00
root
16f0d5d9ff Adding * Event Wait by read bytes 
* Event Wait by write bytes
 2016-10-10 16:00:15 +02:00
root
7b46762a1a Adding pfs indicators related to File IO 2016-10-10 15:34:29 +02:00
root
50ece21b2d New indicators from performance schema 
On the road to 1.7.x version
 2016-10-06 10:44:58 +02:00
root
30616932d7 Adding Performance stat per user 2016-09-27 16:07:26 +02:00
root
20b9fa2a19 Included a lot of new indicators for PFS when using --pfstat or --verbose option 2016-09-26 18:32:35 +02:00
root
8263cbda27 Update doc 2016-09-26 16:00:20 +02:00
root
243c54eaa0 Adding --defaults-file to change credentials storage 2016-09-26 15:53:32 +02:00
root
972bf2e4ae #193 adding some useful extraction for sysschema 2016-09-19 16:13:22 +02:00
root
2b6a0c3522 Adding Comment with sys request 2016-09-12 16:43:20 +02:00
root
33dfabd940 #237 removing ? more info ? 2016-09-12 14:18:14 +02:00
Rowan Wookey
9f777ed47b Fixed #245 error when checking for passwordless accounts on MySQL < 5.5 2016-09-03 15:11:09 +01:00
root
401cb549e8 Removing warnings for SQL request 2016-08-31 13:48:01 +02:00
root
a067eddb20 Tidyfy code 2016-08-31 10:30:20 +02:00
root
746f5d3a4d Changing version in test for displaying false positive CVE messages 2016-08-31 10:26:39 +02:00
root
94c56dad3f False CVE detection for mysql 5.50 #235 adding info message 2016-08-31 09:17:03 +02:00
root
3820a528ed Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-08-31 09:05:35 +02:00
root
6bcd5ae0ce Update vulnerabilies list 
InnoDB buffer pool alignment check appears backward #244
 2016-08-31 09:04:48 +02:00
Christian Loos
0cd7e93685 fix "Don't modify $_ in list functions" 2016-08-30 18:26:08 +02:00
Christian Loos
600aad227d get_file_contents calls already remove_cr 2016-08-30 18:26:08 +02:00
Christian Loos
1c13c66e36 improve message if JSON isn't installed 2016-08-30 18:26:08 +02:00
Christian Loos
7215e419df fix 'Expression form of "eval"' 2016-08-30 18:26:08 +02:00
Christian Loos
90e8251523 fix 'Bareword file handle opened' 2016-08-30 18:26:08 +02:00
Christian Loos
f3e3b39023 fix 'Nested named subroutine' 2016-08-30 18:26:08 +02:00
root
a7062ad804 #196 misplaced semi column 2016-08-30 17:03:21 +02:00
root
3f19d63833 #242 adjust test for unitialized value 2016-08-30 14:57:09 +02:00
root
1b068ed7e4 #242 adjust test for unitialized value 2016-08-30 14:56:59 +02:00
root
b94d3bd927 #196 correct variable name 
increment version number
 2016-08-30 14:48:48 +02:00
root
aa1df95ff3 #155 adding test for consistent values for innodb_buffer_pool_size,innodb_buffer_pool_chunk_size and innodb_buffer_pool_instances 2016-08-30 14:38:16 +02:00
root
7554f10e52 #196 better thread cache hit rate with pools-of-threads 2016-08-30 13:45:46 +02:00
root
8f33b55fea #242 initiliaze $data_free to 0 if not defined or is empty 2016-08-30 13:34:52 +02:00
root
dbbe785e01 #231 #235 bug fix regarding way CVE are selected. 2016-08-29 17:10:26 +02:00
root
736fc24c47 increment version 2016-08-26 11:02:15 +02:00
root
11ccfccc1c #235 #231 review way to select version 
bug fix in calculate greater and lower version
 2016-08-26 10:40:58 +02:00
root
8e8345dac3 Update vulnerabilities list 
issue #237: Test skip_name_resolve is set before using it
Adding information message  when skip_name_resolve is missing
 2016-08-25 16:33:58 +02:00
Peter 'Pessoft' Kolínek
70455de4ba Fix SQL string concatenation in capitalization during password test 2016-08-24 00:21:18 +02:00
root
ef1f96625a #231 change label for CVE reports 2016-08-10 13:40:58 +02:00
root
24f1c722d3 Don t display advice for tcp slot if /proc/sys/sunrpc file doesn t exist #230 2016-08-10 11:48:41 +02:00
root
2aac89e89c Don t display advice for tcp slot if /proc/sys/sunrpc file doesn t exist #30 2016-08-10 11:47:36 +02:00
root
6300c3a2c7 Adjust request for table without primary key #229 2016-08-10 11:44:22 +02:00
root
97587f6d2f Adding a lot of things in JSON structure 2016-08-09 16:04:13 +02:00
root
b3005038d3 Removing some warnings and errors messages when sysctl doesnt get any value 2016-08-09 13:38:47 +02:00
root
da1819d66b Bug fix for exec fail 2016-08-09 10:15:49 +02:00
root
b42b97f96f #227 Stopping MySQL tuner when SELECT VERSION doesnt return any value. This indicates that user doent get enough privileges 2016-08-08 17:40:53 +02:00
Grzegorz Adam Kowalski
a9f9e69201 Don't exit after positive latest version check 2016-07-13 12:58:30 +02:00
root
51993aa2c8 wsrep_osu_method error #224 2016-07-04 08:41:16 +02:00
root
5af540cab0 #223 removing version estension for Ubuntu version - V2 2016-06-23 21:30:22 +02:00
root
4ea5c09d44 #223 removing version estension for Ubuntu version 2016-06-23 21:28:26 +02:00
root
0b8dfd9f66 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-06-16 11:07:38 +02:00
root
638e843d49 Removing strange code blocks :) 2016-06-16 11:07:32 +02:00
Louis Sautier
e450074254
Reword a message 2016-06-16 10:33:03 +02:00
mhasbini
d148093634 no need to return, just exit 2016-06-11 16:36:59 +00:00
mhasbini
2db1483123 switch version check with mysql_setup 2016-06-11 16:19:55 +00:00
root
cf75be4c84 Tokudb detection fix #218 2016-06-10 10:27:55 +02:00
root
16c94a51ba uninitialized value in script #218 2016-06-10 10:24:40 +02:00
root
0b534333b2 Update vulnerabilities list 
Update mysql tuner version
Update internals documentation
 2016-06-10 10:18:21 +02:00
Kevin Houdebert
b479d9aede Fix typo for OPTIMIZE 2016-06-03 15:54:52 +02:00
root
5bcddc77b8 #213 changing badprint to print in order to display error message when JSON module is not loaded 2016-06-03 11:03:52 +02:00
jfcoz
b0848e5cc5 add skip-name-resolve recommandation 2016-06-03 08:33:02 +02:00
jfcoz
2a8cf5fea6 add innodb when innodb_file_per_table is ON 
display OPTIMIZE requests for tables of more than 100mb with more thant 10% fragmentation

    Run OPTIMIZE TABLE to defragment tables for better performance
      OPTIMZE TABLE testdb.price; -- can free 496 MB
      OPTIMZE TABLE testdb.mail; -- can free 5704 MB
      OPTIMZE TABLE testdb.basket; -- can free 20 MB
    Total freed space after theses OPTIMIZE TABLE : 6220 Mb
 2016-06-02 09:40:42 +02:00
Jean-Marie Renouard
7dabf27c91 Merge pull request #210 from smutel/patch-3 
Avoid deprecated message from perl
 2016-05-20 00:32:24 +02:00
smutel
e14ddff904 Avoid deprecated message from perl 
Use of implicit split to @_ is deprecated at /tmp/mysqltuner.pl line 3243 (#1)
    (D deprecated, W syntax) It makes a lot of work for the compiler when you
    clobber a subroutine's argument list, so it's better if you assign the results
    of a split() explicitly to an array (or list).
 2016-05-19 17:10:48 +02:00
smutel
1048038e64 Avoid bad syntax error message 
Error below when executing the script on RHEL6/OL6:
Warning: bad syntax, perhaps a bogus '-'? See /usr/share/doc/procps-3.2.8/FAQ
 2016-05-19 17:06:12 +02:00
smutel
b2aea7f69d Update mysqltuner.pl 2016-05-19 13:47:46 +02:00
smutel
8e9cc50311 Exclude innodb engine from fragmented tables 2016-05-19 13:44:50 +02:00
Ian Gregory
7c1d5521ed Improve portability when fetching process memory - use ps rather than the proc filesystem 2016-05-10 10:34:30 +01:00
root
a7cd64a4c7 Increment version number 2016-05-09 10:17:14 +02:00
root
959a41b708 #204 updater works fine with curl now 2016-05-04 17:44:05 +02:00
root
f6f66a49ef #196 comment thread_cache_size recommandations 2016-04-29 14:25:16 +02:00
root
bead8a77ef Adding this message for <=5.1 version 
No more password checks for MySQL version <=5.1
MySQL version <=5.1 are deprecated and end of support.
 2016-04-29 14:19:46 +02:00
root
2e2d945e63 Fix #190 changing typo for recommandations on multiprocessor 2016-04-29 14:01:15 +02:00
root
1727a42b29 Fix #195 single quote enclosed password 2016-04-29 13:46:52 +02:00
jkavalik
92dc77e4cd Fix for #197 
Merge GLOBAL status after SESSION - the non-global variables (like Percona from #184) will be present but stats are computed from GLOBAL counters which overwrite the SESSION ones if they exist.
 2016-04-29 12:56:24 +02:00
Vadym Chepkov
ae0ab4bcff fixed wsrep_cluster_size handling 
garbd node can be configured in galera cluster. wsrep_cluster_size includes the garbd node, but it is not listed in wsrep_cluster_address, since it does not participate in the replication.
 2016-04-27 06:42:50 -04:00
Vadym Chepkov
7251a85234 fixed spelling 2016-04-22 11:26:00 -04:00
root
9b3549a92c #184 minor fix xtrabackup is the good alternative 2016-04-21 23:19:36 +02:00
root
c59a852a03 minor addition for sys schema #193 2016-04-21 23:16:35 +02:00
root
560b45894b #184 minor fix due to error message 2016-04-21 09:08:20 +02:00
root
737628dd1b Vulnerabilities list updated 
#190 Query cache must be activated in MariaDB 10.1
#184 bug fix on messages
#184 xtrabackup support when wsrep_sst_method is starting by xtrabackup
 2016-04-21 09:06:13 +02:00
root
fa1639e418 Tidify code 2016-04-19 16:19:31 +02:00
root
5b55c92ac5 #184: Additional information for galera 
Removing dependency to Env module #192
 2016-04-19 16:11:35 +02:00
root
a8babd7e69 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-04-19 16:04:13 +02:00
root
b67bba859f adding extra information about wsrep cluster size #184 2016-04-19 16:03:42 +02:00
Sergei A Mamonov
bc2017ba3e change external which to sub which(), little fix for use get_http_cli and get external ip via wget 2016-04-18 17:45:34 +03:00
root
80def03923 #187 enforce control over P_S activation 2016-04-18 11:07:05 +02:00
root
86ad610b6c #189 fix memory calculation when Galera is disabled 2016-04-18 10:59:50 +02:00
Jean-Marie RENOUARD
612eea48fd All version for galera checks #150 2016-04-15 10:17:56 -04:00
Jean-Marie RENOUARD
76a28ab29a Adding typo fixes 
Adding check for memory with other process
 2016-04-15 06:33:05 -04:00
Jean-Marie RENOUARD
e4a2534349 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-04-15 05:16:06 -04:00
root
66a57af80b #182 using abs value for result 2016-04-14 23:11:18 +02:00
root
ba584c91cc Update version #183 2016-04-14 22:49:21 +02:00
root
0ffe9507b6 #187 #183 removing unitialized variables code 
#184 adding merge between show global variables and show global variables
#184 update RPM template'
 2016-04-14 22:42:59 +02:00
Ricardo Velhote
eea101019e Detect Ubuntu correctly when checking for OS Release 2016-04-13 14:39:40 +01:00
Jean-Marie RENOUARD
5fd8432bb6 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-04-11 13:05:38 +02:00
Jean-Marie RENOUARD
709da2cc95 ident fix 2016-04-11 12:25:42 +02:00
Jean-Marie RENOUARD
d8a8dd42d3 ident fix 2016-04-11 12:24:49 +02:00
root
845dc030e1 Using a generic sub header function 
get_pf_memory return 0 for performance memory if P_F is disabled.
 2016-04-11 12:01:01 +02:00
Robert Milasan
8f0c2e6b33 Fix Galera checks, make sure we dont say that Galera is enabled when is not, clean-up typos 2016-04-06 10:33:56 +02:00
Jean-Marie RENOUARDjmrenouard@gmail.com
15854a6c94 #138 for threadpool in mariadb and percona use default values 2016-04-05 12:34:24 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
83010dd32e Bug fix on aria metrics 2016-04-05 12:25:20 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
a5449a0d22 Adding performance_schema.memoty value to max_used_memory and max_peak_memory calculation 
There is always MySQL 5.7+ and adaptaive memory usage to handle porperly
 2016-04-05 11:40:38 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
97cce402ae Adding get_http_cli for curl or wget detecting in sysstat 2016-04-05 09:49:43 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
974bd03ddf Adding new control for Galera cluster #150 2016-04-05 05:16:52 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
2d483e6b75 Check tables are all innodb table and check all table gets pk #150 2016-04-04 12:32:35 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
3ef98d83c1 Dumping mysql options for galera* #150 2016-04-04 11:30:16 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
8203dcd686 Dumping galera options and status #150 2016-04-04 11:23:43 -04:00
Christine
c9cea2cc80 #177 bug with free -h changed to free -mwq 2016-04-04 13:58:52 +02:00