hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1127 commits 2 branches 20 tags 34 MiB
Commit graph

632 commits

Author SHA1 Message Date
Jean-Marie Renouard
0d897f8c5b
Merge pull request #568 from 64kramsystem/fix_innodb_log_buffer_size_message 
Fix `innodb_log_buffer_size` message
 2021-10-15 16:33:37 +02:00
Jean-Marie Renouard
6b6d85ef28 Wrong recommendation "thread_pool_size between 16 and 36 for InnoDB usage" for Percona Server (#551) 2021-10-15 16:28:19 +02:00
Jean-Marie Renouard
1333ea9395 Update Vulnerabilities list 
Indenting mysqltuner
Update Usage information
 2021-10-15 13:56:27 +02:00
Jean-Marie Renouard
c0251a1488 Can't locate Data/Dumper.pm in @INC #564 2021-10-15 13:43:07 +02:00
Saverio Miroddi
85d7d6b6a8 Fix innodb_log_buffer_size message 
The operator used to recommend the user to increase the log buffer size (`>=`) is confusing.

Closes #567 (which includes a detailed description).
 2021-10-15 10:39:03 +02:00
Jean-Marie Renouard
d04c1c46dc Increment releas number 2021-09-28 17:31:55 +02:00
Jean-Marie Renouard
5b96d08004 Update Vulnerabilities list 
Indenting mysqltuner
Update Usage information
 2021-09-27 12:25:12 +02:00
Steve8291
911b1294fa
Fix Replication Status 
Reference Issue #553 
Reversing the check for version of mysql or mariadb to use correct command.
 2021-08-26 10:21:23 -04:00
Jean-Marie Renouard
3225a954fc
Merge pull request #559 from willamowius/master 
fix English grammar
 2021-08-25 12:05:36 +02:00
Jean-Marie RENOUARD
1e9920b545 Update Vulnerabilities list 
Indenting mysqltuner
Update Usage information
 2021-08-25 12:01:28 +02:00
Jan Willamowius
6584233c72 fix English grammar 2021-07-17 08:35:44 +02:00
Jean-Marie Renouard
7aa57fa770 Illegal division by zero at ./mysqltuner.pl line 2745 #558 
Wrong table cache hit rate calculation #548
 2021-07-15 17:03:00 +02:00
Jean-Marie Renouard
7a2a0f1b13 Illegal division by zero at ./mysqltuner.pl line 2745 #558 
Wrong table cache hit rate calculation #548
 2021-07-15 17:02:24 +02:00
Jean-Marie Renouard
78d8f3ed85 Version 1.8.0: Support MariaDB 10.6 Update needed for MariaDB 10.6 #557 2021-07-13 18:56:52 +02:00
Jean-Marie Renouard
656a7e51ed Update Vulnerabilities list 
Indenting mysqltuner
Update Usage information
 2021-07-02 18:31:21 +02:00
Jean-Marie Renouard
8f479b06f6 Increment version 2021-07-02 18:17:57 +02:00
Jean-Marie Renouard
2079639e6b Wrong table cache hit rate calculation #548 2021-07-02 18:17:25 +02:00
Jean-Marie Renouard
213211aecc improve FreeBSD support a bit (patch included) #549 2021-07-02 16:55:43 +02:00
Jean-Marie Renouard
47cf0669fc failed to execute: SHOW SLAVE HOSTS #553 2021-07-02 16:41:36 +02:00
Jean-Marie Renouard
c9345a1380 1.7.26 is fixing minor glitch with DROP USER #555 2021-07-02 16:22:51 +02:00
Jean-Marie RENOUARD
5aa880afbc Wrong recommendation "thread_pool_size between 16 and 36 for InnoDB usage" for Percona Server #551 2021-05-03 12:00:02 +00:00
Jean-Marie Renouard
447652d325 Update mysqltuner.pl 2021-05-03 11:06:23 +02:00
Jean-Marie Renouard
ac34523609 Update mysqltuner.pl 2021-03-30 11:54:30 +02:00
Jean-Marie Renouard
68e5902169 Update mysqltuner.pl 2021-03-30 11:44:08 +02:00
Jean-Marie Renouard
a8fc0c2639 Update mysqltuner.pl 
Adding more information about flow control current value
 2021-03-08 18:29:03 +01:00
Jean-Marie Renouard
b0cfbd802b Duplicate recommendation/check #545 
Duplicate recommendation/check #545
 2021-03-08 18:02:22 +01:00
Jean-Marie Renouard
5a399f6006 Duplicate recommendation/check #545 
Duplicate recommendation/check #545
 2021-03-08 18:01:44 +01:00
Jean-Marie RENOUARD
ef66fb274c Update Vulnerabilities list 
Indenting mysqltuner
Update Usage information
 2021-02-05 15:25:09 +01:00
Daniel Black
e29b76fca1 empty passwords - use exact user/host quoted 2021-02-05 09:46:37 +11:00
Daniel Black
0be85cbb9f user host recommend - RENAME USER 
Altering mysql.user tables isn't something users should do.

RENAME USER has existed for a long time, use this instead.

Also change SpecificDNSorIp because DNS based grants are
a horrible idea, fragile, and could be disabled with
--skip-name-resolve.

closes #536
 2021-02-05 09:37:10 +11:00
Daniel Black
5c307d1813 correct messages on no InnoDB 
enginestats are only populated if tables exist of that type.

Look at default_storage_engine if defined to communicate the default
storage engine.

closes #469
 2021-02-01 11:42:44 +11:00
Daniel Black
938b434e41 extend server-log for journal/container/pods 
Default to reading last 30000 lines.

If reading from file estimate that average line
length is 80 characters and read based that
far back from the end of file.
 2021-01-30 12:51:28 +11:00
Daniel Black
c3da0b013c add server-log option for explict server log 
This allows a user to specify a logrotated file
or another file that isn't discoverable from
server log_error system variable or other defaults.

close #504
 2021-01-30 10:24:03 +11:00
Jean-Marie Renouard
47ebbbca75
Merge pull request #535 from grooverdan/snap 
skip snap filesystems
 2021-01-28 18:21:43 +01:00
Jean-Marie Renouard
22789d1c7f
Merge pull request #537 from grooverdan/min_dblist 
minimal database list retrieval
 2021-01-28 18:21:11 +01:00
Jean-Marie Renouard
1f879d110b
Merge pull request #538 from grooverdan/json_total_tables 
Add total_tables to json output
 2021-01-28 18:19:09 +01:00
Jean-Marie Renouard
374ef59417
Merge pull request #533 from grooverdan/exec_perms 
add execute permissions to mysqltuner.pl
 2021-01-28 18:18:17 +01:00
Jean-Marie Renouard
49c2f6e930 Update mysqltuner.pl 2021-01-28 18:15:53 +01:00
Daniel Black
72952b5873 Add total_tables to json output 
closes #484
 2021-01-28 19:13:02 +11:00
Daniel Black
7a94bd5388 minimal database list retrieval 
Information schema access isn't particularly well optimized.

As such, at least in older versions, fetching from the information_schema.TABLES
would involve opening every table.

The ANSI SQL standards SCHEMATA provides a quicker way, and we can reuse it.
 2021-01-28 18:44:17 +11:00
Daniel Black
59ce37b3a1 skip snap filesystems 2021-01-28 18:01:59 +11:00
Daniel Black
2c8f5e81cf add execute permissions to mysqltuner.pl 
closes #531
 2021-01-28 16:22:16 +11:00
Jean-Marie Renouard
285ba51330
Merge pull request #528 from grooverdan/gtidmode_mariadb 
mariadb gtid mode - base off gtid_current_pos.
 2021-01-27 21:31:41 +01:00
Jean-Marie Renouard
d9e00040c8
Merge pull request #527 from grooverdan/mariadbnames 
mariadb is using its on name in mariadb/mariadb-admin
 2021-01-27 21:31:16 +01:00
Jean-Marie Renouard
f2c8ca86b2
Merge pull request #526 from grooverdan/anonuser 
anonymous users - remove password checks
 2021-01-27 21:29:38 +01:00
Jean-Marie Renouard
8fb9195c4f
Merge pull request #525 from grooverdan/qc 
query_cache off with query_cache_type=OFF OR query_cache_size=0
 2021-01-27 21:28:18 +01:00
Daniel Black
9d1d19c97d mariadb gtid mode - base off gtid_current_pos. 
gtid_strict_mode isn't sufficient a test for
MariaDB's GTID mode. The gtid_current_pos
however is always non-blank if GTID is enabled.

closes #513
 2021-01-27 18:03:41 +11:00
Daniel Black
fa8deec762 mariadb is using its on name in mariadb/mariadb-admin 
The mysql client, mysql, in mariadb is starting to be labeled mariadb.
Likewise mysqladmin is getting called mariadb-admin. Lets check
for these names as well.
 2021-01-27 17:26:29 +11:00
Daniel Black
2f45f349c9 anonymous users - remove password checks 
For anonymous users, those with user='', having a recommendation
to set their passwords, and warning that the password is the same
as the username is a little excessive since there's already a
recommendation to drop the user.

So let's remove those recommendation so we don't see:

[!!] User '@localhost' has user name as password.
[!!] User '@localhost.localdomain' has user name as password.

or:

    Set up a Secure Password for @localhost user: SET PASSWORD FOR ''@'SpecificDNSorIp' = PASSWORD('secure_password');
    Set up a Secure Password for @localhost.localdomain user: SET PASSWORD FOR ''@'SpecificDNSorIp' = PASSWORD('secure_password');

Lets keep the focus on:
-------- Security Recommendations ------------------------------------------------------------------
[!!] User ''@'localhost' is an anonymous account. Remove with DROP USER ''@'localhost';
[!!] User ''@'localhost.localdomain' is an anonymous account. Remove with DROP USER ''@'localhost.localdomain';
 2021-01-27 17:15:03 +11:00
Daniel Black
3ac95cd046 query_cache off with query_cache_type=OFF OR query_cache_size=0 
From the MySQL and MariaDB code (same - 5.5 version):
https://github.com/mysql/mysql-server/blob/5.5/sql/sql_cache.h#L560
https://github.com/MariaDB/server/blob/5.5/sql/sql_cache.h#L572

This is used:
https://github.com/mysql/mysql-server/blob/5.5/sql/sql_prepare.cc#L3058
(same in MariaDB code)

The size=0 and type=0 are both sufficent conditions for the query
cache to be disabled. As such lets consider it ok if its disabled
only in one place. This is the case in mariadb where type=0 (OFF)
is the default as is a non-zero query-cache size.
 2021-01-27 17:02:58 +11:00