Commit graph

629 commits

Author SHA1 Message Date
Jean-Marie Renouard
aac1ab2b4d
Merge pull request #514 from grooverdan/mdb10.4-secure-users
secure users MariaDB-10.4+ / MySQL auth socket
2020-12-08 08:30:23 +01:00
Jean-Marie Renouard
643e5e4e98
Merge pull request #515 from grooverdan/delanonymous
DROP USER to delete anonymous accounts
2020-12-08 08:30:04 +01:00
Daniel Black
6f966dee45 MariaDB-10.1 EOL, MariaDB-10.5 is GA 2020-12-08 15:25:59 +11:00
Daniel Black
1bb30f508e DROP USER to delete anonymous accounts
DROP USER has existed for a very long time.

Use the QUOTE sql function to ensure accounts are correctly quoted
and this helps the delete recommendation.
2020-12-08 14:37:26 +11:00
Daniel Black
79a4403c9c MySQL-5.7/8.0+ auth_socket is safe
MySQL has auth_socket as its plugin compared to unix_socket on MariaDB
so accept that as a valid reason for having no authentication.

MySQL [(none)]> show create user dan@localhost;
+-----------------------------------------------------------------------------------------------------------------+
| CREATE USER for dan@localhost                                                                                   |
+-----------------------------------------------------------------------------------------------------------------+
| CREATE USER 'dan'@'localhost' IDENTIFIED WITH 'auth_socket' REQUIRE NONE PASSWORD EXPIRE DEFAULT ACCOUNT UNLOCK |
+-----------------------------------------------------------------------------------------------------------------+
1 row in set (0.000 sec)

MySQL [(none)]> select user,host,plugin from mysql.user;
+---------------+-----------+-----------------------+
| user          | host      | plugin                |
+---------------+-----------+-----------------------+
| root          | localhost | mysql_native_password |
| mysql.session | localhost | mysql_native_password |
| mysql.sys     | localhost | mysql_native_password |
| dan           | localhost | auth_socket           |
| expiretest    | %         | mysql_native_password |
| expiretest    | localhost | mysql_native_password |
+---------------+-----------+-----------------------+
6 rows in set (0.001 sec)

MySQL [(none)]> select version();
+-----------+
| version() |
+-----------+
| 5.7.31    |
+-----------+
2020-12-08 14:18:03 +11:00
Daniel Black
0eef9260a8 mariadb-10.4+ empty passwords
MariaDB-10.4 migrated their authentication to a global_priv table in JSON
format. Also locked user accounts where added. By default the mariadb.sys
is a locked user without a password and there as the owner of the mysql.user
view. As its hazardous for a user to modify this we exclude locked accounts
but still search for mysql_native_password plugin without authentication.

We use versioned comments to process all other versions. The 5.5+ MySQL
version comment is also read by MariaDB (ref: https://mariadb.com/kb/en/comment-syntax/
enabling the processing of plugins on other version that have plugins.

While this branch doesn't yet apply to MySQL-8.0 yet, we add support
for the locked user accounts in MySQL-8.0+ in a versioned comment
(not read by MariaDB).
2020-12-08 14:00:39 +11:00
Jean-Marie Renouard
de4b145e96 Remove innodb_buffer_pool_instances recommendations for MariaDB #512
Remove innodb_buffer_pool_instances recommendations for MariaDB #512
2020-11-16 20:22:24 +01:00
Jean-Marie Renouard
b5718d0e2f Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2020-11-05 17:29:32 +01:00
Jean-Marie Renouard
cff819d46f Change version number 2020-11-05 17:29:26 +01:00
Jorge Vallecillo
d2a8f0b60a Remove references to the domain mysqltuner.com. #501 2020-09-03 10:17:58 -06:00
Jean-Marie Renouard
b6f8f9f9a3 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2020-05-04 11:02:49 +02:00
Jean-Marie Renouard
00ce968c6a Removing windows end of lines 2020-05-04 11:01:34 +02:00
Jean-Marie Renouard
6038bd7749 Update mysqltuner.pl
Back to MYsqltuner 1.7.19
2020-05-03 23:12:19 +02:00
Jean-Marie Renouard
9236ec0f80 Update mysqltuner.pl
Fix error
2020-05-03 23:07:42 +02:00
Jean-Marie RENOUARD
1e8b32a253 merged 2020-05-02 16:01:37 +02:00
root
12ae60c6f2 local commit 2020-05-02 15:56:26 +02:00
Kovalkov Dmitrii
e7609d7a91 And for debug line ignore these lines 2020-01-23 16:37:45 +03:00
Kovalkov Dmitrii
dc4aa248c8 Ignore
200122 12:09:15 mysqld_safe Logging to '/var/log/mysql/error.log'.
when we count errors in log
2020-01-23 11:24:56 +03:00
Jean-Marie Renouard
7965211fa0
Merge pull request #466 from Ruzgfpegk/bugfix/mariadb-sys-update
Suggest using mariadb-sys from FromDual in script
2020-01-09 22:16:39 +01:00
Ruzgfpegk
8ffd81475a
Updates link to MyISAM table_cache scalability doc
Fixes #465 .
2020-01-09 15:53:56 +09:00
Ruzgfpegk
3555142ead
Suggest using mariadb-sys from FromDual in script
Follows #443 and #444.
2020-01-09 15:04:04 +09:00
jfcoz
c5765f0213 Include max_allowed_packet in thread memory size
Fix https://github.com/major/MySQLTuner-perl/issues/378
Fix https://github.com/major/MySQLTuner-perl/issues/456
2019-12-12 13:31:23 +01:00
Jean-Marie Renouard
345bf1ae24 Issue Typo in commit 6f6130b (ymsql => mysql) (#459) 2019-10-17 17:39:45 +02:00
155da8c074 SCALAR ref while strict refs 2019-10-04 12:10:16 +02:00
Jean-Marie Renouard
6f6130b12b Missing password is not recognized #412 2019-10-03 23:15:31 +02:00
Jean-Marie Renouard
851cd817de Update version command #428 2019-10-03 22:33:22 +02:00
Jean-Marie Renouard
66f2ee40be About innodb_log_file_size changing recommendation #408 2019-10-03 22:10:18 +02:00
Jean-Marie Renouard
792b46b03c About innodb_log_file_size changing recommendation #408 2019-10-03 22:06:51 +02:00
Jean-Marie Renouard
6aa887d5a5 Use of uninitialized value $engine in concatenation (.) or string #350 2019-10-03 21:52:30 +02:00
Jean-Marie Renouard
143b80b3a6 Add recommendation on table_definition_cache #433 2019-10-03 21:29:03 +02:00
Jean-Marie Renouard
a421f73e26 Add note about join_buffer_size #434 2019-10-03 21:04:12 +02:00
Jean-Marie Renouard
d1f39e9a00 Script is failing on MySQL 5.6.10(AWS Aurora) #435 2019-10-02 01:13:34 +02:00
Jean-Marie Renouard
f18a3ef33f Update mysqltuner.pl
FAIL Execute SQL / return code: 256 #442
disable column type to ENUM suggestion #356
2019-10-02 00:44:54 +02:00
Jean-Marie Renouard
a9bed2ffa0 Percona Server 8.0 - better support
Lot of bug fixes for percona.
2019-10-02 00:07:46 +02:00
Jean-Marie Renouard
b8f191d180 Update error log file analysis 2019-09-26 00:41:10 +02:00
Jean-Marie Renouard
7332f8d5c4 Wrong report of InnoDB Storage engine status #450
Good message is
-------- InnoDB Metrics ----------------------------------------------------------------------------
[--] Skipped due to --skipsize option
2019-09-25 23:50:15 +02:00
Jean-Marie Renouard
ebc6619e4f Bug fix #453 2019-09-25 23:29:22 +02:00
Jean-Marie Renouard
60df6043b1 Update Vulnerabilities list
Indenting mysqltuner
Update Usage information
2019-09-25 20:05:45 +00:00
Billy Noah
066acb0940
Update mysqltuner.pl
Check to make sure mysql.user has a column called 'password'.  Adjust security_recommendations queries accordingly.

This should address issues:
https://github.com/major/MySQLTuner-perl/issues/427
https://github.com/major/MySQLTuner-perl/issues/441
https://github.com/major/MySQLTuner-perl/issues/442
2019-09-10 16:06:58 -04:00
Eduardo Broto
ece5671292 Escape identifiers in table column metrics
Otherwise some queries may fail if reserved words were used as field, table or
database names.
2019-07-10 17:25:23 +02:00
Myrdhin
b10c90ccf8 Fix typo on myvar 2019-05-15 11:01:46 +02:00
Myrdhin
49a1b603da Fix error when innodb_stats_on_metadata not defined 2019-05-15 10:52:51 +02:00
Jean-Marie Renouard
4a01df4a04
Merge pull request #431 from atombrella/should_be
Corrected grammar for innodb_buffer_pool_size recommendation.
2019-03-22 10:20:32 +01:00
Mads Jensen
320e1fda8e Changed http to https. Fixed broken link to original script. 2019-03-22 07:32:47 +01:00
Mads Jensen
0fae7c5a91 Corrected grammar for innodb_buffer_pool_size recommendation. 2019-03-22 07:23:08 +01:00
Jean-Marie Renouard
fce4eda2aa Illegal division by zero #423 2019-03-06 13:28:28 +00:00
Jean-Marie Renouard
4c14ba9718 Missing password is not recognized #412 2019-03-06 13:10:17 +00:00
Tim Hughes
69d4e2fbea A bit of work on the html report template 2018-11-30 13:06:49 +00:00
Jean-Marie Renouard
d7c906c9c4 Uncaught exception from user code (#414) 2018-11-26 15:25:54 +00:00
Jean-Marie Renouard
177c9f6695 ignore galera check when wsrep_on = 0 #353 2018-11-26 13:41:36 +00:00
Jean-Marie Renouard
87eb96a485 Sys schema on MariaDB #362 2018-11-26 13:31:59 +00:00
Jean-Marie Renouard
1b9e4e75ba Last modification related to options 2018-11-26 12:57:11 +00:00
tcraxs
c0b2f67a2f
fix defect link to mysql documentation - #408
Fix defect link to the mysql documentation. Choose to set the link to version 8 as in Issue major#408 mention.
Links to: https://dev.mysql.com/doc/refman/8.0/en/innodb-redo-log.html
2018-11-14 16:54:05 +01:00
Jean-Marie Renouard
c8fb973bf8 MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386 2018-09-26 09:10:09 +00:00
Jean-Marie Renouard
dab1e7e960 MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386 2018-09-26 07:31:19 +00:00
Jean-Marie Renouard
b8224beb85 bug fix in calcualation of wsrep_slave_threads value #305 2018-09-26 07:25:58 +00:00
Jean-Marie Renouard
c8bb7050ab wsrep_slave_threads info and test modification 2018-09-25 17:19:19 +02:00
Jean-Marie Renouard
6081df99a9 Wrong warning about table_open_cache #364 2018-09-25 17:05:43 +02:00
Jean-Marie Renouard
580a707ef7 wsrep_slave_threads #305 2018-09-25 16:58:36 +02:00
Jean-Marie Renouard
469a205ac0 Uptime info" 2018-09-23 19:48:09 +00:00
Jean-Marie Renouard
be4c965ea9 adding better json outputfile option 2018-09-23 18:19:06 +00:00
Jean-Marie Renouard
79d91e5b07 Template staff 2018-09-23 09:50:33 +00:00
Jean-Marie Renouard
b8ef183bcf Hope to add MySQL 8 support! #377
MySQL 8: disabling Query cache recommandations
MySQL 8: check password disabled due to new authentication storage model - Help wanted
2018-09-23 07:45:25 +00:00
Jean-Marie Renouard
5d4e891ea1 ignore galera check when wsrep_on = 0 #353 2018-09-20 14:34:07 +00:00
Jean-Marie Renouard
08cb34587b Fixing important performance issue during collecting metrics 2018-09-20 13:11:34 +00:00
Jean-Marie Renouard
e76f3a25b1 New option tbstat 2018-09-20 12:51:07 +00:00
Jean-Marie RENOUARD
4951c920c5 Incorrectly assumes 32bit architecture on s390x systems #390 2018-08-07 15:52:14 +02:00
Jean-Marie RENOUARD
dc86f73d1b wsrep_slave_threads #305 2018-08-07 09:00:21 +02:00
Jean-Marie RENOUARD
2bd7e7bf71 wsrep_slave_threads #305 2018-08-06 14:53:12 +02:00
Jean-Marie RENOUARD
7429b7c15c Minor accessing undefined variable bug to fix eventually #383 2018-08-06 12:38:06 +02:00
Jean-Marie RENOUARD
e7980611a1 # 393 Peak and max memory usage estimated incorrectly 2018-08-06 11:53:02 +02:00
Maxximou5
ad74a7dc6d Spelling and grammar
- Fixed: Minor spelling, grammar, and accidental return
2018-07-28 16:50:06 -07:00
Kovalkov Dmitrii
d02feeedc8
Minor fix undefined value 2018-07-26 23:00:04 +03:00
Kovalkov Dmitrii
010656345d
Switch human readable for Data (not need round) 2018-07-05 17:48:45 +03:00
Jean-Marie RENOUARD
a43032b863 #377 adding 0 as query cache efficiency for MySQL 8 2018-06-29 14:06:42 +02:00
Jean-Marie RENOUARD
9cf4dd4453 Ticket #383 Minor accessing undefined variable bug to fix eventually 2018-06-29 12:16:30 +02:00
Martin Kiesel
9a1d331ebb
End sentence with a period
Fixed example output:

```
[!!] User 'a@localhost' has user name as password.
[!!] User 'b@%' does not specify hostname restrictions.
```
2018-06-05 14:12:54 +02:00
Artem S. Tashkinov
593928c646
Some fixes 2018-05-27 14:03:29 +00:00
Drew Schatt
e46309a09f Spelling fixes.
Physical
theoretically
MariaDB
2018-05-21 16:10:22 -07:00
Jean-Marie RENOUARD
1b68fd55a3 Update staff 2018-04-26 14:15:59 +02:00
Jean-Marie RENOUARD
61cdd6c0d0 Trim sub with emtpy string display error #376 2018-04-04 15:20:27 +02:00
Jean-Marie RENOUARD
b9721ef91b MySQL enterprise: Column recommandations #375 2018-04-04 15:17:57 +02:00
Jean-Marie RENOUARD
9cf48b52e0 Clean up staff 2018-03-30 15:44:40 +02:00
Jean-Marie Renouard
7ae81143b9 Removing error from Use of uninitialized value $engine in concatenation (.) or string #350 2018-03-27 12:33:31 +00:00
Jean-Marie RENOUARD
3551d0d28e Avoid use of uninitialized value 2018-03-20 08:53:15 +01:00
Jean-Marie RENOUARD
de1bd2015e update staff 2018-03-19 17:17:11 +01:00
Jean-Marie RENOUARD
031f741296 Some information about replication 2018-03-19 17:08:12 +01:00
Jean-Marie RENOUARD
ff2a47e461 Issue #373 Fix for password column on MySQL 5.7 2018-03-19 16:34:41 +01:00
Jean-Marie RENOUARD
f0394b67cc Issue #373 Fix for password column on MySQL 5.7 2018-03-19 16:33:04 +01:00
Jean-Marie RENOUARD
bca1ad849d Change year reference 2018-02-23 16:42:24 +01:00
Jean-Marie RENOUARD
760adf20b5 Latest version has a regression with colored outout #371 2018-02-23 12:34:32 +01:00
Jean-Marie RENOUARD
94f8dad080 Wrong sort order in MySQLTuner report #363 2018-02-22 18:42:32 +01:00
Jean-Marie RENOUARD
35c4200813 Issue #364 2018-02-22 16:58:59 +01:00
Jean-Marie RENOUARD
0e8fcbf52d Issue #369 2018-02-22 16:11:42 +01:00
Jean-Marie RENOUARD
8fda1dc284 Issue #371 2018-02-22 15:35:31 +01:00
Jean-Marie RENOUARD
6d95d8642c Update code, doc and vulnerabilities 2018-02-22 15:29:33 +01:00
Jean-Marie RENOUARD
86b0a1949f Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2018-02-22 15:24:32 +01:00
Jean-Marie RENOUARD
50f3a0d965 Small quotes issue 2018-02-22 15:24:20 +01:00
Jean-Marie Renouard
75f4bc623a
Merge pull request #370 from jsoref/spelling
Spelling
2018-02-22 15:22:30 +01:00
Jean-Marie Renouard
5b2918296f
Merge pull request #367 from martinellimarco/master
Proposed fix for #268
2018-02-22 15:21:01 +01:00