Commit graph

508 commits

Author SHA1 Message Date
root
f7699b4515 #278 Escaping password items 2016-12-02 15:24:52 +01:00
git001
caa785ec59 Fix Argument "NULL" isn't numeric
Argument "NULL" isn't numeric in numeric ge (>=) at mysqltuner.pl line 288 (#1)
    (W numeric) The indicated string was fed as an argument to an operator
    that expected a numeric value instead.  If you're fortunate the message
    will identify which operator was so unfortunate.
[--]  +-- ROWS : 0
Argument "NULL" isn't numeric in numeric eq (==) at mysqltuner.pl line 343 (#1)
    (W numeric) The indicated string was fed as an argument to an operator
    that expected a numeric value instead.  If you're fortunate the message
    will identify which operator was so unfortunate.
[--]  +-- ENGIN : 0 (NULL)
Argument "NULL" isn't numeric in numeric lt (<) at mysqltuner.pl line 3847 (#1)
2016-11-28 20:39:47 +01:00
root
ce7eefb3da Bug fix on Galera Gcache mem calculation 2016-11-28 17:51:46 +01:00
root
5be96339a1 Incorrect innodb log file size calculation #271 2016-11-28 17:48:22 +01:00
root
eac905b632 MariaDB GTID mode #272 2016-11-28 17:39:41 +01:00
Artur Penttinen
5a6742ee85 Hiding username and password from commandline
It is possible to spy username and password if command run
with --user/-pass options (ps -C mysqltuner.pl -F).
To hiding these added options --userenv/--passenv for
transfer MySQL username and password via environment
variables.
2016-11-16 11:05:33 +02:00
Michael R Mawhinney Jr
947856901a Minor spelling correction 2016-11-09 22:29:34 -05:00
root
e6b57a84d3 New indicators from performance schema 2016-11-03 10:36:59 +01:00
root
5872fcc1ee #265 TOP 15 queries with temp table to disk
#260 Memory used > 100% ?
#258
2016-11-02 21:16:54 +01:00
root
6b9920902b Last modifications 2016-11-02 20:02:41 +01:00
Jean-Marie Renouard
51ea5925d1 Merge pull request #263 from henriquemoody/patch-1
Use single quotes around password
2016-10-27 21:17:13 +02:00
Henrique Moody
5a3873ece4 Use single quotes around password
Password may contain characters, like `$` and `!`, that may be interpreted by
the shell. Prevent it to happen by using single quotes.
2016-10-27 15:28:41 +02:00
Karl Chen
05c1e6eb75 Non importance changes 2016-10-24 17:25:07 +08:00
Karl Chen
f68b731498 Non importance changes 2016-10-24 17:21:56 +08:00
Karl Chen
4f1a6ec38b Non importance changes 2016-10-24 07:36:05 +08:00
Karl Chen
f4e46cdbc0 Non importance changes 2016-10-24 07:34:19 +08:00
Karl Chen
915be0fbe4 Non importance changes 2016-10-24 00:38:32 +08:00
Karl Chen
301e5f2291 Non importance changes 2016-10-24 00:32:48 +08:00
Karl Chen
7b3f2ce9a9 Something wrong to print 2016-10-23 13:42:01 +08:00
root
6a70adebd3 Full support performance schema
Update vulnerability list
Updade INTERNALS doc.
2016-10-18 14:55:13 +02:00
root
bbc04d848f #258 new rule for innodb log file size (25% of Buffer pool size) 2016-10-18 14:25:02 +02:00
root
cff9e62933 Adding new indicators from sys schema 2016-10-17 17:04:10 +02:00
root
c10c7e81ec Redundant indexes" 2016-10-10 19:03:40 +02:00
root
e684a45120 * TOP 15 most read tables
* TOP 15 most modified tables
* TOP 15 high select latency tables
* TOP 15 high insert latency tables
* TOP 15 high update latency tables
* TOP 15 high delete latency tables
2016-10-10 18:39:56 +02:00
root
101c13baed Typo fix 2016-10-10 18:18:26 +02:00
root
f826adecf2 * TOP 15 most read indexes
* TOP 15 most modified indexes
* TOP 15 higth select latency index
* TOP 15 higth insert latency index
* TOP 15 higth update latency index
* TOP 15 higth delete latency index
2016-10-10 18:14:52 +02:00
root
ad9228d029 * Event per wait total latency
* Event per wait read latency
* Event per wait write latency
2016-10-10 16:54:45 +02:00
root
16f0d5d9ff Adding * Event Wait by read bytes
* Event Wait by write bytes
2016-10-10 16:00:15 +02:00
root
7b46762a1a Adding pfs indicators related to File IO 2016-10-10 15:34:29 +02:00
root
50ece21b2d New indicators from performance schema
On the road to 1.7.x version
2016-10-06 10:44:58 +02:00
root
30616932d7 Adding Performance stat per user 2016-09-27 16:07:26 +02:00
root
20b9fa2a19 Included a lot of new indicators for PFS when using --pfstat or --verbose option 2016-09-26 18:32:35 +02:00
root
8263cbda27 Update doc 2016-09-26 16:00:20 +02:00
root
243c54eaa0 Adding --defaults-file to change credentials storage 2016-09-26 15:53:32 +02:00
root
972bf2e4ae #193 adding some useful extraction for sysschema 2016-09-19 16:13:22 +02:00
root
2b6a0c3522 Adding Comment with sys request 2016-09-12 16:43:20 +02:00
root
33dfabd940 #237 removing ? more info ? 2016-09-12 14:18:14 +02:00
Rowan Wookey
9f777ed47b Fixed #245 error when checking for passwordless accounts on MySQL < 5.5 2016-09-03 15:11:09 +01:00
root
401cb549e8 Removing warnings for SQL request 2016-08-31 13:48:01 +02:00
root
a067eddb20 Tidyfy code 2016-08-31 10:30:20 +02:00
root
746f5d3a4d Changing version in test for displaying false positive CVE messages 2016-08-31 10:26:39 +02:00
root
94c56dad3f False CVE detection for mysql 5.50 #235 adding info message 2016-08-31 09:17:03 +02:00
root
3820a528ed Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-08-31 09:05:35 +02:00
root
6bcd5ae0ce Update vulnerabilies list
InnoDB buffer pool alignment check appears backward #244
2016-08-31 09:04:48 +02:00
Christian Loos
0cd7e93685 fix "Don't modify $_ in list functions" 2016-08-30 18:26:08 +02:00
Christian Loos
600aad227d get_file_contents calls already remove_cr 2016-08-30 18:26:08 +02:00
Christian Loos
1c13c66e36 improve message if JSON isn't installed 2016-08-30 18:26:08 +02:00
Christian Loos
7215e419df fix 'Expression form of "eval"' 2016-08-30 18:26:08 +02:00
Christian Loos
90e8251523 fix 'Bareword file handle opened' 2016-08-30 18:26:08 +02:00
Christian Loos
f3e3b39023 fix 'Nested named subroutine' 2016-08-30 18:26:08 +02:00
root
a7062ad804 #196 misplaced semi column 2016-08-30 17:03:21 +02:00
root
3f19d63833 #242 adjust test for unitialized value 2016-08-30 14:57:09 +02:00
root
1b068ed7e4 #242 adjust test for unitialized value 2016-08-30 14:56:59 +02:00
root
b94d3bd927 #196 correct variable name
increment version number
2016-08-30 14:48:48 +02:00
root
aa1df95ff3 #155 adding test for consistent values for innodb_buffer_pool_size,innodb_buffer_pool_chunk_size and innodb_buffer_pool_instances 2016-08-30 14:38:16 +02:00
root
7554f10e52 #196 better thread cache hit rate with pools-of-threads 2016-08-30 13:45:46 +02:00
root
8f33b55fea #242 initiliaze $data_free to 0 if not defined or is empty 2016-08-30 13:34:52 +02:00
root
dbbe785e01 #231 #235 bug fix regarding way CVE are selected. 2016-08-29 17:10:26 +02:00
root
736fc24c47 increment version 2016-08-26 11:02:15 +02:00
root
11ccfccc1c #235 #231 review way to select version
bug fix in calculate greater and lower version
2016-08-26 10:40:58 +02:00
root
8e8345dac3 Update vulnerabilities list
issue #237: Test skip_name_resolve is set before using it
Adding information message  when skip_name_resolve is missing
2016-08-25 16:33:58 +02:00
Peter 'Pessoft' Kolínek
70455de4ba Fix SQL string concatenation in capitalization during password test 2016-08-24 00:21:18 +02:00
root
ef1f96625a #231 change label for CVE reports 2016-08-10 13:40:58 +02:00
root
24f1c722d3 Don t display advice for tcp slot if /proc/sys/sunrpc file doesn t exist #230 2016-08-10 11:48:41 +02:00
root
2aac89e89c Don t display advice for tcp slot if /proc/sys/sunrpc file doesn t exist #30 2016-08-10 11:47:36 +02:00
root
6300c3a2c7 Adjust request for table without primary key #229 2016-08-10 11:44:22 +02:00
root
97587f6d2f Adding a lot of things in JSON structure 2016-08-09 16:04:13 +02:00
root
b3005038d3 Removing some warnings and errors messages when sysctl doesnt get any value 2016-08-09 13:38:47 +02:00
root
da1819d66b Bug fix for exec fail 2016-08-09 10:15:49 +02:00
root
b42b97f96f #227 Stopping MySQL tuner when SELECT VERSION doesnt return any value. This indicates that user doent get enough privileges 2016-08-08 17:40:53 +02:00
Grzegorz Adam Kowalski
a9f9e69201 Don't exit after positive latest version check 2016-07-13 12:58:30 +02:00
root
51993aa2c8 wsrep_osu_method error #224 2016-07-04 08:41:16 +02:00
root
5af540cab0 #223 removing version estension for Ubuntu version - V2 2016-06-23 21:30:22 +02:00
root
4ea5c09d44 #223 removing version estension for Ubuntu version 2016-06-23 21:28:26 +02:00
root
0b8dfd9f66 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-06-16 11:07:38 +02:00
root
638e843d49 Removing strange code blocks :) 2016-06-16 11:07:32 +02:00
Louis Sautier
e450074254
Reword a message 2016-06-16 10:33:03 +02:00
mhasbini
d148093634 no need to return, just exit 2016-06-11 16:36:59 +00:00
mhasbini
2db1483123 switch version check with mysql_setup 2016-06-11 16:19:55 +00:00
root
cf75be4c84 Tokudb detection fix #218 2016-06-10 10:27:55 +02:00
root
16c94a51ba uninitialized value in script #218 2016-06-10 10:24:40 +02:00
root
0b534333b2 Update vulnerabilities list
Update mysql tuner version
Update internals documentation
2016-06-10 10:18:21 +02:00
Kevin Houdebert
b479d9aede Fix typo for OPTIMIZE 2016-06-03 15:54:52 +02:00
root
5bcddc77b8 #213 changing badprint to print in order to display error message when JSON module is not loaded 2016-06-03 11:03:52 +02:00
jfcoz
b0848e5cc5 add skip-name-resolve recommandation 2016-06-03 08:33:02 +02:00
jfcoz
2a8cf5fea6 add innodb when innodb_file_per_table is ON
display OPTIMIZE requests for tables of more than 100mb with more thant 10% fragmentation

    Run OPTIMIZE TABLE to defragment tables for better performance
      OPTIMZE TABLE testdb.price; -- can free 496 MB
      OPTIMZE TABLE testdb.mail; -- can free 5704 MB
      OPTIMZE TABLE testdb.basket; -- can free 20 MB
    Total freed space after theses OPTIMIZE TABLE : 6220 Mb
2016-06-02 09:40:42 +02:00
Jean-Marie Renouard
7dabf27c91 Merge pull request #210 from smutel/patch-3
Avoid deprecated message from perl
2016-05-20 00:32:24 +02:00
smutel
e14ddff904 Avoid deprecated message from perl
Use of implicit split to @_ is deprecated at /tmp/mysqltuner.pl line 3243 (#1)
    (D deprecated, W syntax) It makes a lot of work for the compiler when you
    clobber a subroutine's argument list, so it's better if you assign the results
    of a split() explicitly to an array (or list).
2016-05-19 17:10:48 +02:00
smutel
1048038e64 Avoid bad syntax error message
Error below when executing the script on RHEL6/OL6:
Warning: bad syntax, perhaps a bogus '-'? See /usr/share/doc/procps-3.2.8/FAQ
2016-05-19 17:06:12 +02:00
smutel
b2aea7f69d Update mysqltuner.pl 2016-05-19 13:47:46 +02:00
smutel
8e9cc50311 Exclude innodb engine from fragmented tables 2016-05-19 13:44:50 +02:00
Ian Gregory
7c1d5521ed Improve portability when fetching process memory - use ps rather than the proc filesystem 2016-05-10 10:34:30 +01:00
root
a7cd64a4c7 Increment version number 2016-05-09 10:17:14 +02:00
root
959a41b708 #204 updater works fine with curl now 2016-05-04 17:44:05 +02:00
root
f6f66a49ef #196 comment thread_cache_size recommandations 2016-04-29 14:25:16 +02:00
root
bead8a77ef Adding this message for <=5.1 version
No more password checks for MySQL version <=5.1
MySQL version <=5.1 are deprecated and end of support.
2016-04-29 14:19:46 +02:00
root
2e2d945e63 Fix #190 changing typo for recommandations on multiprocessor 2016-04-29 14:01:15 +02:00
root
1727a42b29 Fix #195 single quote enclosed password 2016-04-29 13:46:52 +02:00
jkavalik
92dc77e4cd Fix for #197
Merge GLOBAL status after SESSION - the non-global variables (like Percona from #184) will be present but stats are computed from GLOBAL counters which overwrite the SESSION ones if they exist.
2016-04-29 12:56:24 +02:00
Vadym Chepkov
ae0ab4bcff fixed wsrep_cluster_size handling
garbd node can be configured in galera cluster. wsrep_cluster_size includes the garbd node, but it is not listed in wsrep_cluster_address, since it does not participate in the replication.
2016-04-27 06:42:50 -04:00
Vadym Chepkov
7251a85234 fixed spelling 2016-04-22 11:26:00 -04:00
root
9b3549a92c #184 minor fix xtrabackup is the good alternative 2016-04-21 23:19:36 +02:00
root
c59a852a03 minor addition for sys schema #193 2016-04-21 23:16:35 +02:00
root
560b45894b #184 minor fix due to error message 2016-04-21 09:08:20 +02:00
root
737628dd1b Vulnerabilities list updated
#190 Query cache must be activated in MariaDB 10.1
#184 bug fix on messages
#184 xtrabackup support when wsrep_sst_method is starting by xtrabackup
2016-04-21 09:06:13 +02:00
root
fa1639e418 Tidify code 2016-04-19 16:19:31 +02:00
root
5b55c92ac5 #184: Additional information for galera
Removing dependency to Env module #192
2016-04-19 16:11:35 +02:00
root
a8babd7e69 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-04-19 16:04:13 +02:00
root
b67bba859f adding extra information about wsrep cluster size #184 2016-04-19 16:03:42 +02:00
Sergei A Mamonov
bc2017ba3e change external which to sub which(), little fix for use get_http_cli and get external ip via wget 2016-04-18 17:45:34 +03:00
root
80def03923 #187 enforce control over P_S activation 2016-04-18 11:07:05 +02:00
root
86ad610b6c #189 fix memory calculation when Galera is disabled 2016-04-18 10:59:50 +02:00
Jean-Marie RENOUARD
612eea48fd All version for galera checks #150 2016-04-15 10:17:56 -04:00
Jean-Marie RENOUARD
76a28ab29a Adding typo fixes
Adding check for memory with other process
2016-04-15 06:33:05 -04:00
Jean-Marie RENOUARD
e4a2534349 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-04-15 05:16:06 -04:00
root
66a57af80b #182 using abs value for result 2016-04-14 23:11:18 +02:00
root
ba584c91cc Update version #183 2016-04-14 22:49:21 +02:00
root
0ffe9507b6 #187 #183 removing unitialized variables code
#184 adding merge between show global variables and show global variables
#184 update RPM template'
2016-04-14 22:42:59 +02:00
Ricardo Velhote
eea101019e Detect Ubuntu correctly when checking for OS Release 2016-04-13 14:39:40 +01:00
Jean-Marie RENOUARD
5fd8432bb6 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2016-04-11 13:05:38 +02:00
Jean-Marie RENOUARD
709da2cc95 ident fix 2016-04-11 12:25:42 +02:00
Jean-Marie RENOUARD
d8a8dd42d3 ident fix 2016-04-11 12:24:49 +02:00
root
845dc030e1 Using a generic sub header function
get_pf_memory return 0 for performance memory if P_F is disabled.
2016-04-11 12:01:01 +02:00
Robert Milasan
8f0c2e6b33 Fix Galera checks, make sure we dont say that Galera is enabled when is not, clean-up typos 2016-04-06 10:33:56 +02:00
Jean-Marie RENOUARDjmrenouard@gmail.com
15854a6c94 #138 for threadpool in mariadb and percona use default values 2016-04-05 12:34:24 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
83010dd32e Bug fix on aria metrics 2016-04-05 12:25:20 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
a5449a0d22 Adding performance_schema.memoty value to max_used_memory and max_peak_memory calculation
There is always MySQL 5.7+ and adaptaive memory usage to handle porperly
2016-04-05 11:40:38 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
97cce402ae Adding get_http_cli for curl or wget detecting in sysstat 2016-04-05 09:49:43 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
974bd03ddf Adding new control for Galera cluster #150 2016-04-05 05:16:52 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
2d483e6b75 Check tables are all innodb table and check all table gets pk #150 2016-04-04 12:32:35 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
3ef98d83c1 Dumping mysql options for galera* #150 2016-04-04 11:30:16 -04:00
Jean-Marie RENOUARDjmrenouard@gmail.com
8203dcd686 Dumping galera options and status #150 2016-04-04 11:23:43 -04:00
Christine
c9cea2cc80 #177 bug with free -h changed to free -mwq 2016-04-04 13:58:52 +02:00
Christine
292cbfedad Adding some sysctl control in sysstat mode 2016-04-04 12:12:09 +02:00
Jean-Marie Renouard
0cdc7f53ca Merge pull request #179 from mrqwer88/fix_mount_output
fix mount point output for linux
2016-03-30 17:19:37 +02:00
root
c74d51e065 system information are only available with --sysstat #165 2016-03-30 17:16:16 +02:00
Sergei A Mamonov
ff796b48bf fix mount point output for linux 2016-03-30 15:59:47 +03:00
Sergei A Mamonov
45c468f324 add fixes to get_os_release for debian 6/7/8 2016-03-30 14:44:30 +03:00
root
d3a2d83d7d Just a simple perltidy to cleanup ident in the code. 2016-03-29 14:22:45 +02:00
Jean-Marie Renouard
8414de8a4d Merge pull request #176 from robertalks/master
Fix is_virtual_machine function return, drop ENV{'HOSTNAME'} for host…
2016-03-29 13:57:57 +02:00
Robert Milasan
cb5a1c528e Fix is_virtual_machine function return, drop ENV{'HOSTNAME'} for hostname cmd, some machines don't have HOSTNAME set 2016-03-29 09:51:48 +02:00
amq
94ee62a6e0 Fix grammar 2016-03-29 01:27:41 +02:00
root
a010416b93 Adding lot of system indicators #165 2016-03-25 16:22:07 +01:00
root
3f8ca6493e Adding disk space and inode control other fs mountpoint #165 2016-03-25 14:32:15 +01:00
root
c9ebae1e26 #166 removing test when plugin is unix_socket or win_socket
Support for bug https://bugs.mysql.com/bug.php?id=80860
2016-03-25 11:57:35 +01:00
DutchProgrammer
031898858b fix for perl 5.10 and 5.8 2016-03-24 23:58:48 +01:00
DutchProgrammer
5faf456d77 fix for perl 5.10 and 5.8 2016-03-24 23:56:45 +01:00
DutchProgrammer
2d4afc2e82 fix for perl 5.10 and 5.8 2016-03-24 23:41:30 +01:00
DutchProgrammer
774dbd8914 fix for perl 5.10 and 5.8 2016-03-24 23:31:52 +01:00
DutchProgrammer
5fb8e3dec7 fix for perl 5.10 and 5.8 2016-03-24 23:23:31 +01:00