Merge pull request #756 from jmrenouard/master

Refactoring format
This commit is contained in:
Jean-Marie Renouard 2024-02-07 01:11:00 +01:00 committed by GitHub
commit 235cc4e0f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 25 additions and 17 deletions

View file

@ -89,7 +89,8 @@ Unmaintenained staff from MySQL or MariaDB:
* Perl 5.6 or later (with [perl-doc](http://search.cpan.org/~dapm/perl-5.14.4/pod/perldoc.pod) package) * Perl 5.6 or later (with [perl-doc](http://search.cpan.org/~dapm/perl-5.14.4/pod/perldoc.pod) package)
* Unix/Linux based operating system (tested on Linux, BSD variants, and Solaris variants) * Unix/Linux based operating system (tested on Linux, BSD variants, and Solaris variants)
* Unrestricted read access to the MySQL server (OS root access recommended for MySQL < 5.1) * Unrestricted read access to the MySQL server
OS root access recommended for MySQL < 5.1
***WARNING*** ***WARNING***
-- --
@ -165,7 +166,6 @@ cd mariadb-sys-master
mysql -u root -p < ./sys_10.sql mysql -u root -p < ./sys_10.sql
``` ```
Performance schema setup Performance schema setup
-- --
@ -382,7 +382,6 @@ Follow instructions from Github repo
[GitHub AHA main repository](https://github.com/theZiz/aha) [GitHub AHA main repository](https://github.com/theZiz/aha)
**Using AHA Html report generation** **Using AHA Html report generation**
perl mysqltuner.pl --verbose --color > reports.txt perl mysqltuner.pl --verbose --color > reports.txt
@ -473,15 +472,22 @@ After which, `~/.mylogin.cnf` will be created with the appropriate access.
To get information about stored credentials, use the following command: To get information about stored credentials, use the following command:
$mysql_config_editor print ```bash
[client] $mysql_config_editor print
user = someusername [client]
password = ***** user = someusername
host = localhost password = *****
host = localhost
```
**Question: What's minimum privileges needed by a specific mysqltuner user in database ?** **Question: What's minimum privileges needed by a specific mysqltuner user in database ?**
mysql>GRANT SELECT, PROCESS,EXECUTE, REPLICATION CLIENT,SHOW DATABASES,SHOW VIEW ON *.* TO 'mysqltuner'@'localhost' identified by pwd1234; ```bash
mysql>GRANT SELECT, PROCESS,EXECUTE, REPLICATION CLIENT,
SHOW DATABASES,SHOW VIEW
ON *.*
TO 'mysqltuner'@'localhost' identified by pwd1234;
```
**Question: It's not working on my OS! What gives?!** **Question: It's not working on my OS! What gives?!**

View file

@ -6372,13 +6372,15 @@ sub mysql_innodb {
# ,2) as "PCT ALLOC/BUFFER POOL" # ,2) as "PCT ALLOC/BUFFER POOL"
#from sys.x$innodb_buffer_stats_by_table; #from sys.x$innodb_buffer_stats_by_table;
if ( $mycalc{innodb_buffer_alloc_pct} < 80 ) { if (defined $mycalc{innodb_buffer_alloc_pct}) {
badprint "Ratio Buffer Pool allocated / Buffer Pool Size: " if ( $mycalc{innodb_buffer_alloc_pct} < 80 ) {
. $mycalc{'innodb_buffer_alloc_pct'} . '%'; badprint "Ratio Buffer Pool allocated / Buffer Pool Size: "
} . $mycalc{'innodb_buffer_alloc_pct'} . '%';
else { }
goodprint "Ratio Buffer Pool allocated / Buffer Pool Size: " else {
. $mycalc{'innodb_buffer_alloc_pct'} . '%'; goodprint "Ratio Buffer Pool allocated / Buffer Pool Size: "
. $mycalc{'innodb_buffer_alloc_pct'} . '%';
}
} }
if ( $mycalc{'innodb_log_size_pct'} < 20 if ( $mycalc{'innodb_log_size_pct'} < 20
or $mycalc{'innodb_log_size_pct'} > 30 ) or $mycalc{'innodb_log_size_pct'} > 30 )