hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #281 from mrqwer88/fix_in_log_file_recommandations

Browse source 
Fix in log file recommandations
This commit is contained in:
Jean-Marie Renouard 2016-12-07 15:18:49 +01:00 committed by GitHub
commit 7082cbc678
1 changed files with 59 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
mysqltuner.pl
View file

@ -1127,8 +1127,8 @@ sub log_file_recommandations {
goodprint "Log file $myvar{'log_error'} is smaller than 32 Mb";
} else {
badprint "Log file $myvar{'log_error'} is bigger than 32 Mb";
push( @generalrec,
$myvar{'log_error'} ."is > 32Mb, you should analyze why or implement a rotation log strategy such as logrotate!" );
push @generalrec,
$myvar{'log_error'} ."is > 32Mb, you should analyze why or implement a rotation log strategy such as logrotate!" ;
}
my @log_content = get_file_contents($myvar{'log_error'});
@ -1148,28 +1148,36 @@ sub log_file_recommandations {
}
if ( $nbWarnLog > 0 ) {
badprint "$myvar{'log_error'} contains $nbWarnLog warning(s).";
push( @generalrec, "Control warning line(s) into $myvar{'log_error'} file");
push @generalrec, "Control warning line(s) into $myvar{'log_error'} file";
} else {
goodprint "$myvar{'log_error'} doesn't contain any warning.";
}
if ( $nbErrLog > 0 ) {
badprint "$myvar{'log_error'} contains $nbErrLog error(s).";
push( @generalrec, "Control error line(s) into $myvar{'log_error'} file");
push @generalrec, "Control error line(s) into $myvar{'log_error'} file";
} else {
goodprint "$myvar{'log_error'} doesn't contain any error.";
}
infoprint scalar(@lastStarts). " start(s) detected in $myvar{'log_error'}";
infoprint scalar @lastStarts . " start(s) detected in $myvar{'log_error'}";
my $nStart = 0;
for my $startd (reverse @lastStarts[-10..-1]) {
my $nEnd = 10;
if ( scalar @lastStarts < $nEnd ) {
$nEnd = scalar @lastStarts;
}
for my $startd ( reverse @lastStarts[-$nEnd..-1] ) {
$nStart++;
infoprint "$nStart) $startd";
}
infoprint scalar(@lastShutdowns). " shutdown(s) detected in $myvar{'log_error'}";
my $nShut=0;
for my $shutd (reverse @lastShutdowns[-10..-1]) {
$nShut++;
infoprint "$nShut) $shutd";
infoprint scalar @lastShutdowns . " shutdown(s) detected in $myvar{'log_error'}";
$nStart=0;
$nEnd=10;
if ( scalar @lastShutdowns < $nEnd ) {
$nEnd = scalar @lastShutdowns;
}
for my $shutd ( reverse @lastShutdowns[-$nEnd..-1] ) {
$nStart++;
infoprint "$nStart) $shutd";
}
#exit 0;
}