hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert préview on skip name resolve

Browse source 
Name resolve should be OFF by default except for CPANEL & FLEX
This commit is contained in:
Jean-Marie Renouard 2023-05-30 09:11:06 +02:00
parent 5dd0dec278
commit cb4784e8c7
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
mysqltuner.pl
View file

@ -3275,13 +3275,13 @@ sub mysql_stats {
push( @adjvars, "skip-name-resolve=0" ); push( @adjvars, "skip-name-resolve=0" );
} }
} }
elsif ( $result{'Variables'}{'skip_name_resolve'} eq 'OFF' ) { elsif ( $result{'Variables'}{'skip_name_resolve'} ne 'OFF' ) {
badprint badprint
"Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance"; "Name resolution is active: a reverse name resolution is made for each new connection which can reduce performance";
push( @generalrec, push( @generalrec,
"Configure your accounts with ip or subnets only, then update your configuration with skip-name-resolve=1" "Configure your accounts with ip or subnets only, then update your configuration with skip-name-resolve=OFF"
); );
push( @adjvars, "skip-name-resolve=1" ); push( @adjvars, "skip-name-resolve=OFF" );
} }
# Query cache # Query cache
@ -3965,11 +3965,11 @@ sub mysqsl_pfs {
# Store all sys schema in dumpdir if defined # Store all sys schema in dumpdir if defined
if ( defined $opt{dumpdir} and -d "$opt{dumpdir}" ) { if ( defined $opt{dumpdir} and -d "$opt{dumpdir}" ) {
for my $pfs_view ( select_array('use sys;show tables;') ) { for my $sys_view ( select_array('use sys;show tables;') ) {
infoprint "Dumping $pfs_view into $opt{dumpdir}"; infoprint "Dumping $sys_view into $opt{dumpdir}";
select_csv_file( select_csv_file(
"$opt{dumpdir}/pfs_$pfs_view.csv", "$opt{dumpdir}/sys_$sys_view.csv",
"select * from sys.$pfs_view" "select * from sys.\`$sys_view\`"
); );
} }
exit 0 if ( $opt{stop} == 1 ); exit 0 if ( $opt{stop} == 1 );