hhf/MySQLTuner-perl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386

Browse source
This commit is contained in:
Jean-Marie Renouard 2018-09-26 07:31:19 +00:00
parent b8224beb85
commit dab1e7e960
1 changed files with 29 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
mysqltuner.pl
View file

@ -1,5 +1,5 @@
#!/usr/bin/env perl #!/usr/bin/env perl
# mysqltuner.pl - Version 1.7.12 # mysqltuner.pl - Version 1.7.13
# High Performance MySQL Tuning Script # High Performance MySQL Tuning Script
# Copyright (C) 2006-2018 Major Hayden - major@mhtx.net # Copyright (C) 2006-2018 Major Hayden - major@mhtx.net
# #
@ -56,7 +56,7 @@ $Data::Dumper::Pair = " : ";
#use Env; #use Env;
# Set up a few variables for use in the script # Set up a few variables for use in the script
my $tunerversion = "1.7.12"; my $tunerversion = "1.7.13";
my ( @adjvars, @generalrec ); my ( @adjvars, @generalrec );
# Set defaults # Set defaults
@ -3070,17 +3070,32 @@ sub mysql_stats {
} }
# Thread cache # Thread cache
if ( $myvar{'thread_cache_size'} eq 0 ) { # if ( $myvar{'thread_cache_size'} eq 0 ) {
badprint "Thread cache is disabled"; # badprint "Thread cache is disabled";
push( @generalrec, "Set thread_cache_size to 4 as a starting value" ); # push( @generalrec, "Set thread_cache_size to 4 as a starting value" );
push( @adjvars, "thread_cache_size (start at 4)" ); # push( @adjvars, "thread_cache_size (start at 4)" );
} # }
else { # else {
if ( defined( $myvar{'thread_handling'} ) # if ( defined( $myvar{'thread_handling'} )
and $myvar{'thread_handling'} eq 'pools-of-threads' ) # and $myvar{'thread_handling'} eq 'pools-of-threads' )
{ # {
infoprint "Thread cache hit rate: not used with pool-of-threads"; # infoprint "Thread cache hit rate: not used with pool-of-threads";
} # }
if ( defined( $myvar{'thread_handling'} )
and $myvar{'thread_handling'} eq 'pool-of-threads' )
{
# https://www.percona.com/doc/percona-server/LATEST/performance/threadpool.html
# When thread pool is enabled, the value of the thread_cache_size variable
# is ignored. The Threads_cached status variable contains 0 in this case.
infoprint "Thread cache not used with thread_handling=pool-of-threads";
}
else {
if ( $myvar{'thread_cache_size'} eq 0 ) {
badprint "Thread cache is disabled";
push( @generalrec, "Set thread_cache_size to 4 as a starting value" );
push( @adjvars, "thread_cache_size (start at 4)" );
}
else { else {
if ( $mycalc{'thread_cache_hit_rate'} <= 50 ) { if ( $mycalc{'thread_cache_hit_rate'} <= 50 ) {
badprint badprint
@ -6292,7 +6307,7 @@ __END__
=head1 NAME =head1 NAME
MySQLTuner 1.7.12 - MySQL High Performance Tuning Script MySQLTuner 1.7.13 - MySQL High Performance Tuning Script
=head1 IMPORTANT USAGE GUIDELINES =head1 IMPORTANT USAGE GUIDELINES