Commit graph

1251 commits

Author SHA1 Message Date
Jean-Marie Renouard
3a7bf40c83
Merge pull request #524 from grooverdan/aria_myisam
Aria/MyISAM cleanup
2021-01-27 21:27:12 +01:00
Daniel Black
9d1d19c97d mariadb gtid mode - base off gtid_current_pos.
gtid_strict_mode isn't sufficient a test for
MariaDB's GTID mode. The gtid_current_pos
however is always non-blank if GTID is enabled.

closes #513
2021-01-27 18:03:41 +11:00
Daniel Black
083dc22c60 supported version: +mariadb-10.5, eol mysql-5.6, mariadb-10.[01]
Add mariadb-10.5 as a supported version.

Remove MySQL/MariaDB eol versions from their origin of support.
2021-01-27 17:34:02 +11:00
Daniel Black
fa8deec762 mariadb is using its on name in mariadb/mariadb-admin
The mysql client, mysql, in mariadb is starting to be labeled mariadb.
Likewise mysqladmin is getting called mariadb-admin. Lets check
for these names as well.
2021-01-27 17:26:29 +11:00
Daniel Black
2f45f349c9 anonymous users - remove password checks
For anonymous users, those with user='', having a recommendation
to set their passwords, and warning that the password is the same
as the username is a little excessive since there's already a
recommendation to drop the user.

So let's remove those recommendation so we don't see:

[!!] User '@localhost' has user name as password.
[!!] User '@localhost.localdomain' has user name as password.

or:

    Set up a Secure Password for @localhost user: SET PASSWORD FOR ''@'SpecificDNSorIp' = PASSWORD('secure_password');
    Set up a Secure Password for @localhost.localdomain user: SET PASSWORD FOR ''@'SpecificDNSorIp' = PASSWORD('secure_password');

Lets keep the focus on:
-------- Security Recommendations ------------------------------------------------------------------
[!!] User ''@'localhost' is an anonymous account. Remove with DROP USER ''@'localhost';
[!!] User ''@'localhost.localdomain' is an anonymous account. Remove with DROP USER ''@'localhost.localdomain';
2021-01-27 17:15:03 +11:00
Daniel Black
3ac95cd046 query_cache off with query_cache_type=OFF OR query_cache_size=0
From the MySQL and MariaDB code (same - 5.5 version):
https://github.com/mysql/mysql-server/blob/5.5/sql/sql_cache.h#L560
https://github.com/MariaDB/server/blob/5.5/sql/sql_cache.h#L572

This is used:
https://github.com/mysql/mysql-server/blob/5.5/sql/sql_prepare.cc#L3058
(same in MariaDB code)

The size=0 and type=0 are both sufficent conditions for the query
cache to be disabled. As such lets consider it ok if its disabled
only in one place. This is the case in mariadb where type=0 (OFF)
is the default as is a non-zero query-cache size.
2021-01-27 17:02:58 +11:00
Daniel Black
99e5c83779 Aria/MyISAM cleanup
Include calculation of Aria index size based of *.MAI files.

Use find -0 | xargs -0 to allow for space containing names.
Quote datadir in find in case it had spaces.

Use xargs -r (GNU extension) (supported Linux, FreeBSD, OpenBSD,
NetBSD, not Solaris, not OSX) to not run if there's no files that match.
This prevents it running the total of the current directory if
there are no M[YA]I files.

A total size of 0 for Aria or MyISAM indexes isn't a problem
because:
* MySQL-5.[567] used MyISAM system tables which have indexes, so 0
wasn't possible (except for remote user without mysql.* access).
* 0 size of index is equally likely to be 0 tables of this type
  (e.g. MySQL-8.0, or MariaDB-10.4+ (Aria default, not MyISAM)).

Setting total_aria_indexes=1 when it was previously 0 is misleading.

Aria was never called AriaDB despite the apparent convention in
other storage engines so use just Aria, or Aria Storage Engine
in messages.

Differentiate between Aria not available and disabled in report.
2021-01-27 15:56:10 +11:00
Jean-Marie Renouard
9a9ff555ee
Update README.md 2020-12-29 15:14:36 +01:00
Jean-Marie Renouard
374b34430e
Update README.md 2020-12-29 15:14:11 +01:00
Jean-Marie Renouard
ea6a33264b
Add a simple Logo 2020-12-29 15:11:43 +01:00
Jean-Marie Renouard
df56ff11ad
Merge pull request #519 from sergey-dryabzhinsky/sergey-dryabzhinsky-patch-1
For #518 - use new schema for mariab-10.2+ to make passwords check
2020-12-27 19:41:59 +01:00
Sergey Dryabzhinsky
ce23262b27 Fix else+if construction 2020-12-26 12:32:59 +03:00
Sergey Dryabzhinsky
b1a1829362
For #518 - use new schema for mariab-10.2+
And check for one more column existance
2020-12-26 12:02:51 +03:00
Jean-Marie Renouard
aac1ab2b4d
Merge pull request #514 from grooverdan/mdb10.4-secure-users
secure users MariaDB-10.4+ / MySQL auth socket
2020-12-08 08:30:23 +01:00
Jean-Marie Renouard
643e5e4e98
Merge pull request #515 from grooverdan/delanonymous
DROP USER to delete anonymous accounts
2020-12-08 08:30:04 +01:00
Jean-Marie Renouard
b8effe6410
Merge pull request #516 from grooverdan/supported_versions
MariaDB-10.1 EOL, MariaDB-10.5 is GA
2020-12-08 08:29:44 +01:00
Daniel Black
6f966dee45 MariaDB-10.1 EOL, MariaDB-10.5 is GA 2020-12-08 15:25:59 +11:00
Daniel Black
1bb30f508e DROP USER to delete anonymous accounts
DROP USER has existed for a very long time.

Use the QUOTE sql function to ensure accounts are correctly quoted
and this helps the delete recommendation.
2020-12-08 14:37:26 +11:00
Daniel Black
79a4403c9c MySQL-5.7/8.0+ auth_socket is safe
MySQL has auth_socket as its plugin compared to unix_socket on MariaDB
so accept that as a valid reason for having no authentication.

MySQL [(none)]> show create user dan@localhost;
+-----------------------------------------------------------------------------------------------------------------+
| CREATE USER for dan@localhost                                                                                   |
+-----------------------------------------------------------------------------------------------------------------+
| CREATE USER 'dan'@'localhost' IDENTIFIED WITH 'auth_socket' REQUIRE NONE PASSWORD EXPIRE DEFAULT ACCOUNT UNLOCK |
+-----------------------------------------------------------------------------------------------------------------+
1 row in set (0.000 sec)

MySQL [(none)]> select user,host,plugin from mysql.user;
+---------------+-----------+-----------------------+
| user          | host      | plugin                |
+---------------+-----------+-----------------------+
| root          | localhost | mysql_native_password |
| mysql.session | localhost | mysql_native_password |
| mysql.sys     | localhost | mysql_native_password |
| dan           | localhost | auth_socket           |
| expiretest    | %         | mysql_native_password |
| expiretest    | localhost | mysql_native_password |
+---------------+-----------+-----------------------+
6 rows in set (0.001 sec)

MySQL [(none)]> select version();
+-----------+
| version() |
+-----------+
| 5.7.31    |
+-----------+
2020-12-08 14:18:03 +11:00
Daniel Black
0eef9260a8 mariadb-10.4+ empty passwords
MariaDB-10.4 migrated their authentication to a global_priv table in JSON
format. Also locked user accounts where added. By default the mariadb.sys
is a locked user without a password and there as the owner of the mysql.user
view. As its hazardous for a user to modify this we exclude locked accounts
but still search for mysql_native_password plugin without authentication.

We use versioned comments to process all other versions. The 5.5+ MySQL
version comment is also read by MariaDB (ref: https://mariadb.com/kb/en/comment-syntax/
enabling the processing of plugins on other version that have plugins.

While this branch doesn't yet apply to MySQL-8.0 yet, we add support
for the locked user accounts in MySQL-8.0+ in a versioned comment
(not read by MariaDB).
2020-12-08 14:00:39 +11:00
Jean-Marie Renouard
de4b145e96 Remove innodb_buffer_pool_instances recommendations for MariaDB #512
Remove innodb_buffer_pool_instances recommendations for MariaDB #512
2020-11-16 20:22:24 +01:00
Jean-Marie Renouard
b5718d0e2f Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2020-11-05 17:29:32 +01:00
Jean-Marie Renouard
cff819d46f Change version number 2020-11-05 17:29:26 +01:00
Jean-Marie Renouard
026ed6db4f Update README.md 2020-10-08 11:48:00 +02:00
Jean-Marie Renouard
a3f72fec6c
Update USAGE.md 2020-09-15 15:26:15 +02:00
Jean-Marie Renouard
d25f8a9230
Merge pull request #507 from RULCSoft/master
Remove references to the domain mysqltuner.com. #501
2020-09-15 15:24:17 +02:00
Jorge Vallecillo
d2a8f0b60a Remove references to the domain mysqltuner.com. #501 2020-09-03 10:17:58 -06:00
Jean-Marie Renouard
b6f8f9f9a3 Merge branch 'master' of https://github.com/major/MySQLTuner-perl 2020-05-04 11:02:49 +02:00
Jean-Marie Renouard
00ce968c6a Removing windows end of lines 2020-05-04 11:01:34 +02:00
Jean-Marie Renouard
6038bd7749 Update mysqltuner.pl
Back to MYsqltuner 1.7.19
2020-05-03 23:12:19 +02:00
Jean-Marie Renouard
9236ec0f80 Update mysqltuner.pl
Fix error
2020-05-03 23:07:42 +02:00
Jean-Marie RENOUARD
1e8b32a253 merged 2020-05-02 16:01:37 +02:00
root
12ae60c6f2 local commit 2020-05-02 15:56:26 +02:00
Jean-Marie Renouard
094f16f67c
Merge pull request #473 from unreturned/fix_471
Possible fix for #471
2020-01-23 18:23:19 +01:00
Kovalkov Dmitrii
e7609d7a91 And for debug line ignore these lines 2020-01-23 16:37:45 +03:00
Kovalkov Dmitrii
dc4aa248c8 Ignore
200122 12:09:15 mysqld_safe Logging to '/var/log/mysql/error.log'.
when we count errors in log
2020-01-23 11:24:56 +03:00
Jean-Marie Renouard
b5ffe58506
Merge pull request #470 from mrqwer88/README.ru_update
Update README.ru.md
2020-01-20 19:07:52 +01:00
Sergei A Mamonov
d3ab6db641 Update README.ru.md 2020-01-20 21:04:32 +03:00
Jean-Marie Renouard
7965211fa0
Merge pull request #466 from Ruzgfpegk/bugfix/mariadb-sys-update
Suggest using mariadb-sys from FromDual in script
2020-01-09 22:16:39 +01:00
Jean-Marie Renouard
8f34a00f18
Merge pull request #468 from Ruzgfpegk/bugfix/myisam-table_cache-doclink
Updates link to MyISAM table_cache scalability doc
2020-01-09 22:16:15 +01:00
Ruzgfpegk
8ffd81475a
Updates link to MyISAM table_cache scalability doc
Fixes #465 .
2020-01-09 15:53:56 +09:00
Ruzgfpegk
3555142ead
Suggest using mariadb-sys from FromDual in script
Follows #443 and #444.
2020-01-09 15:04:04 +09:00
Jean-Marie Renouard
80920ad061
Merge pull request #464 from jfcoz/max_allowed_packet
Include max_allowed_packet in thread memory size
2020-01-08 20:48:52 +01:00
jfcoz
c5765f0213 Include max_allowed_packet in thread memory size
Fix https://github.com/major/MySQLTuner-perl/issues/378
Fix https://github.com/major/MySQLTuner-perl/issues/456
2019-12-12 13:31:23 +01:00
Jean-Marie Renouard
345bf1ae24 Issue Typo in commit 6f6130b (ymsql => mysql) (#459) 2019-10-17 17:39:45 +02:00
Jean-Marie Renouard
216a0a9889 Update .travis.yml 2019-10-16 20:22:50 +02:00
Jean-Marie Renouard
95ed36c1ee Update .travis.yml 2019-10-16 20:22:03 +02:00
Jean-Marie Renouard
f6fae6713d Update .travis.yml 2019-10-16 20:14:33 +02:00
Jean-Marie Renouard
e1891570e3 Validate YAML format 2019-10-16 20:11:59 +02:00
Jean-Marie Renouard
a1c1624b81 Update .travis.yml 2019-10-16 20:02:43 +02:00