MichaIng
8ed76b05ba
Do not show thread pool metrics when disabled
...
Currently thread pool metrics are shown whenever the "thread_pool_size" variable is set. At least on MariaDB this variable is however set even when the thread pool is disabled. This commit changes the check for whether a thread pool is used for client connection handling or not by comparing the "thread_handling" variable value against "pool-of-threads" (MariaDB) or "loaded-dynamically" (MySQL):
- https://mariadb.com/kb/en/thread-pool-system-status-variables/#thread_handling
- https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_thread_handling
The check for whether to show the thread cache metrics is now based on the same derived internal "have_threadpool" variable, effectively skipping thread cache metrics as well on MySQL when the thread pool is not enabled with "thread_handling = loaded-dynamically". The code comment link to Percona about whether the thread cache is used with thread pool enabled has been pinned to v5.7, the latest version which contains the quoted statement. The statement is however still true for MariaDB and MySQL:
- https://mariadb.com/kb/en/server-system-variables/#thread_cache_size
Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-15 18:22:47 +01:00
Jean-Marie Renouard
926c9a92ca
A lot of new info about indexes and table structures
2022-01-03 18:54:54 +01:00
Jean-Marie Renouard
c1661f326e
Merge pull request #575 from MichaIng/imgbot
...
[ImgBot] Optimize images
2021-11-24 15:33:58 +01:00
Jean-Marie Renouard
12a96cb08e
Merge pull request #572 from MichaIng/patch-1
...
Fix key buffer usage multiple-byte units
2021-11-24 09:58:16 +01:00
Jean-Marie Renouard
1c68fe1b1a
#574 script modified with CR end of line
2021-11-23 16:00:58 +01:00
MichaIng
7d53af73cc
Fix key buffer usage multiple-byte units
...
The "Key buffer used" row showed 131072 bytes as 131K while it should be shown as 128K, so that it matches the multi-byte units key buffer size in the "Key buffer size / total MyISAM indexes" row below.
Furthermore, instead of calculating the used bytes from the previously calculated percentage, doing a round trip which involves rounding errors, calculate the used bytes from the variables directly which does not involve any diversion and hence no possible rounding errors.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-11-22 14:49:23 +01:00
ImgBotApp
73af0190d3
[ImgBot] Optimize images
...
*Total -- 82.40kb -> 49.98kb (39.35%)
/mysqltuner.png -- 77.03kb -> 45.43kb (41.02%)
/mtlogo.png -- 5.37kb -> 4.55kb (15.39%)
Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-11-22 12:58:00 +00:00
Jean-Marie Renouard
cb74b1947e
Adding Releem App link to Readme
2021-10-22 14:52:38 +02:00
Jean-Marie Renouard
6090b0fa9c
Bad merge roolback
2021-10-22 14:50:09 +02:00
Jean-Marie Renouard
a146c81b7c
Wrong recommendation "thread_pool_size between 16 and 36 for InnoDB usage" for Percona Server
...
#551 "
2021-10-16 17:07:14 +02:00
Jean-Marie Renouard
0d897f8c5b
Merge pull request #568 from 64kramsystem/fix_innodb_log_buffer_size_message
...
Fix `innodb_log_buffer_size` message
2021-10-15 16:33:37 +02:00
Jean-Marie Renouard
6b6d85ef28
Wrong recommendation "thread_pool_size between 16 and 36 for InnoDB usage" for Percona Server ( #551 )
2021-10-15 16:28:19 +02:00
Jean-Marie Renouard
1333ea9395
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-10-15 13:56:27 +02:00
Jean-Marie Renouard
c0251a1488
Can't locate Data/Dumper.pm in @INC #564
2021-10-15 13:43:07 +02:00
Saverio Miroddi
85d7d6b6a8
Fix innodb_log_buffer_size
message
...
The operator used to recommend the user to increase the log buffer size (`>=`) is confusing.
Closes #567 (which includes a detailed description).
2021-10-15 10:39:03 +02:00
Jean-Marie Renouard
d04c1c46dc
Increment releas number
2021-09-28 17:31:55 +02:00
Jean-Marie Renouard
24ccf47d6e
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-09-27 12:28:31 +02:00
Jean-Marie Renouard
5b96d08004
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-09-27 12:25:12 +02:00
Jean-Marie Renouard
1bdb4b1aea
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-09-27 12:21:50 +02:00
Jean-Marie Renouard
1ecb2e9854
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-09-27 12:08:36 +02:00
Jean-Marie Renouard
87aff130f3
Merge done
2021-09-27 12:07:52 +02:00
Jean-Marie Renouard
467e999a17
clean end line
2021-09-27 11:55:22 +02:00
Jean-Marie Renouard
0aa4995bed
Merge pull request #563 from Steve8291/patch-1
...
Fix Replication Status
2021-08-26 17:14:52 +02:00
Steve8291
911b1294fa
Fix Replication Status
...
Reference Issue #553
Reversing the check for version of mysql or mariadb to use correct command.
2021-08-26 10:21:23 -04:00
Jean-Marie Renouard
3225a954fc
Merge pull request #559 from willamowius/master
...
fix English grammar
2021-08-25 12:05:36 +02:00
Jean-Marie RENOUARD
645e034efd
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-08-25 12:03:29 +02:00
Jean-Marie RENOUARD
1e9920b545
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-08-25 12:01:28 +02:00
Jean-Marie RENOUARD
d37a1f7c79
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-08-25 11:56:11 +02:00
Jan Willamowius
6584233c72
fix English grammar
2021-07-17 08:35:44 +02:00
Jean-Marie Renouard
7aa57fa770
Illegal division by zero at ./mysqltuner.pl line 2745 #558
...
Wrong table cache hit rate calculation #548
2021-07-15 17:03:00 +02:00
Jean-Marie Renouard
7a2a0f1b13
Illegal division by zero at ./mysqltuner.pl line 2745 #558
...
Wrong table cache hit rate calculation #548
2021-07-15 17:02:24 +02:00
Jean-Marie Renouard
78d8f3ed85
Version 1.8.0: Support MariaDB 10.6 Update needed for MariaDB 10.6 #557
2021-07-13 18:56:52 +02:00
Jean-Marie Renouard
dde94aa343
Create exec.yml
2021-07-05 08:45:01 +02:00
Jean-Marie Renouard
656a7e51ed
Update Vulnerabilities list
...
Indenting mysqltuner
Update Usage information
2021-07-02 18:31:21 +02:00
Jean-Marie Renouard
8f479b06f6
Increment version
2021-07-02 18:17:57 +02:00
Jean-Marie Renouard
2079639e6b
Wrong table cache hit rate calculation #548
2021-07-02 18:17:25 +02:00
Jean-Marie Renouard
213211aecc
improve FreeBSD support a bit (patch included) #549
2021-07-02 16:55:43 +02:00
Jean-Marie Renouard
52d3fc4d7c
failed to execute: SHOW SLAVE HOSTS #553
2021-07-02 16:44:11 +02:00
Jean-Marie Renouard
47cf0669fc
failed to execute: SHOW SLAVE HOSTS #553
2021-07-02 16:41:36 +02:00
Jean-Marie Renouard
c9345a1380
1.7.26 is fixing minor glitch with DROP USER #555
2021-07-02 16:22:51 +02:00
Jean-Marie RENOUARD
5aa880afbc
Wrong recommendation "thread_pool_size between 16 and 36 for InnoDB usage" for Percona Server #551
2021-05-03 12:00:02 +00:00
Jean-Marie RENOUARD
85d5015a1d
some aliases
2021-05-03 10:12:00 +00:00
Jean-Marie RENOUARD
76c9343fb9
Merge branch 'master' of https://github.com/major/MySQLTuner-perl
2021-05-03 10:11:35 +00:00
Jean-Marie RENOUARD
71b2f0b144
Some new aliases
2021-05-03 10:10:47 +00:00
Jean-Marie Renouard
447652d325
Update mysqltuner.pl
2021-05-03 11:06:23 +02:00
Jean-Marie Renouard
ac34523609
Update mysqltuner.pl
2021-03-30 11:54:30 +02:00
Jean-Marie Renouard
68e5902169
Update mysqltuner.pl
2021-03-30 11:44:08 +02:00
Jean-Marie Renouard
948c09ab86
Update README.md
...
Pull request documentation
2021-03-15 10:06:44 +01:00
Jean-Marie Renouard
a8fc0c2639
Update mysqltuner.pl
...
Adding more information about flow control current value
2021-03-08 18:29:03 +01:00
Jean-Marie Renouard
b0cfbd802b
Duplicate recommendation/check #545
...
Duplicate recommendation/check #545
2021-03-08 18:02:22 +01:00